project/addthis.git
2 years agoIssue #1349056 by matglas86: Fixed Google Analytics functions implemented twice in...
Matthias Glastra [Tue, 22 Nov 2011 06:21:11 +0000]
Issue #1349056 by matglas86: Fixed Google Analytics functions implemented twice in AddThis class

2 years agoMerged the 'master' back to '7.x-4.x'
Matthias Glastra [Mon, 21 Nov 2011 14:49:46 +0000]
Merged the 'master' back to '7.x-4.x'

2 years agoText cleanup.
Jani Palsamäki [Mon, 21 Nov 2011 12:06:47 +0000]
Text cleanup.

2 years agoText cleanup.
Jani Palsamäki [Mon, 21 Nov 2011 12:06:08 +0000]
Text cleanup.

2 years agoCleaning up tests.
Jani Palsamäki [Mon, 21 Nov 2011 11:17:19 +0000]
Cleaning up tests.

2 years agoCode review and cleanup.
Jani Palsamäki [Mon, 21 Nov 2011 10:18:13 +0000]
Code review and cleanup.

2 years agoAdded namespace adding for Facebook Like.
Matthias Glastra [Sat, 19 Nov 2011 23:17:53 +0000]
Added namespace adding for Facebook Like.
Added counter bubble orientation in Basic Toolbox display type.
Fixed getDisplayTypes() to work with blocks. Also provide default settings always.
Add t() to description of Google Analytics elements in config page.

2 years agoIssue #1062132 by jamiecuthill | iler: Added Enable click tracking and Google Analyti...
Matthias Glastra [Thu, 17 Nov 2011 15:52:07 +0000]
Issue #1062132 by jamiecuthill | iler: Added Enable click tracking and Google Analytics support.

Adding Google Analytics and Social Tracking support.

2 years agoMerged Google Analytics and Social Tracking from 7.x-4.x.
Matthias Glastra [Thu, 17 Nov 2011 16:08:00 +0000]
Merged Google Analytics and Social Tracking from 7.x-4.x.

2 years agoRemoved legacy display types. Redesigned the config page.
Matthias Glastra [Thu, 17 Nov 2011 08:05:47 +0000]
Removed legacy display types. Redesigned the config page.

Removed legacy display types.
  AddThis module contained some small non generic display types. They where
  removed in favor of the display types added in the addthis_displays submodule.

Redesigned the config page.
  The settings page has been made more condensed and options have been merged
  into clear categories. There are some options that where removed because of
  legacy functionality that is now support inside the display types.

2 years agoFixed folder spelling error.
Matthias Glastra [Wed, 16 Nov 2011 13:21:10 +0000]
Fixed folder spelling error.

The submodule is called addthis_displays and the folder was called
addthis_display without the s at the and. Now the folder has the
correct name.

2 years agoRan Grammar Parser over it and fixed some coding standard things.
Matthias Glastra [Thu, 10 Nov 2011 21:26:13 +0000]
Ran Grammar Parser over it and fixed some coding standard things.

2 years agoUpdated changelog. Fixed co_brand default value.
Matthias Glastra [Wed, 9 Nov 2011 09:30:47 +0000]
Updated changelog. Fixed co_brand default value.

The co_brand default value was null. This showed on the compact menu. I set the
default to '' empty now.

I also added some lines to the changelog as I did not do that in the last
few commits.

2 years agoAdded #display information to render array for reference in alter functions.
Matthias Glastra [Wed, 9 Nov 2011 07:38:00 +0000]
Added #display information to render array for reference in alter functions.

2 years agoAdded alter hooks for markup and for the options, added service name reference.
Matthias Glastra [Tue, 8 Nov 2011 16:15:23 +0000]
Added alter hooks for markup and for the options, added service name reference.

I added two alter hooks. On is to alter the markup that is used to do stuff with
the render array. The other is to alter the options that are used to help in
rendering the markup for example entity, url and display settings.

I also added a #addthis_service to the render array that is support information
for alter implementations that want to do stuff with specific service elements.

2 years agoMade a basic implementation for Toolbox and Button complete.
Matthias Glastra [Tue, 8 Nov 2011 15:08:06 +0000]
Made a basic implementation for Toolbox and Button complete.

2 years agoFixes in markup processing.
Matthias Glastra [Tue, 8 Nov 2011 14:27:34 +0000]
Fixes in markup processing.

2 years agoMerge branch 'master' into develop
Matthias Glastra [Thu, 3 Nov 2011 21:08:30 +0000]
Merge branch 'master' into develop

2 years agoMerging 7.x-4.x changes back.
Matthias Glastra [Thu, 3 Nov 2011 17:51:15 +0000]
Merging 7.x-4.x changes back.

Trying to get to a point where 7.x-4.x are the same. Its imposible to
now to rebase because I'm just getting to know git now :)

commit c33ad4f2a08bd07a43af918501ccbef32c14e93d
Author: Matthias Glastra <matglas.git@gmail.com>
Date:   Thu Nov 3 13:50:23 2011 +0100

    Adding language support through ui_language on global settings.

commit e2edbe126a9763a6fd50bc60290f8bb35d6f77dd
Author: Matthias Glastra <matglas.git@gmail.com>
Date:   Thu Nov 3 17:58:52 2011 +0100

    Issue #1324464 by sillygwailo: Fixed Toolbox doesn't show when set to asynchronous mode.

    There was the problem that addthis.init() was called before the file was loaded. Now
    the function is called inside the callback of script loaded.

2 years agoAdding language support through ui_language on global settings.
Matthias Glastra [Thu, 3 Nov 2011 12:50:23 +0000]
Adding language support through ui_language on global settings.

2 years agoIssue #1324464 by sillygwailo: Fixed Toolbox doesn't show when set to asynchronous...
Matthias Glastra [Thu, 3 Nov 2011 16:58:52 +0000]
Issue #1324464 by sillygwailo: Fixed Toolbox doesn't show when set to asynchronous mode.

There was the problem that addthis.init() was called before the file was loaded. Now
the function is called inside the callback of script loaded.

2 years agoChanged some references to class constants to a syntax supported by PHP 5.2 (http...
Jani Palsamäki [Tue, 18 Oct 2011 10:33:04 +0000]
Changed some references to class constants to a syntax supported by PHP 5.2 (php.net/manual/en/language.oop5.constants.php). Referencing class constants via variable does not work with PHP5.2.

2 years agoMerge branch '7.x-4.x'
Matthias Glastra [Sun, 16 Oct 2011 21:25:09 +0000]
Merge branch '7.x-4.x'

2 years agoFix for #1308970 reported by vasike,fixed by matglas86. Error in block configure.
Matthias Glastra [Sun, 16 Oct 2011 21:22:31 +0000]
Fix for #1308970 reported by vasike,fixed by matglas86. Error in block configure.

There was a bug introduced when adding the different displays through formatters
this bug was not noticed but reported by vasike in issue #1308970.

2 years agoFix for not ready with loading the widget.js.
Matthias Glastra [Thu, 13 Oct 2011 07:26:13 +0000]
Fix for not ready with loading the widget.js.

Because widget.js was not loaded when we did addthis.init(), the js
was broken for the page.

2 years agoAdded async loading of AddThis resources.
Matthias Glastra [Thu, 13 Oct 2011 07:16:36 +0000]
Added async loading of AddThis resources.

2 years agoAdded support for async loading of AddThis.
Matthias Glastra [Thu, 13 Oct 2011 07:05:57 +0000]
Added support for async loading of AddThis.

2 years agoIssue #1305236 by sjhuda: Fixed wrong path to config page in module info.
Matthias Glastra [Tue, 11 Oct 2011 06:36:35 +0000]
Issue #1305236 by sjhuda: Fixed wrong path to config page in module info.

2 years agoIssue #1305236 by sjhuda: Fixed wrong path to config page in module info.
Matthias Glastra [Tue, 11 Oct 2011 06:36:35 +0000]
Issue #1305236 by sjhuda: Fixed wrong path to config page in module info.

2 years agoMoved the config page to the User Interface section.
Matthias Glastra [Sat, 8 Oct 2011 10:14:28 +0000]
Moved the config page to the User Interface section.

2 years agoMoved the config page to the User Interface section.
Matthias Glastra [Sat, 8 Oct 2011 09:59:26 +0000]
Moved the config page to the User Interface section.

2 years agoMerge branch 'master' of git.drupal.org:project/addthis into my-master
Matthias Glastra [Fri, 7 Oct 2011 08:03:17 +0000]
Merge branch 'master' of git.drupal.org:project/addthis into my-master

2 years agoCreated the first seperate Basic Display.
Matthias Glastra [Fri, 7 Oct 2011 07:57:40 +0000]
Created the first seperate Basic Display.

The Basic Toolbox display is now working in a raw form. It should be
polished by the community.

2 years agoUpdated maintainer information.
Jani Palsamäki [Thu, 6 Oct 2011 11:36:09 +0000]
Updated maintainer information.

2 years agoMerged fix from 'master'.
Matthias Glastra [Fri, 30 Sep 2011 14:09:07 +0000]
Merged fix from 'master'.

2 years agoFixed issue #1282126 for not displaying AddThis on pre-existing content.
Matthias Glastra [Fri, 30 Sep 2011 13:53:02 +0000]
Fixed issue #1282126 for not displaying AddThis on pre-existing content.

Content that was already in the system and a AddThis field was added later
it would not show the AddThis display.

2 years agoMerge branch 'nullfield' into my-master
Matthias Glastra [Fri, 30 Sep 2011 13:53:02 +0000]
Merge branch 'nullfield' into my-master

2 years agoImplemented the hook_field_prepare_view.
Matthias Glastra [Thu, 29 Sep 2011 15:02:40 +0000]
Implemented the hook_field_prepare_view.

This hook makes sure we add a value to the addthis field when there is no
value. We need this value to make sure we are able to render something.

2 years agoMerge branch 'theming' into my-dev-4.x
Matthias Glastra [Thu, 29 Sep 2011 08:50:12 +0000]
Merge branch 'theming' into my-dev-4.x

2 years agoAnother typo
Matthias Glastra [Thu, 29 Sep 2011 07:18:12 +0000]
Another typo

2 years agoUpdated some coding style typos.
Matthias Glastra [Thu, 29 Sep 2011 07:15:07 +0000]
Updated some coding style typos.

2 years agoFix for class AddThis class loading. http://drupal.org/node/628486#comment-4987614
Matthias Glastra [Wed, 28 Sep 2011 14:30:31 +0000]
Fix for class AddThis class loading. drupal.org/node/628486#comment-4987614

Some how when installing you cant uninstall the module and keep everything running. What happens
is that the install file is loaded and gives a error. It want to load hook_field_schema and
references the AddThis class. There fore we do a include_once for the class in AddThis.php.

2 years agoMerge branch 'dop-master' into theming
Matthias Glastra [Wed, 28 Sep 2011 14:01:48 +0000]
Merge branch 'dop-master' into theming

2 years agoFix issue 628486 comment #24. Problem with loading AddThis class in install file...
Matthias Glastra [Wed, 28 Sep 2011 13:53:27 +0000]
Fix issue 628486 comment #24. Problem with loading AddThis class in install file when uninstalled.

http://drupal.org/node/628486#comment-4987614

2 years agoThe rendering is refactored completely.
Matthias Glastra [Wed, 21 Sep 2011 18:38:13 +0000]
The rendering is refactored completely.

The markup is now create through a seperate hook function. This is more
dynamic and creates the possiblity to add the theme function better.

Todo: we need to test settings for a formatter and add a field instance to
the block. Settings need to be generic and also be able to be set on the
theme function.

2 years agoAdded field formatter filter based on type.
Matthias Glastra [Tue, 20 Sep 2011 15:59:34 +0000]
Added field formatter filter based on type.

2 years agoChanged some thing functions
Matthias Glastra [Mon, 19 Sep 2011 15:56:41 +0000]
Changed some thing functions

My initial ideas about drupal was working where not right. Drupal
does create nice class attributes for tags based on a array. And I
split the wrapper element and the simple element.

2 years agoAdded configure setting to addthis.info to enable Configure-link on modules page.
paulihuhtiniemi [Fri, 9 Sep 2011 09:47:45 +0000]
Added configure setting to addthis.info to enable Configure-link on modules page.

2 years agoChanged the addthis:title attribute value generation to use site name instead of...
Jani Palsamäki [Fri, 9 Sep 2011 09:02:34 +0000]
Changed the addthis:title attribute value generation to use site name instead of drupal_get_title(), as the latter does not include the site name.

2 years agoAdded a description to Facebook settings fieldset to make users aware of the required...
Jani Palsamäki [Fri, 9 Sep 2011 07:27:28 +0000]
Added a description to Facebook settings fieldset to make users aware of the required Open Graph meta tags.

2 years agoRemoved redundant classes. Also removed author information, as there will probably...
Jani Palsamäki [Fri, 9 Sep 2011 06:12:23 +0000]
Removed redundant classes. Also removed author information, as there will probably be multiple contributors and keeping this up to date is not a top priority.

2 years agoMerged code contributed by Matthias Glastra. Instead of re-inventing the wheel when...
matglas86 [Fri, 9 Sep 2011 05:42:33 +0000]
Merged code contributed by Matthias Glastra. Instead of re-inventing the wheel when generating AddThis configuration options, let's just use drupal_encode_json.

2 years agoMerged code contributed by Matthias Glastra. The output is now rendered via Render...
Jani Palsamäki [Thu, 8 Sep 2011 09:56:01 +0000]
Merged code contributed by Matthias Glastra. The output is now rendered via Render API.

2 years agoMinor refactoring: Using drupal_json_decode instead of json_decode.
Jani Palsamäki [Thu, 8 Sep 2011 09:19:59 +0000]
Minor refactoring: Using drupal_json_decode instead of json_decode.

2 years agoCommitting contributed code by Matthias Glastra: Mostly coding conventions related...
Jani Palsamäki [Thu, 1 Sep 2011 09:25:40 +0000]
Committing contributed code by Matthias Glastra: Mostly coding conventions related modifications and renaming to prevent possible name collisions.

2 years agoAdded a preliminary support for Google +1 toolbox button.
Jani Palsamäki [Thu, 1 Sep 2011 08:14:06 +0000]
Added a preliminary support for Google +1 toolbox button.

2 years agoAdded a preliminary support for Twitter toolbox button.
Jani Palsamäki [Thu, 1 Sep 2011 07:59:31 +0000]
Added a preliminary support for Twitter toolbox button.

2 years agoAdded a preliminary support for Facebook Like button. TODO: Add configuration options.
Jani Palsamäki [Thu, 1 Sep 2011 07:44:15 +0000]
Added a preliminary support for Facebook Like button. TODO: Add configuration options.

2 years agoDisplaying a warning message when AddThis services json URL can not be accessed.
Jani Palsamäki [Thu, 1 Sep 2011 05:53:24 +0000]
Displaying a warning message when AddThis services json URL can not be accessed.

2 years ago- Added configurable settings: ui_click, ui_delay, ui_open_windows, ui_use_css
Jani Palsamäki [Thu, 1 Sep 2011 05:32:07 +0000]
- Added configurable settings: ui_click, ui_delay, ui_open_windows, ui_use_css
- Minor updates to README.txt

2 years agoFixed AddThis javascript configuration settings generation for boolean values. Previo...
Jani Palsamäki [Wed, 31 Aug 2011 09:23:28 +0000]
Fixed AddThis javascript configuration settings generation for boolean values. Previously the result was like: value: '1', now the result is correctly like this: value: true

2 years agoModified AddThis configuration setting generation to play better with or without...
Jani Palsamäki [Tue, 30 Aug 2011 11:01:21 +0000]
Modified AddThis configuration setting generation to play better with or without trailing commas.

2 years ago- Using field formatters to select the sharing widget type in the UI (contributed...
Jani Palsamäki [Tue, 30 Aug 2011 08:23:58 +0000]
- Using field formatters to select the sharing widget type in the UI (contributed by Matthias Glastra, matglas86, drupal.org/user/573464)

- Decided not to use instance level settings as having one type of sharing widget per entity instance type is more logical in most cases
  - There might be some special cases where you actually need to have a different type of widget for entities of the same type, but currently we try to keep this as simple as possible

2 years agoAdded a configuration setting for email addressbook integration.
Jani Palsamäki [Tue, 30 Aug 2011 06:30:05 +0000]
Added a configuration setting for email addressbook integration.

2 years agoRenamed configuration setting for clickback tracking.
Jani Palsamäki [Tue, 30 Aug 2011 06:13:09 +0000]
Renamed configuration setting for clickback tracking.

2 years agoAdded a configuration setting for clickback tracking.
Jani Palsamäki [Tue, 30 Aug 2011 05:59:25 +0000]
Added a configuration setting for clickback tracking.

2 years agoAdded a configuration setting for 508 compliance.
Jani Palsamäki [Tue, 30 Aug 2011 05:47:13 +0000]
Added a configuration setting for 508 compliance.

2 years agoMoved AddThis configuration generation to a separate class. Replaced some NULL-checks...
Jani Palsamäki [Mon, 29 Aug 2011 12:11:26 +0000]
Moved AddThis configuration generation to a separate class. Replaced some NULL-checks with empty-call where appropriate. Enabled co-brand message configuration.

2 years agoAdded configurable co-brand message. TODO: Add the javascript configuration for this.
Jani Palsamäki [Fri, 26 Aug 2011 12:16:01 +0000]
Added configurable co-brand message. TODO: Add the javascript configuration for this.

2 years agoFixed erroneous description text (custom configuration code description).
Jani Palsamäki [Fri, 26 Aug 2011 12:08:31 +0000]
Fixed erroneous description text (custom configuration code description).

2 years agoAdding addthis_widget.js only once per page (footer).
Jani Palsamäki [Fri, 26 Aug 2011 11:56:36 +0000]
Adding addthis_widget.js only once per page (footer).

2 years agoMade number of preferred services configurable (toolbox specific setting).
Jani Palsamäki [Fri, 26 Aug 2011 07:48:23 +0000]
Made number of preferred services configurable (toolbox specific setting).

2 years agoSimplified toolbox markup generation by using addthis attribute inheritance.
Jani Palsamäki [Fri, 26 Aug 2011 07:17:10 +0000]
Simplified toolbox markup generation by using addthis attribute inheritance.

2 years agoMinor refactoring. Added type-hinting. Removed unnecessary UI field descriptions...
Jani Palsamäki [Mon, 22 Aug 2011 09:55:07 +0000]
Minor refactoring. Added type-hinting. Removed unnecessary UI field descriptions. Removed unnecessary methods. Using large toolbox icons as default.

2 years agoDisabling addthis_button_facebook_like-class for the moment.
Jani Palsamäki [Thu, 11 Aug 2011 04:31:55 +0000]
Disabling addthis_button_facebook_like-class for the moment.

2 years agoAdded addthis_button_facebook_like-class to toolbox.
Jani Palsamäki [Wed, 10 Aug 2011 12:32:29 +0000]
Added addthis_button_facebook_like-class to toolbox.

2 years agoRemoved the "Share" text and separator when generating toolbox.
Jani Palsamäki [Tue, 9 Aug 2011 07:18:01 +0000]
Removed the "Share" text and separator when generating toolbox.

2 years agoAdded Json and MarkupGenerator as dependencies in AddThis-class.
Jani Palsamäki [Wed, 6 Jul 2011 06:31:40 +0000]
Added Json and MarkupGenerator as dependencies in AddThis-class.

2 years agoUsing singleton instance of AddThis instead of static methods.
Jani Palsamäki [Wed, 6 Jul 2011 06:08:37 +0000]
Using singleton instance of AddThis instead of static methods.

2 years agoFixed class not found installation error.
Jani Palsamäki [Wed, 6 Jul 2011 05:33:31 +0000]
Fixed class not found installation error.

2 years agoChanged some string literals to constants to reduce duplicate literals.
Jani Palsamäki [Wed, 6 Jul 2011 04:31:26 +0000]
Changed some string literals to constants to reduce duplicate literals.

2 years agoRemoved hook_field_instance_settings_form, as we do not want to add anything extra...
Jani Palsamäki [Tue, 5 Jul 2011 12:19:37 +0000]
Removed hook_field_instance_settings_form, as we do not want to add anything extra to the instance settings form.

2 years agoChanged field level settings ('addthis_style') to an instance level setting.
Jani Palsamäki [Tue, 5 Jul 2011 11:09:02 +0000]
Changed field level settings ('addthis_style') to an instance level setting.

2 years agoRefactoring: Moved field hooks and block hooks to separate include files. Created...
Jani Palsamäki [Tue, 5 Jul 2011 09:29:06 +0000]
Refactoring: Moved field hooks and block hooks to separate include files. Created a subfolder for all include files.

2 years agoRemoved a cardinality setting.
Jani Palsamäki [Mon, 4 Jul 2011 09:23:34 +0000]
Removed a cardinality setting.

2 years agoMinor label fix.
Jani Palsamäki [Mon, 4 Jul 2011 08:55:02 +0000]
Minor label fix.

2 years agoMinor renaming.
Jani Palsamäki [Fri, 1 Jul 2011 07:53:32 +0000]
Minor renaming.

2 years agoRolled back translatable-setting.
Jani Palsamäki [Fri, 1 Jul 2011 06:31:54 +0000]
Rolled back translatable-setting.

2 years agoTesting translatable-setting.
Jani Palsamäki [Thu, 30 Jun 2011 11:13:39 +0000]
Testing translatable-setting.

2 years agoAdded tests for enabling and saving AddThis custom configuration code.
Jani Palsamäki [Wed, 29 Jun 2011 12:05:24 +0000]
Added tests for enabling and saving AddThis custom configuration code.

2 years agoA user may input custom AddThis configuration code in format described at www.addthis...
Jani Palsamäki [Wed, 29 Jun 2011 11:48:53 +0000]
A user may input custom AddThis configuration code in format described at addthis.com.

2 years agoMinor cleanup.
Jani Palsamäki [Wed, 29 Jun 2011 10:39:10 +0000]
Minor cleanup.

2 years agoAdded some check_plain() and check_url() -calls.
Jani Palsamäki [Wed, 29 Jun 2011 09:55:24 +0000]
Added some check_plain() and check_url() -calls.

2 years agoMade AddThis widget header text and background colors configurable.
Jani Palsamäki [Wed, 29 Jun 2011 09:11:24 +0000]
Made AddThis widget header text and background colors configurable.

2 years agoAdded some field sets to admin page to make the page shorter and perhaps more usable.
Jani Palsamäki [Wed, 29 Jun 2011 07:50:16 +0000]
Added some field sets to admin page to make the page shorter and perhaps more usable.

2 years agoMade AddThis large toolbox icons configurable.
Jani Palsamäki [Wed, 29 Jun 2011 07:08:59 +0000]
Made AddThis large toolbox icons configurable.

2 years agoMade AddThis css and javascript URLs configurable.
Jani Palsamäki [Wed, 29 Jun 2011 06:16:25 +0000]
Made AddThis css and javascript URLs configurable.

2 years agoSome cleanup, commenting and refactoring.
Jani Palsamäki [Wed, 29 Jun 2011 05:50:24 +0000]
Some cleanup, commenting and refactoring.

2 years agoRemoved some legacy hook implementations that were not doing anything useful. Let...
Jani Palsamäki [Wed, 29 Jun 2011 04:01:41 +0000]
Removed some legacy hook implementations that were not doing anything useful. Let's implement these only when required.

2 years agoMade AddThis bookmark URL and services json URL required.
Jani Palsamäki [Thu, 23 Jun 2011 12:09:04 +0000]
Made AddThis bookmark URL and services json URL required.