project/coder.git
2 years agoCheck for Grammar Parser installed as a module and wrong version of Libraries API.
solotandem [Wed, 11 May 2011 14:41:24 +0000]
Check for Grammar Parser installed as a module and wrong version of Libraries API.

2 years agoReanable use of separate process (with parser in libraries directory).
solotandem [Mon, 9 May 2011 18:48:26 +0000]
Reanable use of separate process (with parser in libraries directory).

2 years agoLoad parser from new library location.
solotandem [Fri, 6 May 2011 17:07:25 +0000]
Load parser from new library location.

2 years agoReplace dependency on Grammar Parser with Grammar Parser Library and Libraries modules.
solotandem [Tue, 3 May 2011 00:10:58 +0000]
Replace dependency on Grammar Parser with Grammar Parser Library and Libraries modules.

3 years agoInclude files needed for install (missed after renaming files and moving content).
solotandem [Thu, 21 Apr 2011 07:12:16 +0000]
Include files needed for install (missed after renaming files and moving content).

3 years agoMove routines to new or more appropriate files; revise @file comments; correct typos...
solotandem [Sat, 16 Apr 2011 19:39:07 +0000]
Move routines to new or more appropriate files; revise @file comments; correct typos; delete blank line at top of each file.

3 years agoIssue #1115802: correct syntax errors caused by input file; still leaves dangling...
solotandem [Sat, 16 Apr 2011 19:32:56 +0000]
Issue #1115802: correct syntax errors caused by input file; still leaves dangling else block.

3 years agoRename files; correct typos; modify help text; update copyright; move coder_upgrade_p...
solotandem [Fri, 15 Apr 2011 22:33:20 +0000]
Rename files; correct typos; modify help text; update copyright; move coder_upgrade_path(); eliminate include.

3 years agoRename files; correct typos; modify help text; update copyright; move coder_upgrade_p...
solotandem [Fri, 15 Apr 2011 22:29:23 +0000]
Rename files; correct typos; modify help text; update copyright; move coder_upgrade_path(); eliminate include.

3 years agoChange default value of 'coder_upgrade_use_separate_process' to FALSE.
solotandem [Fri, 1 Apr 2011 00:17:12 +0000]
Change default value of 'coder_upgrade_use_separate_process' to FALSE.

3 years agoModify hook_upgrade_info() to allow multiple upgrade sets per module.
solotandem [Fri, 1 Apr 2011 00:08:23 +0000]
Modify hook_upgrade_info() to allow multiple upgrade sets per module.

3 years agoOpen log and patch files in new window.
solotandem [Fri, 1 Apr 2011 00:04:31 +0000]
Open log and patch files in new window.

3 years agoRemove unnecessary include file.
solotandem [Fri, 1 Apr 2011 00:02:46 +0000]
Remove unnecessary include file.

3 years agoFix indention.
solotandem [Tue, 29 Mar 2011 23:48:11 +0000]
Fix indention.

3 years agoReplace calls to is_a() by instanceof operator.
solotandem [Tue, 29 Mar 2011 23:46:48 +0000]
Replace calls to is_a() by instanceof operator.

3 years agoIssue #1008256, #224333#registry: The files listed in an info file should only includ...
solotandem [Sun, 27 Mar 2011 04:58:58 +0000]
Issue #1008256, #224333#registry: The files listed in an info file should only include those that declare a class (or interface).

3 years agofixed #cache warnings
Stella Power [Sat, 12 Mar 2011 11:56:28 +0000]
fixed #cache warnings

3 years agomerged in additional reviews
Stella Power [Fri, 11 Mar 2011 18:45:23 +0000]
merged in additional reviews

3 years ago#990940 - $Id rule inverted
Stella Power [Fri, 11 Mar 2011 16:48:16 +0000]
#990940 - $Id rule inverted

3 years agofixed ignores warnings
Stella Power [Fri, 11 Mar 2011 16:30:40 +0000]
fixed ignores warnings

3 years agofixed security tests
Stella Power [Fri, 11 Mar 2011 16:19:54 +0000]
fixed security tests

3 years agoFixed comment tests
Stella Power [Fri, 11 Mar 2011 16:00:55 +0000]
Fixed comment tests

3 years agoremoved $Id line
Stella Power [Fri, 11 Mar 2011 16:00:17 +0000]
removed $Id line

3 years agoby douggreen - fix for unit tests failing
Stella Power [Fri, 11 Mar 2011 12:36:38 +0000]
by douggreen - fix for unit tests failing

3 years agofixed #cache logic
Stella Power [Mon, 7 Mar 2011 16:36:12 +0000]
fixed #cache logic

3 years agoallow modules to alter the coder args and implement a hook to run before results...
Stella Power [Mon, 7 Mar 2011 16:32:26 +0000]
allow modules to alter the coder args and implement a hook to run before results are displayed

3 years agoStripping CVS keywords
The Great Git Migration [Fri, 25 Feb 2011 02:07:17 +0000]
Stripping CVS keywords

3 years ago#859314: minor cleanup to conform to Drupal coding standards.
Jim Berry [Mon, 31 Jan 2011 14:59:27 +0000]
#859314: minor cleanup to conform to Drupal coding standards.

3 years agocoder_upgrade.end.inc: ignore all hidden directories and exclude template files.
Jim Berry [Sun, 30 Jan 2011 00:01:55 +0000]
coder_upgrade.end.inc: ignore all hidden directories and exclude template files.

3 years ago#859314: rename global variables according to Drupal coding standards.
Jim Berry [Sat, 29 Jan 2011 23:49:11 +0000]
#859314: rename global variables according to Drupal coding standards.

3 years agocoder_upgrade.module: #1010762 by Placinta: fix inconsistent return value in coder_up...
Jim Berry [Thu, 30 Dec 2010 17:24:57 +0000]
coder_upgrade.module: #1010762 by Placinta: fix inconsistent return value in coder_upgrade_conversions_apply().

3 years agofix for review_name undefined warnings
Stella Power [Mon, 6 Dec 2010 22:50:59 +0000]
fix for review_name undefined warnings

3 years agoadded in latest links
Stella Power [Sun, 5 Dec 2010 23:42:58 +0000]
added in latest links

3 years agoAdded in core=7.x check
Stella Power [Sun, 5 Dec 2010 20:59:39 +0000]
Added in core=7.x check

3 years agostub file
Stella Power [Sun, 5 Dec 2010 20:40:04 +0000]
stub file

3 years agoAdded in doxygen comment review for .install files.
Stella Power [Sun, 5 Dec 2010 20:39:31 +0000]
Added in doxygen comment review for .install files.

3 years agoupdated log with coding style fixes
Stella Power [Sun, 5 Dec 2010 18:55:04 +0000]
updated log with coding style fixes

3 years agocoding style changes
Stella Power [Sun, 5 Dec 2010 18:52:15 +0000]
coding style changes

3 years ago#859314 by duellj - coding style fixes
Stella Power [Sun, 5 Dec 2010 17:58:30 +0000]
#859314 by duellj - coding style fixes

3 years ago#906200 by drupal-id.com - moved code below @file comment
Stella Power [Sun, 5 Dec 2010 17:15:41 +0000]
#906200 by drupal-id.com - moved code below @file comment

3 years ago#589038 - drupal_set_session() change was reverted. Updated the warning and set
Stella Power [Sun, 5 Dec 2010 17:02:29 +0000]
#589038 - drupal_set_session() change was reverted. Updated the warning and set
it to minor

3 years ago#912490 by arithmetric - fix for api theme calls called incorrectly
Stella Power [Sun, 5 Dec 2010 16:35:57 +0000]
#912490 by arithmetric - fix for api theme calls called incorrectly

3 years ago#704032 by fgm - fix for module_implements vs module_list incorrect warnings
Stella Power [Sun, 5 Dec 2010 16:10:40 +0000]
#704032 by fgm - fix for module_implements vs module_list incorrect warnings

3 years agovarious files: replace calls to pgp_log_memory_use() with coder_upgrade_memory_print... 7.x-1.0-beta6
Jim Berry [Sat, 4 Dec 2010 21:24:20 +0000]
various files: replace calls to pgp_log_memory_use() with coder_upgrade_memory_print(); coder_upgrade.module: #982380: correct coder_upgrade_parameters_save() to use module directory instead of files directory, enhance coder_upgrade_conversions_apply() to capture errors and return code; coder_upgrade.main.inc: refactor print routines to use coder_upgrade_path_print(); coder_upgrade.run.php: enhance documentation; coder_upgrade.test: refactor getInfo() routines; tests/samples directory: update the input and expected test file: example.module.

3 years ago#976940: eliminate php warnings related to files not present: core.coder_review_ignor... 7.x-1.0-beta5
Jim Berry [Fri, 19 Nov 2010 20:02:19 +0000]
#976940: eliminate php warnings related to files not present: core.coder_review_ignores.txt and info file.

3 years agocoder_upgrade.main.inc: #245471 (comment #7): remove base directory path from patch...
Jim Berry [Fri, 19 Nov 2010 18:19:55 +0000]
coder_upgrade.main.inc: #245471 (comment #7): remove base directory path from patch file in coder_upgrade_make_patch_file(); inc, install, help.inc, main.inc, module, test: refactor file_directory_path() references to coder_upgrade_directory_path(); coder_upgrade.run.php: add php memory and time limits.

3 years ago#954256 by superbaloo - fix for paths of files within the ignore file
Stella Power [Sun, 31 Oct 2010 09:52:27 +0000]
#954256 by superbaloo - fix for paths of files within the ignore file

3 years agochanged some help text
Stella Power [Sun, 31 Oct 2010 09:42:47 +0000]
changed some help text

3 years agofixed path to core.coder_review_ignores.txt
Stella Power [Sun, 31 Oct 2010 09:40:09 +0000]
fixed path to core.coder_review_ignores.txt

3 years ago#948124 by boombatower - added in ability to review individual files
Stella Power [Sun, 31 Oct 2010 09:36:57 +0000]
#948124 by boombatower - added in ability to review individual files

3 years agochanged some drupal_set_message() messages to be errors
Stella Power [Sun, 31 Oct 2010 09:22:07 +0000]
changed some drupal_set_message() messages to be errors

3 years ago#946978 by boombatower - added severity name to drush output
Stella Power [Sun, 31 Oct 2010 09:20:24 +0000]
#946978 by boombatower - added severity name to drush output

3 years agoFix missing required code file for install.
Jim Berry [Sun, 31 Oct 2010 04:52:58 +0000]
Fix missing required code file for install.

3 years agocoder_upgrade.install: fix call requiring a variable to be passed by reference.
Jim Berry [Sun, 31 Oct 2010 03:37:39 +0000]
coder_upgrade.install: fix call requiring a variable to be passed by reference.

3 years agoFile missed in previous commit.
Jim Berry [Sat, 30 Oct 2010 15:54:32 +0000]
File missed in previous commit.

3 years agocoder_upgrade.module: refactor form submission code to coder_upgrade_conversions_apply().
Jim Berry [Sat, 30 Oct 2010 15:53:13 +0000]
coder_upgrade.module: refactor form submission code to coder_upgrade_conversions_apply().

3 years agoAnother file missed in previous commit.
Jim Berry [Fri, 29 Oct 2010 22:37:29 +0000]
Another file missed in previous commit.

3 years agoFile missed in previous commit.
Jim Berry [Fri, 29 Oct 2010 22:23:12 +0000]
File missed in previous commit.

3 years agocoder_upgrade.inc, coder_upgrade.install, coder_upgrade.module, coder_upgrade.main...
Jim Berry [Fri, 29 Oct 2010 22:21:27 +0000]
coder_upgrade.inc, coder_upgrade.install, coder_upgrade.module, coder_upgrade.main.inc: refactor code to allow execution from a separate process outside of Drupal; coder_upgrade.begin.inc: cache the core theme information in the persistent cache (includes disabled modules).

3 years agocoder_upgrade.db.inc: enhance error handling by checking for conditions not being...
Jim Berry [Mon, 25 Oct 2010 20:23:14 +0000]
coder_upgrade.db.inc: enhance error handling by checking for conditions not being found in a select query; coder_upgrade.call.inc, coder_upgrade.function.inc: enhance #theme_changes to check number of parameters to theme_xxx() and hook_theme entry; coder_upgrade.function.inc: enhance #theme_changes when setting theme key to 'render element' also change value from an associative array to a string.

3 years agofixed some theme warnings
Stella Power [Tue, 14 Sep 2010 22:21:59 +0000]
fixed some theme warnings

3 years agofixed more undefined index warnings
Stella Power [Tue, 14 Sep 2010 22:15:03 +0000]
fixed more undefined index warnings

3 years agofixed some warnings
Stella Power [Tue, 14 Sep 2010 22:01:29 +0000]
fixed some warnings

3 years agocoder_upgrade.install: hook_uninstall(): delete recently added settings variables...
Jim Berry [Fri, 10 Sep 2010 00:35:40 +0000]
coder_upgrade.install: hook_uninstall(): delete recently added settings variables, hook_requirements(): use get_t().

3 years agocoder_upgrade.function.inc: refactor #hook_permission to hook_upgrade_hook_perm_alter...
Jim Berry [Wed, 8 Sep 2010 22:36:46 +0000]
coder_upgrade.function.inc: refactor #hook_permission to hook_upgrade_hook_perm_alter(), refactor #descriptions_permissions to use the convert_return() pattern (use cases 1 and 2), refactor doc_comment checking in coder_upgrade_convert_update_N() to revert to that in hook_upgrade_hook_alter(); tests/samples directory: update the input and expected test file: example.module.

3 years agocoder_upgrade.inc: define file_directory_path() in response to its removal from core...
Jim Berry [Thu, 2 Sep 2010 22:08:52 +0000]
coder_upgrade.inc: define file_directory_path() in response to its removal from core; coder_upgrade.db.inc, coder_upgrade.function.inc: coding style fixes.

3 years ago#895708 - fix for broken function names
Stella Power [Sat, 28 Aug 2010 16:06:12 +0000]
#895708 - fix for broken function names

3 years agocoder_upgrade.function.inc: enhance #hook_filter_info (including a missed parser...
Jim Berry [Fri, 27 Aug 2010 19:24:19 +0000]
coder_upgrade.function.inc: enhance #hook_filter_info (including a missed parser API change that broke the entire routine), #install-schema, #hook-user-changes, #hook_load_signature, and #theme_changes.

3 years agostrengthened db_rewrite_sql rule
Stella Power [Fri, 20 Aug 2010 09:41:19 +0000]
strengthened db_rewrite_sql rule

3 years agotweaked db_rewrite_sql() rule
Stella Power [Thu, 19 Aug 2010 21:22:27 +0000]
tweaked db_rewrite_sql() rule

3 years agofixed errors
Stella Power [Thu, 19 Aug 2010 20:08:57 +0000]
fixed errors

3 years agoFAPI reviews
Stella Power [Thu, 19 Aug 2010 19:01:34 +0000]
FAPI reviews

3 years agocoder_upgrade.module: improve the menu integration when only Coder Upgrade is enabled...
Jim Berry [Wed, 18 Aug 2010 01:46:36 +0000]
coder_upgrade.module: improve the menu integration when only Coder Upgrade is enabled, only allow the base files directory to be renamed, enable the submit handler for the settings form; coder_upgrade.main.inc: refactor the coder_upgrade_xxx_path() routines to reflect the coder_upgrade_dir variable.

3 years agohardened a rule
Stella Power [Tue, 17 Aug 2010 21:32:47 +0000]
hardened a rule

3 years agochecks for fapi #title and #description
Stella Power [Tue, 17 Aug 2010 21:21:50 +0000]
checks for fapi #title and #description

3 years agochecks on hook_block() title
Stella Power [Mon, 16 Aug 2010 20:56:23 +0000]
checks on hook_block() title

3 years agoadded in links to docs
Stella Power [Mon, 16 Aug 2010 20:44:09 +0000]
added in links to docs

3 years agocheck for form tags
Stella Power [Mon, 16 Aug 2010 20:16:43 +0000]
check for form tags

3 years agoadded in checks for eval() and drupal_eval()
Stella Power [Mon, 16 Aug 2010 19:43:25 +0000]
added in checks for eval() and drupal_eval()

3 years agoadded in $_POST check
Stella Power [Mon, 16 Aug 2010 16:30:23 +0000]
added in $_POST check

3 years agogeneric php.net url
Stella Power [Sun, 15 Aug 2010 22:27:59 +0000]
generic php.net url

3 years agofixed parsing error for blank lines in ignores file
Stella Power [Sun, 15 Aug 2010 22:27:16 +0000]
fixed parsing error for blank lines in ignores file

3 years agoadded filter_xss() to list of sanitizing functions
Stella Power [Sun, 15 Aug 2010 16:27:31 +0000]
added filter_xss() to list of sanitizing functions

3 years agoadditional security reviews for trigger_error(), form_set_error(), form_error()
Stella Power [Sun, 15 Aug 2010 13:45:52 +0000]
additional security reviews for trigger_error(), form_set_error(), form_error()
and confirm_form()

3 years agoupdated _coder_modified() check
Stella Power [Sat, 14 Aug 2010 14:08:42 +0000]
updated _coder_modified() check

3 years agostrengthened some rules to reduce false positives
Stella Power [Sat, 14 Aug 2010 14:08:13 +0000]
strengthened some rules to reduce false positives

3 years agomodified REQUEST_URI rule so it doesn't check within the request_uri() function
Stella Power [Sat, 14 Aug 2010 12:50:37 +0000]
modified REQUEST_URI rule so it doesn't check within the request_uri() function
itself.

3 years agoMissed in previous commit.
Jim Berry [Fri, 13 Aug 2010 14:00:06 +0000]
Missed in previous commit.

3 years agocoder_upgrade.db.inc: enhance coder_upgrade_insert_dbtng_statement() to properly...
Jim Berry [Fri, 13 Aug 2010 13:54:39 +0000]
coder_upgrade.db.inc: enhance coder_upgrade_insert_dbtng_statement() to properly insert statements; coder_upgrade.function.inc: enhance coder_upgrade_op_to_hook() to not use clone and to allow for more than one case statement with no body; tests/samples directory: update the input and expected test file: example.module.

3 years ago#881690 by duellj - fix for typo
Stella Power [Thu, 12 Aug 2010 21:12:46 +0000]
#881690 by duellj - fix for typo

3 years agocoder_upgrade.call.inc:#878470: enhance #drupal_set_header_renamed to handle no param...
Jim Berry [Thu, 12 Aug 2010 01:05:28 +0000]
coder_upgrade.call.inc:#878470: enhance #drupal_set_header_renamed to handle no parameters; coder_upgrade.function.inc: enhance #hook_load_signature to clean the parameter variable; coder_upgrade.list.inc: add routine entry for grammar parser; coder_upgrade.main.inc, coder_upgrade.module: implement settings for preserving array format and debug output by coder upgrade and grammar parser.

3 years ago#311259 - added in ability to disable warnings by rule set (security, style,
Stella Power [Wed, 11 Aug 2010 21:44:53 +0000]
#311259 - added in ability to disable warnings by rule set (security, style,
etc) per line.  See core.coder_review_ignores.txt for an example - just replace 'core'
with your module name.

3 years agostrengthened the db_rewrite_sql() and drupal_set_title/message() tests to reduce
Stella Power [Wed, 11 Aug 2010 10:16:19 +0000]
strengthened the db_rewrite_sql() and drupal_set_title/message() tests to reduce
false positives - added in multi-line review functionality, forward and back.

3 years ago#328362 - strengthened the checks by adding in multi-line reviews to ensure $var
Stella Power [Mon, 9 Aug 2010 18:18:12 +0000]
#328362 - strengthened the checks by adding in multi-line reviews to ensure $var
isn't sanitized on previous lines in the same function, should reduce false
positives.

3 years ago#319489 - added in link
Stella Power [Mon, 9 Aug 2010 14:27:45 +0000]
#319489 - added in link

3 years ago#319489 by stella - changed priority level of l() already contains check_plain()
Stella Power [Mon, 9 Aug 2010 14:26:51 +0000]
#319489 by stella - changed priority level of l() already contains check_plain()

3 years ago#328362 by greggles, stella
Stella Power [Sun, 8 Aug 2010 20:21:44 +0000]
#328362 by greggles, stella
#318763 by john morahan, stella
#752734 by john morahan, stella
#301552 by douggreen, stella

3 years agocoder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax; coder_upgra...
Jim Berry [Fri, 30 Jul 2010 00:13:40 +0000]
coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax; coder_upgrade.begin.inc: refactor call to coder_upgrade_convert_return() and associated callback; coder_upgrade.function.inc: enhance coder_upgrade_convert_op() to use new getParameterVariable() API function, refactor the convert return pattern of routines: coder_upgrade_convert_return(), coder_upgrade_convert_return_loop(), and coder_upgrade_callback_return_caseN(); tests/samples directory: update the input and expected test file: example.module.

3 years agocoder_review_7x.inc: #704018 by jhodgdon - spelling/grammar error.
Jim Berry [Thu, 22 Jul 2010 23:31:42 +0000]
coder_review_7x.inc: #704018 by jhodgdon - spelling/grammar error.

3 years agocoder_upgrade.api.php: update documentation to reflect the node being returned by... 7.x-1.0-beta4
Jim Berry [Mon, 12 Jul 2010 22:33:06 +0000]
coder_upgrade.api.php: update documentation to reflect the node being returned by getFunctionCalls(); coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax.