5 years ago#319339 by drewish, Don't keep rescanning files if they don't have a filefield_meta...
andrew morton [Fri, 10 Oct 2008 01:03:09 +0000]
#319339 by drewish, Don't keep rescanning files if they don't have a filefield_meta record.

5 years ago#318993 by stella, Patch for problems found in code review.
andrew morton [Fri, 10 Oct 2008 00:59:10 +0000]
#318993 by stella, Patch for problems found in code review.

5 years ago#295620 Fix includes to avoid "Call to undefined function field_file_load()"
andrew morton [Thu, 9 Oct 2008 22:13:26 +0000]
#295620 Fix includes to avoid "Call to undefined function field_file_load()"

5 years ago#318694 by drewish, Add CCK D5 upgrade compatibility check.
andrew morton [Wed, 8 Oct 2008 20:19:37 +0000]
#318694 by drewish, Add CCK D5 upgrade compatibility check.

5 years ago#313561 by andreas-emer, German Translation for Version 6.x-3.0-alpha4.
andrew morton [Wed, 8 Oct 2008 01:46:15 +0000]
#313561 by andreas-emer, German Translation for Version 6.x-3.0-alpha4.

5 years ago#305476 by drewish, Incorrect #options keys in filefield_field_settings_form().
andrew morton [Mon, 15 Sep 2008 20:59:10 +0000]
#305476 by drewish, Incorrect #options keys in filefield_field_settings_form().

5 years ago#308832 by pwolanin, Wrong datatype for second argument filefield.module on line...
andrew morton [Mon, 15 Sep 2008 20:58:53 +0000]
#308832 by pwolanin, Wrong datatype for second argument filefield.module on line 289.

5 years ago#303796 by Moonshine, #ahah wrapper is incorrect for 'remove-btn'.
andrew morton [Sat, 13 Sep 2008 00:43:27 +0000]
#303796 by Moonshine, #ahah wrapper is incorrect for 'remove-btn'.

5 years ago#304077 by Moonshine, Follow-up little string cleanup...
andrew morton [Tue, 9 Sep 2008 18:56:46 +0000]
#304077 by Moonshine, Follow-up little string cleanup...

5 years ago#304077 by Moonshine, Upload validation help string cleanup.
andrew morton [Sat, 6 Sep 2008 19:53:25 +0000]
#304077 by Moonshine, Upload validation help string cleanup.

5 years ago#303104 by thesaint_02, German Translation.
andrew morton [Tue, 2 Sep 2008 16:36:10 +0000]
#303104 by thesaint_02, German Translation.

5 years agoDropping old translations.
andrew morton [Tue, 2 Sep 2008 16:35:20 +0000]
Dropping old translations.

5 years ago#301468 by dalin, Node form saves "List" checkbox as the opposite of what the user...
andrew morton [Fri, 29 Aug 2008 15:03:14 +0000]
#301468 by dalin, Node form saves "List" checkbox as the opposite of what the user selected.

5 years ago#296704 by Amitaibu, "$file->uid = $user->uid" is set twice. 6.x-3.0-alpha4
andrew morton [Wed, 27 Aug 2008 15:05:22 +0000]
#296704 by Amitaibu, "$file->uid = $user->uid" is set twice.

5 years ago#300619 by drewish, filefield_validate_is_image_help() should not have any parameters.
andrew morton [Wed, 27 Aug 2008 14:47:12 +0000]
#300619 by drewish, filefield_validate_is_image_help() should not have any parameters.

5 years ago#295896 by drewish, Fields were loosing the Hide Description setting.
andrew morton [Wed, 27 Aug 2008 14:22:36 +0000]
#295896 by drewish, Fields were loosing the Hide Description setting.

5 years ago#297035 by vladimir.dolgopolov, HTTP error 0 on AHAH callbacks.
andrew morton [Wed, 27 Aug 2008 13:54:18 +0000]
#297035 by vladimir.dolgopolov, HTTP error 0 on AHAH callbacks.

5 years ago#299380 by grandcat, use file_get_mimetype() when mimedetect.module is not installed.
andrew morton [Wed, 27 Aug 2008 13:06:35 +0000]
#299380 by grandcat, use file_get_mimetype() when mimedetect.module is not installed.

5 years ago#295896 by Amitaibu and webchick, Allow file's description field to be hidden and...
andrew morton [Wed, 20 Aug 2008 00:37:16 +0000]
#295896 by Amitaibu and webchick, Allow file's description field to be hidden and set defaults for field settings.

5 years agoAdded a filefield_widget_file_path() function to compute the widgets file path.
andrew morton [Sat, 16 Aug 2008 20:09:52 +0000]
Added a filefield_widget_file_path() function to compute the widgets file path.

5 years agoRemoving trailing whitespace.
andrew morton [Sat, 16 Aug 2008 20:08:34 +0000]
Removing trailing whitespace.

5 years agoremove unnecessary submit callback for remove_btn. 6.x-3.0-alpha3
Darrel O\'Pry [Tue, 12 Aug 2008 02:27:37 +0000]
remove unnecessary submit callback for remove_btn.
reset item to default value when remove is selected instead of just changing fid to 0 so description field gets erased.

5 years agofix max filesizer per node validation, if max_size is not set do not check.
Darrel O\'Pry [Mon, 11 Aug 2008 22:16:42 +0000]
fix max filesizer per node validation, if max_size is not set do not check.

5 years agododge devel.module errors... I still really hate that I can't send the application...
Darrel O\'Pry [Mon, 11 Aug 2008 21:00:07 +0000]
dodge devel.module errors... I still really hate that I can't send the application/javascript content type..
I'm gonna track that bug down one day.

5 years agoimplement per node/field max cumulative filesize validation.
Darrel O\'Pry [Mon, 11 Aug 2008 20:54:21 +0000]
implement per node/field  max cumulative filesize validation.

5 years ago#293977 by Amitaibu, fix 404 errors on file view, typo in filefield's hook_file_download.
Darrel O\'Pry [Mon, 11 Aug 2008 20:00:52 +0000]
#293977 by Amitaibu, fix 404 errors on file view, typo in filefield's hook_file_download.

5 years ago#286834 by quicksketch and dopry, so AHAH was in place... If you're using ahah make...
Darrel O\'Pry [Mon, 11 Aug 2008 18:50:10 +0000]
#286834 by quicksketch and dopry, so AHAH was in place... If you're using ahah make sure your wrapper id exists,
otherwise stuff can be a real mess. Also the jQuery form plugin does file submission in an iFrame and you can't
trust the post in the network console. I had to put the ahah wrapper in #prefix/#suffix and they have to be
overridden in the JS callback to prevent duplicate div wrappers appearing... I kind of wish ahah replaced it's
wrapper rather than  inserting inside the wrapper. ce la vie. but here is working JS upload and remove.

5 years ago#292247 by drewish, Javascript was preventing uploads of all but the first listed... 6.x-1.0-alpha2 6.x-3.0-alpha2
andrew morton [Fri, 8 Aug 2008 17:37:48 +0000]
#292247 by drewish, Javascript was preventing uploads of all but the first listed extension.

5 years ago#280801 by dopry, update input[@file].accept to be a comma separated instead of pipe...
Darrel O\'Pry [Fri, 1 Aug 2008 18:18:52 +0000]
#280801 by dopry, update input[@file].accept to be a comma separated instead of pipe separated.

5 years ago#286834 by drewish and dopry, fix validation blocking upload and remove functionality. 6.x-3.0-alpha1
Darrel O\'Pry [Fri, 1 Aug 2008 04:58:59 +0000]
#286834 by drewish and dopry, fix validation blocking upload and remove functionality.

5 years ago#289761 by nonsie, Display help text for images listing min size first followed by...
andrew morton [Fri, 1 Aug 2008 00:34:48 +0000]
#289761 by nonsie, Display help text for images listing min size first followed by max size.

5 years ago#289335 by drewish, Add field_file_save_file() to create files from the filesystem.
andrew morton [Thu, 31 Jul 2008 17:07:03 +0000]
#289335 by drewish, Add field_file_save_file() to create files from the filesystem.

5 years agoAdding a help function for file_validate_is_image().
andrew morton [Thu, 31 Jul 2008 17:05:52 +0000]
Adding a help function for file_validate_is_image().

5 years agoAdd a theme function to convert seconds into a minutes:seconds format.
andrew morton [Thu, 31 Jul 2008 12:22:55 +0000]
Add a theme function to convert seconds into a minutes:seconds format.
Added some PHPDocs.

5 years agoremove debuggling line from the mizzlethwarp.
Darrel O\'Pry [Thu, 31 Jul 2008 06:02:43 +0000]
remove debuggling line from the mizzlethwarp.

5 years ago#286629 by dopry, restore default formatter. silly me.
Darrel O\'Pry [Thu, 31 Jul 2008 05:25:11 +0000]
#286629 by dopry, restore default formatter. silly me.

5 years agoproperly namespace filefield tokens.
Darrel O\'Pry [Thu, 31 Jul 2008 05:14:16 +0000]
properly namespace filefield tokens.

5 years ago#287946 by dopry, the node_form_submit_build_node($form, $form_state) isn't needed
Darrel O\'Pry [Thu, 31 Jul 2008 04:24:41 +0000]
#287946 by dopry, the node_form_submit_build_node($form, $form_state)  isn't needed
for normal submit callbacks... only a re-build is needed. I need to research what the
submit build function is for... I think maybe it's only needed for JS callbacks...

5 years ago#289330 by drewish, build the upload validators array in a function so it
andrew morton [Thu, 31 Jul 2008 03:21:56 +0000]
#289330 by drewish, build the upload validators array in a function so it
can be easily reused.

5 years ago#289284 by drewish, Update filefield_meta to D6. The metadata is loaded
andrew morton [Thu, 31 Jul 2008 01:02:15 +0000]
#289284 by drewish, Update filefield_meta to D6. The metadata is loaded
into $file->data now but still stored in the filefield_meta table for
future views use. There's no display of the data at this point.

5 years agoack... move node_submit_build_node to button callback instead of process function.
Darrel O\'Pry [Wed, 30 Jul 2008 18:05:28 +0000]
ack... move node_submit_build_node to button callback instead of process function.

5 years ago#288426 by drewish, Imagefield doesn't validate image resolution. with modificcation.
Darrel O\'Pry [Wed, 30 Jul 2008 18:02:41 +0000]
#288426 by drewish, Imagefield doesn't validate image resolution. with modificcation.
we're going to simple require that each validation callback require a matching help
callback. I don't even want to bother with function exists.

added help callback for core file_validate_image_resolution callback.
added node_form_submit_build_node which snuck in there but was needed anyway...

5 years ago#286981 by Decphered, restore client side validation. Dude you're awesome...
Darrel O\'Pry [Sat, 26 Jul 2008 20:15:36 +0000]
#286981 by Decphered, restore client side validation. Dude you're awesome...

5 years agoi#286972 by Deciphered, Fix $extensions validation to enable any file if extensions...
Darrel O\'Pry [Sat, 26 Jul 2008 20:13:25 +0000]
i#286972 by Deciphered, Fix $extensions validation to enable any file if extensions left blank

5 years ago#286834 by eojthebrave and drewish,
Darrel O\'Pry [Sat, 26 Jul 2008 20:11:01 +0000]
#286834 by eojthebrave and drewish,
Only uploads/removes file if required fields are filled out, then wipes all fields

5 years ago#286405 by Moonshine, filefield validation error catching all fields not just file...
Darrel O\'Pry [Wed, 23 Jul 2008 19:34:10 +0000]
#286405 by Moonshine, filefield validation error catching all fields not just file and imagefield...

5 years ago#281617 by drewish, add alt tag to mime icons.
Darrel O\'Pry [Wed, 23 Jul 2008 17:20:49 +0000]
#281617 by drewish, add alt tag to mime icons.

5 years ago#286144 by Moonshine with modifications. Set default values for CCK properly. Issues...
Darrel O\'Pry [Wed, 23 Jul 2008 14:44:39 +0000]
#286144 by Moonshine with modifications. Set default values for CCK properly. Issues remain with 'Add a new item' on
unlimited value fields.

5 years agoupdating list option settings a little... adding list options update to .install...
Darrel O\'Pry [Wed, 23 Jul 2008 00:05:31 +0000]
updating list option settings a little... adding list options update to .install...
merging all drupal 6 updates into a single update function...

5 years agoinitial upgrade path... still need to move description to 'data' in the widget.
Darrel O\'Pry [Tue, 22 Jul 2008 19:42:42 +0000]
initial upgrade path... still need to move description to 'data' in the widget.

5 years agosweet upload validation seems to be back in play.
Darrel O\'Pry [Mon, 21 Jul 2008 23:47:40 +0000]
sweet upload validation seems to be back in play.

5 years agofix label rendering.
Darrel O\'Pry [Mon, 21 Jul 2008 19:07:35 +0000]
fix label rendering.

5 years agodisable ahah to make life easier on early adopters until I get the ahah stuff working...
Darrel O\'Pry [Thu, 17 Jul 2008 04:56:26 +0000]
disable ahah to make life easier on early adopters until I get the ahah stuff working again.

5 years agobeginning to restore ahah magic... need to figure out the change from the old multifo...
Darrel O\'Pry [Thu, 17 Jul 2008 04:54:15 +0000]
beginning to restore ahah magic... need to figure out the change from the old multiform callback,
and the current widget system....

5 years agooh geez my required validation and intended workflow is in place now... trouble....
Darrel O\'Pry [Thu, 17 Jul 2008 03:13:49 +0000]
oh geez my required validation and intended workflow is in place now... trouble....

5 years agosome debugging state stuff for eaton to check out... wierdness with form_state/clicke...
Darrel O\'Pry [Wed, 16 Jul 2008 23:47:17 +0000]
some debugging state stuff for eaton to check out... wierdness with form_state/clicked buttons.

5 years agoapparently after_build is useless for me after all...
Darrel O\'Pry [Wed, 16 Jul 2008 19:28:34 +0000]
apparently after_build is useless for me after all...

5 years agoremove a crufty dsm...
Darrel O\'Pry [Wed, 16 Jul 2008 16:39:54 +0000]
remove a crufty dsm...

5 years agoinitialize data as array, and deserialize on item load, since the 'serialize' flag...
Darrel O\'Pry [Wed, 16 Jul 2008 16:35:00 +0000]
initialize data as array, and deserialize on item load, since the 'serialize' flag in the schema
only works on the way in.

5 years agoThe return of #after_build and fixing of some widget pass throughs...
Darrel O\'Pry [Tue, 15 Jul 2008 22:06:15 +0000]
The return of #after_build and fixing of some widget pass throughs...

5 years agoforce list option now hides individual list checkboxes.
Darrel O\'Pry [Tue, 15 Jul 2008 06:04:29 +0000]
force list option now hides individual list checkboxes.

5 years agolosing filefield_*_settings.incs... just too many files...
Darrel O\'Pry [Tue, 15 Jul 2008 05:26:15 +0000]
losing filefield_*_settings.incs... just too many files...

5 years agoremove after_build...
Darrel O\'Pry [Tue, 15 Jul 2008 04:26:36 +0000]
remove after_build...
add pass through to {$element['#type']}_widget_{$callback} to filefield_widget_{$callback}'s

imagefield now completely extends filefield... and filefield can use the imagefield widgets...
dirty promiscuous widgets...

5 years agofix module determination in filefield_file...
Darrel O\'Pry [Tue, 15 Jul 2008 02:07:46 +0000]
fix module determination in filefield_file...
fix default value assignment in filefield_widget.

5 years agofix to field_settings merging for file type fields depending on file field.
Darrel O\'Pry [Tue, 15 Jul 2008 00:56:31 +0000]
fix to field_settings merging for file type fields depending on file field.

5 years agoadding initial widget development notes.
Darrel O\'Pry [Mon, 14 Jul 2008 23:29:39 +0000]
adding initial widget development notes.
remove some debug code...
add field_settings callback implementations.

5 years agohook_widget_settings merge code for filefield widgets.
Darrel O\'Pry [Mon, 14 Jul 2008 20:09:19 +0000]
hook_widget_settings merge code for filefield widgets.
allows modules to simply call filefield_widget_settings($op, $wiget)
and implement {$widget_type}_widget_settings_{$op} callbacks.
filefield_widget_settings will try to dynamically include {$module}
so you can put the settings outside your module as desired.

5 years agostarting to clean up the forms a little.
Darrel O\'Pry [Mon, 14 Jul 2008 08:12:46 +0000]
starting to clean up the forms a little.

5 years agoremoving unused default widget function.
Darrel O\'Pry [Mon, 14 Jul 2008 06:25:57 +0000]
removing unused default widget function.

5 years agosplit tokens into their own module.
Darrel O\'Pry [Mon, 14 Jul 2008 06:19:38 +0000]
split tokens into their own module.

5 years agolosing a debugging statement.
Darrel O\'Pry [Mon, 14 Jul 2008 06:18:07 +0000]
losing a debugging statement.

5 years agobasic functioning minimal filefield for D6.
Darrel O\'Pry [Mon, 14 Jul 2008 06:14:50 +0000]
basic functioning minimal filefield for D6.

5 years agocontinuing along...
Darrel O\'Pry [Mon, 14 Jul 2008 05:29:07 +0000]
continuing along...

5 years agostrip filefield to basics to prep for D6 release and as ImageField dependency.
Darrel O\'Pry [Mon, 14 Jul 2008 04:57:43 +0000]
strip filefield to basics to prep for D6 release and as ImageField dependency.

5 years agorename widget include to match imagefield naming conventions.
Darrel O\'Pry [Sun, 13 Jul 2008 17:40:46 +0000]
rename widget include to match imagefield naming conventions.

5 years agoset mode and use recursive flag for mkdir in field_file_check_directory.
Darrel O\'Pry [Sun, 13 Jul 2008 05:00:03 +0000]
set mode and use recursive flag for mkdir in field_file_check_directory.

5 years agoestablish a default value for files as a files array with all empty or 0 valued elements.
Darrel O\'Pry [Sun, 13 Jul 2008 02:34:31 +0000]
establish a default value for files as a files array with all empty or 0 valued elements.

5 years agoProper usage of English language idioms. 6.x-1.0-beta3
Jakob Petsovits [Fri, 11 Jul 2008 12:23:53 +0000]
Proper usage of English language idioms.

5 years ago#280054: Make the "List" option work also for disabling the checkbox.
Jakob Petsovits [Fri, 11 Jul 2008 12:21:18 +0000]
#280054: Make the "List" option work also for disabling the checkbox.

5 years ago#279216 by drewish: Better wording for the file size limit setting descriptions.
Jakob Petsovits [Fri, 11 Jul 2008 11:55:18 +0000]
#279216 by drewish: Better wording for the file size limit setting descriptions.

5 years ago#278867: Allow all file extensions when none have been specified.
Jakob Petsovits [Fri, 11 Jul 2008 11:36:10 +0000]
#278867: Allow all file extensions when none have been specified.

But not only that: The larger change in this commit is that all
restrictions have been split out into a validator/restriction hook,
so external restrictions can now also provide their requirement messages
for the file upload element.

Getting rid of nearly all filefield specific upload requirement exceptions.

5 years agoyeah serlized columns... fix hook_file_references args.
Darrel O\'Pry [Mon, 7 Jul 2008 22:15:56 +0000]
yeah serlized columns... fix hook_file_references args.

5 years agomove initialization of update_name to be fore it is first used.
Darrel O\'Pry [Mon, 7 Jul 2008 08:56:34 +0000]
move initialization of update_name to be fore it is first used.
add data column to file fields for widgets to store serialized data per item. (display settings, transform settings, etc).

5 years agoupdate hook_file implementation to reflect modt recent core hook_file path with callb...
Darrel O\'Pry [Mon, 7 Jul 2008 05:50:32 +0000]
update hook_file implementation to reflect modt recent core hook_file path with callbacks per $op.
add field_file_references($file, $field) to load references by field.
rename $item['filefield_delete'] to more descriptive $item['field_name'].

5 years agofix variable name in hook_field_settings call to _filefield_field_formatter_info()..
Darrel O\'Pry [Mon, 7 Jul 2008 05:08:14 +0000]
fix variable name in hook_field_settings call to _filefield_field_formatter_info()..

5 years ago#183864, #277943: File size restrictions.
Jakob Petsovits [Thu, 3 Jul 2008 17:38:39 +0000]
#183864, #277943: File size restrictions.
Extensible via hook_filefield_filesize_restrictions(), used for
displaying the upload form as well as for validating the actual uploads.
And of course, this comes with the new per-file and per-node file size
restriction "examples".

5 years agoFix PHP notice, and have a couple less lines of code.
Jakob Petsovits [Mon, 30 Jun 2008 23:31:23 +0000]
Fix PHP notice, and have a couple less lines of code.

5 years agoLess code duplication once more.
Jakob Petsovits [Mon, 30 Jun 2008 23:25:44 +0000]
Less code duplication once more.

5 years agoMake node deletions and revisions work again. 6.x-1.0-beta2
Jakob Petsovits [Sun, 29 Jun 2008 23:39:14 +0000]
Make node deletions and revisions work again.
Note that the 5.x revision bug (#263162) does *not* appear anymore. Whoo!

5 years agoShow the '#required' state of the "File widgets" table.
Jakob Petsovits [Sun, 29 Jun 2008 22:32:34 +0000]
Show the '#required' state of the "File widgets" table.

5 years agoOh wow, Coder is good. Missed this when reverting to unconditional includes.
Jakob Petsovits [Sun, 29 Jun 2008 22:08:06 +0000]
Oh wow, Coder is good. Missed this when reverting to unconditional includes.
(which happened on my local harddisk, so you didn't notice the revert at all)

5 years agoPort filefield_meta to Drupal 6. ...NOT!
Jakob Petsovits [Sun, 29 Jun 2008 21:50:15 +0000]
Port filefield_meta to Drupal 6.   ...NOT!

5 years agoReduce code duplication.
Jakob Petsovits [Sun, 29 Jun 2008 20:47:29 +0000]
Reduce code duplication.

5 years agoFilefield was becoming too large, so let's split it up.
Jakob Petsovits [Sun, 29 Jun 2008 20:04:34 +0000]
Filefield was becoming too large, so let's split it up. and work completely
with declarational 'file' properties in the various hooks,
whereas still needs to be included manually.

5 years agoReorder ($field, $file) parameters to ($file, $field), as I already
Jakob Petsovits [Sun, 29 Jun 2008 18:26:54 +0000]
Reorder ($field, $file) parameters to ($file, $field), as I already
stumbled over a few instances where the former is suboptimal.
Also, pass possible file formatter settings to the theme function.

5 years agoOh right, and remove the $info parameter from the widget specific hook,
Jakob Petsovits [Sun, 29 Jun 2008 17:14:42 +0000]
Oh right, and remove the $info parameter from the widget specific hook,
we don't need that as it's given in the function name anyways.

5 years agoRemove the generic widget settings form_alter hook in favor of
Jakob Petsovits [Sun, 29 Jun 2008 17:12:37 +0000]
Remove the generic widget settings form_alter hook in favor of
multiple file widget specific ones. In tandem with that, add
file formatter settings to the field settings. Let's see if it works.

Also, make hook_file_widget_info() more like hook_file_formatter_info()
so that the array key doesn't specify the form element but is merely an
arbitrary key, with the need to be unique only inside each module.

5 years agoNext major stroke, admin UI: make file widgets and formatters sortable
Jakob Petsovits [Sun, 29 Jun 2008 14:50:16 +0000]
Next major stroke, admin UI: make file widgets and formatters sortable
and have a checkbox to enable/disable them.

The latter comes with additional functionality in terms of a validator
that only accepts files when any enabled widget handles it.
a.k.a. easy mimetype based upload restrictions. Makes it a breeze
to have image-only filefields without specifying the allowed extensions.

5 years agoMove filefield_check_directory() next to filefield_file_upload(),
Jakob Petsovits [Sat, 28 Jun 2008 20:53:40 +0000]
Move filefield_check_directory() next to filefield_file_upload(),
which is the only place where it's actually used.
It had kind of an orphan status further down, which I didn't like.

5 years agoScrap hours of CSS tweaking for the previous (simpler) solution that 6.x-1.0-beta1
Jakob Petsovits [Sat, 28 Jun 2008 07:53:07 +0000]
Scrap hours of CSS tweaking for the previous (simpler) solution that
also hides behind the moving table header. Yeah, simpler is always better.