5 years agoRemoved some calls to debugging functions that made it in.
Sam Boyer [Sat, 23 Aug 2008 00:57:55 +0000]
Removed some calls to debugging functions that made it in.

5 years agoCheckpoint checkin. Slightly less broken panels_page, but not that much less broken.
Earl Miles [Fri, 22 Aug 2008 22:37:18 +0000]
Checkpoint checkin. Slightly less broken panels_page, but not that much less broken.

5 years agoRolling back addition of braces to panels_load_include()
Sam Boyer [Fri, 22 Aug 2008 12:39:03 +0000]
Rolling back addition of braces to panels_load_include()

5 years agoremoved too over-cleverness from the fetch* functions
Sam Boyer [Thu, 21 Aug 2008 21:25:54 +0000]
removed too over-cleverness from the fetch* functions

5 years agocrufty, residual code from when we had a router quickref table removed
Sam Boyer [Thu, 21 Aug 2008 20:10:56 +0000]
crufty, residual code from when we had a router quickref table removed

5 years agoLast commit was weird and crufty, dunno why. This should fix it.
Sam Boyer [Thu, 21 Aug 2008 05:21:50 +0000]
Last commit was weird and crufty, dunno why. This should fix it.

5 years agoFixed up panels_page_save() and affiliated functions. They SHOULD now work with the...
Sam Boyer [Thu, 21 Aug 2008 05:19:43 +0000]
Fixed up panels_page_save() and affiliated functions. They SHOULD now work with the new system.

5 years agoForgot some of the edits while forward-porting.
Sam Boyer [Tue, 19 Aug 2008 15:17:34 +0000]
Forgot some of the edits while forward-porting.

5 years agoChanged name of argument error code constants slightly; added brackets in panels_load...
Sam Boyer [Tue, 19 Aug 2008 15:16:13 +0000]
Changed name of argument error code constants slightly; added brackets in panels_load_include() for clarity.

5 years agoIncremental commit, lots more odds and ends.
Sam Boyer [Tue, 19 Aug 2008 15:15:20 +0000]
Incremental commit, lots more odds and ends.

5 years agoFixed an old error code constant; relocated the handlers to higher up in the file...
Sam Boyer [Tue, 19 Aug 2008 15:13:02 +0000]
Fixed an old error code constant; relocated the handlers to higher up in the file; moved sanitizer back into this main file, other odds and ends.

5 years agoUpdated with renamed argument error codes.
Sam Boyer [Tue, 19 Aug 2008 14:57:58 +0000]
Updated with renamed argument error codes.

5 years agoForward port of changes made to node context.
Sam Boyer [Tue, 19 Aug 2008 14:43:56 +0000]
Forward port of changes made to node context.

5 years agoUpdated function signatures to include $subtype as first parameter; also cleaned...
Sam Boyer [Tue, 19 Aug 2008 07:04:10 +0000]
Updated function signatures to include $subtype as first parameter; also cleaned up repetitive copy/pasted docblocks on many render callbacks.

5 years agoDocblock updates and changes in code style for references to match merlin's ($a ...
Sam Boyer [Tue, 19 Aug 2008 06:25:59 +0000]
Docblock updates and changes in code style for references to match merlin's ($a = &$b instead of $a =& $b)

5 years agoPanels page have any of its own ajax - it's all done by the panels engine. This file...
Sam Boyer [Tue, 19 Aug 2008 04:55:19 +0000]
Panels page have any of its own ajax - it's all done by the panels engine. This file was superfluous.

5 years agoRewrote master loader to accommodate static panel_pages; rewrote admin loaders to...
Sam Boyer [Tue, 19 Aug 2008 04:27:28 +0000]
Rewrote master loader to accommodate static panel_pages; rewrote admin loaders to accomodate changes in menu arg processing; moved several more functions out into their respective inc files; added a bunch more docblocks.

5 years agoUpdated panels_page_load() to make use of a fetcher when called on an already-cached...
Sam Boyer [Tue, 19 Aug 2008 04:25:50 +0000]
Updated panels_page_load() to make use of a fetcher when called on an already-cached $panel_page that doesn't have the primary display loaded, although that use case is deprecated and should be avoided (for the sake of clarity). Other than that, mostly minor touch-ups.

5 years agoIncremental commit - added a few missing inc loaders; also added the import page...
Sam Boyer [Tue, 19 Aug 2008 04:19:59 +0000]
Incremental commit - added a few missing inc loaders; also added the import page form. Next - fixing all the submit functions! yay...

5 years agoTouch-up and fixing a stupid math error3
Sam Boyer [Tue, 19 Aug 2008 03:20:26 +0000]
Touch-up and fixing a stupid math error3

5 years agoJust trimming out some cruft.
Sam Boyer [Tue, 19 Aug 2008 03:06:15 +0000]
Just trimming out some cruft.

5 years agoSmall docblock touchup.
Sam Boyer [Tue, 19 Aug 2008 02:54:04 +0000]
Small docblock touchup.

5 years agoSmall tweaks and touch-ups; also condensed some of the logic for embedded forms.
Sam Boyer [Tue, 19 Aug 2008 02:47:26 +0000]
Small tweaks and touch-ups; also condensed some of the logic for embedded forms.

5 years ago'Write' functions - functions that are concerned with putting data in the database...
Sam Boyer [Tue, 19 Aug 2008 02:46:08 +0000]
'Write' functions - functions that are concerned with putting data in the database, or some other form of storage. The latter is the conceptual justification for putting export functions in here, too...which was originally done for practical reasons :)

5 years agoDitch the router quickref table, totally unnecessary now.
Sam Boyer [Tue, 19 Aug 2008 02:37:46 +0000]
Ditch the router quickref table, totally unnecessary now.

5 years agoUpdated with info about argument plugin error codes.
Sam Boyer [Tue, 19 Aug 2008 02:34:31 +0000]
Updated with info about argument plugin error codes.

5 years agoFinishing up with the 'fetch' functions
Sam Boyer [Tue, 19 Aug 2008 02:01:43 +0000]
Finishing up with the 'fetch' functions

5 years agoInit import; all functions dealing with retrieval & rearrangement of panels_page...
Sam Boyer [Tue, 19 Aug 2008 01:26:15 +0000]
Init import; all functions dealing with retrieval & rearrangement of panels_page-related data is contained here.

The panels_page_fetch*() family of functions were also notably refactored from when they last appeared in the panels_page.module file; they are now much more targeted, single-purpose entities with clear inputs and outputs. See the docblock additions for details.

5 years agoView panes display plugin. Note that this checkin may break a bunch of content types...
Earl Miles [Mon, 18 Aug 2008 23:37:24 +0000]
View panes display plugin. Note that this checkin may break a bunch of content types because I added $subtype to some content type declarations and need to go through all the content types and update the render and title functions.

5 years agoIncremental commit. Stripped a TON of stuff out into 'write' and 'read' include files.
Sam Boyer [Mon, 18 Aug 2008 21:39:14 +0000]
Incremental commit. Stripped a TON of stuff out into 'write' and 'read' include files.

5 years agoIncremental commit; added new loader function designed to grab edit-cache data instea...
Sam Boyer [Mon, 18 Aug 2008 20:56:32 +0000]
Incremental commit; added new loader function designed to grab edit-cache data instead of static-db data.

5 years agoCreated a second admin loader for callbacks that need to generate an edit cache ...
Sam Boyer [Mon, 18 Aug 2008 20:55:24 +0000]
Created a second admin loader for callbacks that need to generate an edit cache (for ajax callbacks)

5 years agoIncremental commit; refactored most of the admin callbacks to be (partially) complian...
Sam Boyer [Mon, 18 Aug 2008 20:54:00 +0000]
Incremental commit; refactored most of the admin callbacks to be (partially) compliant with FAPI, and to deal with the new logic-at-the-loader-level approach.

5 years agoAdded missing panels_load_include('ajax') call.
Sam Boyer [Mon, 18 Aug 2008 19:14:16 +0000]
Added missing panels_load_include('ajax') call.

5 years agoForward port of the update to panels_export_display() - disappearance of the 'name...
Sam Boyer [Mon, 18 Aug 2008 10:54:02 +0000]
Forward port of the update to panels_export_display() - disappearance of the 'name' field still needs investigation.

5 years agoFixed a dumb typo, some other small-scale cleanup.
Sam Boyer [Mon, 18 Aug 2008 10:53:08 +0000]
Fixed a dumb typo, some other small-scale cleanup.

5 years agoIncremental commit. Added separate static cache for loaded panels_pages and took...
Sam Boyer [Mon, 18 Aug 2008 10:52:35 +0000]
Incremental commit. Added separate static cache for loaded panels_pages and took steps to ensure consistency in its data. Some additional docblocks, and other small touchups.

5 years agoSwitched to while loop for the big iterator in hook_menu_alter(), as it's a shade...
Sam Boyer [Mon, 18 Aug 2008 10:51:21 +0000]
Switched to while loop for the big iterator in hook_menu_alter(), as it's a shade faster.

5 years agoIncremental commit. Slowly hacking away at the FAPI changes.
Sam Boyer [Mon, 18 Aug 2008 10:50:40 +0000]
Incremental commit. Slowly hacking away at the FAPI changes.

I'm probably going to write a single FAPI pass-thru for all or most of the individual admin form page callbacks. Eventually.

5 years agoAdded an !empty() call for E_NOTICE compliance.
Sam Boyer [Mon, 18 Aug 2008 10:33:41 +0000]
Added an !empty() call for E_NOTICE compliance.

5 years agoTweaked pane rendering to skip creating a title if no title was returned by the pane...
Sam Boyer [Mon, 18 Aug 2008 04:50:31 +0000]
Tweaked pane rendering to skip creating a title if no title was returned by the pane render callback.

5 years agoReplaced call to sizeof() function with count().
Sam Boyer [Mon, 18 Aug 2008 02:04:42 +0000]
Replaced call to sizeof() function with count().

5 years agoFixed the $map (as in the drupal menu system's $map concept) rebuilder.
Sam Boyer [Mon, 18 Aug 2008 00:25:25 +0000]
Fixed the $map (as in the drupal menu system's $map concept) rebuilder.

5 years agoIncremental commit:
Sam Boyer [Sun, 17 Aug 2008 23:16:18 +0000]
Incremental commit:

1. Expunged all render-time uses of quickref, since we're abandoning that method.
2. Added calls to load the display along with the panel page for admin screens.
3. Added a bit of docblock.

5 years agoIncremental commit; docblock tweaks, and minor refactor of one validator (which has...
Sam Boyer [Sun, 17 Aug 2008 22:34:24 +0000]
Incremental commit; docblock tweaks, and minor refactor of one validator (which has been backported, minus string changes).

5 years agoRolled back earlier changes to admin path schema - $panel_page->name now precedes...
Sam Boyer [Sun, 17 Aug 2008 21:31:12 +0000]
Rolled back earlier changes to admin path schema - $panel_page->name now precedes the action verb (e.g. edit, export) again.

5 years agoQuickref table is now completely deprecated; just keeping it for the moment to be...
Sam Boyer [Sun, 17 Aug 2008 08:27:27 +0000]
Quickref table is now completely deprecated; just keeping it for the moment to be sure.

5 years agoReinstated the %map arg on several admin callbacks; changed the storage mechanism...
Sam Boyer [Sun, 17 Aug 2008 08:26:27 +0000]
Reinstated the %map arg on several admin callbacks; changed the storage mechanism for the loader flags;

5 years agoShifted the css filter into its own separate function for reusability.
Sam Boyer [Sun, 17 Aug 2008 08:25:22 +0000]
Shifted the css filter into its own separate function for reusability.

5 years agoScratched a couple more unneeded bits from the mask. Moved mask storage directly...
Sam Boyer [Sun, 17 Aug 2008 08:23:46 +0000]
Scratched a couple more unneeded bits from the mask. Moved mask storage directly into the panels_page table, and updated load functions accordingly.

5 years agoKilled some more of the unnecssary bitmask items; fixed typos; improved hook_menu...
Sam Boyer [Sun, 17 Aug 2008 07:03:27 +0000]
Killed some more of the unnecssary bitmask items; fixed typos; improved hook_menu() readability; safely reconstituted the panels_page_get_current() function for API consistency from D5.

5 years agoConsiderable refactoring. The separation between logic/loading functions and renderin...
Sam Boyer [Sun, 17 Aug 2008 06:59:13 +0000]
Considerable refactoring. The separation between logic/loading functions and rendering functions is almost complete, now.

5 years agoFix to build-breaking bug in last commit (can't use function return values in write...
Sam Boyer [Sun, 17 Aug 2008 03:37:22 +0000]
Fix to build-breaking bug in last commit (can't use function return values in write context)

5 years agoFixes for E_NOTICE compliance with $load_data. Moved access check to later in the...
Sam Boyer [Sun, 17 Aug 2008 03:33:39 +0000]
Fixes for E_NOTICE compliance with $load_data. Moved access check to later in the master loader; we don't want Panels denying access to things that it's not overriding!

5 years agoForgot to update replace instance of $quickref->meta with $quickref->flags
Sam Boyer [Sun, 17 Aug 2008 02:50:51 +0000]
Forgot to update replace instance of $quickref->meta with $quickref->flags

5 years agoForward-ported an E_NOTICE fix and logic improvements to panels_page_load().
Sam Boyer [Sun, 17 Aug 2008 02:49:17 +0000]
Forward-ported an E_NOTICE fix and logic improvements to panels_page_load().

5 years agoRemoved suuuuuper crufty ajax functions - they hadn't been in use for who knows how...
Sam Boyer [Sun, 17 Aug 2008 02:17:45 +0000]
Removed suuuuuper crufty ajax functions - they hadn't been in use for who knows how many months, and nobody noticed :)

5 years agoMoved the admin wildcard loader out into the main panels_page.module file (where...
Sam Boyer [Sun, 17 Aug 2008 02:06:51 +0000]
Moved the admin wildcard loader out into the main panels_page.module file (where it should have been in the first place), and rejiggered the paths to match up with the new editing paths (action verb before $panel_page->name). The new paths may be rolled back.

5 years agoNixed the wildcards and stored_router fields, and changed 'meta' over to the much...
Sam Boyer [Sun, 17 Aug 2008 02:04:57 +0000]
Nixed the wildcards and stored_router fields, and changed 'meta' over to the much less annoying/more appropriate 'flags.' stored_router was collapsed into flags; wildcards may be restored later, but for the moment I don't think there's much value added in duplicating that data, so I'm content to calculate it on the fly.

5 years agoFairly large reorganization, although not much change in the logic. Most notable...
Sam Boyer [Sun, 17 Aug 2008 02:01:45 +0000]
Fairly large reorganization, although not much change in the logic. Most notable big item is that hook_menu() and hook_menu_alter() are now separate again, and the functions have been reorganized to place the two that hook_menu() calls at the top of the file (purely for conceptual clarity).

Also switched over to the use of a 'flags' field in the router quickref table, which is where we tuck as much of our behavior-governing bitmask as possible during the actual menu build process.

5 years agoIncremental commit - numerous behavioral changes. Admin loader relocated to here...
Sam Boyer [Sun, 17 Aug 2008 01:54:58 +0000]
Incremental commit - numerous behavioral changes. Admin loader relocated to here; re-added implementation of hook_menu() as it now appears possible to cleanly separate it from what must be done in hook_menu_alter(). Cleaned up some docblocks, moved other functions around...lots of stuff.

5 years agoShifted all possible render preparation functions into; also...
Sam Boyer [Sun, 17 Aug 2008 01:52:06 +0000]
Shifted all possible render preparation functions into; also added an @file description to it.

5 years agoAdded panels_page_load_include(), cleaned out some more crufty code.
Sam Boyer [Sat, 16 Aug 2008 06:26:38 +0000]
Added panels_page_load_include(), cleaned out some more crufty code.

5 years agoMerged in the on-render call to the css filter.
Sam Boyer [Sat, 16 Aug 2008 06:18:50 +0000]
Merged in the on-render call to the css filter.

5 years agoInit import of the css filter, added later in the RC1 dev cycle
Sam Boyer [Sat, 16 Aug 2008 06:18:06 +0000]
Init import of the css filter, added later in the RC1 dev cycle

5 years agoMerging in changes made during the Beta5 to RC1 cycle.
Sam Boyer [Sat, 16 Aug 2008 06:17:28 +0000]
Merging in changes made during the Beta5 to RC1 cycle.

5 years agoJust adding minor phpdoc
Sam Boyer [Thu, 7 Aug 2008 01:22:07 +0000]
Just adding minor phpdoc

5 years agoUpdated to use error code constants.
Sam Boyer [Wed, 6 Aug 2008 19:02:00 +0000]
Updated to use error code constants.

5 years agoRelocated error code constants to panels.module
Sam Boyer [Wed, 6 Aug 2008 19:01:47 +0000]
Relocated error code constants to panels.module

5 years agoAdded some error code constants.
Sam Boyer [Wed, 6 Aug 2008 19:01:17 +0000]
Added some error code constants.

5 years agoIncremental commit.
Sam Boyer [Wed, 6 Aug 2008 18:57:41 +0000]
Incremental commit.

5 years agoIncremental commit. Updated to use some of the new constants.
Sam Boyer [Wed, 6 Aug 2008 17:38:54 +0000]
Incremental commit. Updated to use some of the new constants.

5 years agoRemoved some crufty code.
Sam Boyer [Wed, 6 Aug 2008 17:36:29 +0000]
Removed some crufty code.

5 years agoIncremental commit. Logic is partially written for the title/page callbacks
Sam Boyer [Wed, 6 Aug 2008 17:35:37 +0000]
Incremental commit. Logic is partially written for the title/page callbacks

5 years agoSwitched over to use of named constants for return values on failures.
Sam Boyer [Wed, 6 Aug 2008 17:27:08 +0000]
Switched over to use of named constants for return values on failures.

5 years agoRemoving duplicated layout files
Earl Miles [Wed, 6 Aug 2008 17:20:35 +0000]
Removing duplicated layout files

5 years agoremoved wildcards field and added metadata field.
Sam Boyer [Wed, 6 Aug 2008 09:19:47 +0000]
removed wildcards field and added metadata field.

5 years agoIncremental commit. Also removed crufty functions from when we were going to use...
Sam Boyer [Wed, 6 Aug 2008 09:19:08 +0000]
Incremental commit. Also removed crufty functions from when we were going to use custom loaders.

5 years agoCollapsing some menu item metadata into the bitmask; code cleanup.
Sam Boyer [Wed, 6 Aug 2008 09:16:54 +0000]
Collapsing some menu item metadata into the bitmask; code cleanup.

5 years agoCleaned up hook_menu_alter() logic, looks to be about 95% there now.
Sam Boyer [Wed, 6 Aug 2008 01:01:42 +0000]
Cleaned up hook_menu_alter() logic, looks to be about 95% there now.

5 years agoMinor codestyle updates; starting in on the big runtime logic-handler
Sam Boyer [Wed, 6 Aug 2008 01:00:14 +0000]
Minor codestyle updates; starting in on the big runtime logic-handler

5 years agoPart one of Views re-integration -- the equivalent of the old panels views legacy.
Earl Miles [Wed, 6 Aug 2008 00:24:46 +0000]
Part one of Views re-integration -- the equivalent of the old panels views legacy.

5 years agoUpdate panels exporter to D6
Earl Miles [Tue, 5 Aug 2008 00:25:47 +0000]
Update panels exporter to D6

5 years agoPanel nodes ported to D6
Earl Miles [Mon, 4 Aug 2008 23:13:47 +0000]
Panel nodes ported to D6

5 years agoForgot this file
Earl Miles [Mon, 4 Aug 2008 22:51:00 +0000]
Forgot this file

5 years agoFinish up ajax context editing stuff.
Earl Miles [Mon, 4 Aug 2008 20:04:11 +0000]
Finish up ajax context editing stuff.

5 years agoJust need to get the delete button working and then go through all the contexts,...
Earl Miles [Thu, 31 Jul 2008 00:05:45 +0000]
Just need to get the delete button working and then go through all the contexts, relationships and arguments to make sure their forms are working.

5 years agoWe're most of the way there! Our separate data storage mechanism appears to be mostly...
Sam Boyer [Mon, 28 Jul 2008 02:15:15 +0000]
We're most of the way there! Our separate data storage mechanism appears to be mostly working. Now the frontend loading needs to be done, along with the hook_menu_link_alter() stuff.

5 years agoCommitting as a reference point prior to refactoring without custom render load funct...
Sam Boyer [Sat, 26 Jul 2008 19:56:18 +0000]
Committing as a reference point prior to refactoring without custom render load functions.

5 years agoIncremental commit, just to get everything in.
Sam Boyer [Sat, 26 Jul 2008 01:49:11 +0000]
Incremental commit, just to get everything in.

Panels Page now installs successfully, although the schema is likely going to change. The essential infrastructure for the menu system is functioning correctly. The secondary router storage mechanism, page callbacks, temporary panel data storage mechanism (for render callbacks) and a few other things need to be designed - but we're on the home stretch.

5 years agoMinor E_NOTICE revision; some theme_panels_* functions were concatenating into $outpu...
Sam Boyer [Fri, 25 Jul 2008 21:09:05 +0000]
Minor E_NOTICE revision; some theme_panels_* functions were concatenating into $output without declaring it first.

5 years agoAdding forgotten files; does not really work yet, so do not expect...
Earl Miles [Fri, 25 Jul 2008 16:10:16 +0000]
Adding forgotten files; does not really work yet, so do not expect much from it.

5 years agoNearly there. Just need to write the storage mechanism for overridden loaders, then...
Sam Boyer [Fri, 25 Jul 2008 15:08:50 +0000]
Nearly there. Just need to write the storage mechanism for overridden loaders, then can start debugging.

5 years agoReworked bitmask; should basically be in functional form, now.
Sam Boyer [Fri, 25 Jul 2008 02:35:42 +0000]
Reworked bitmask; should basically be in functional form, now.

5 years agoInitial reworking of the bitmask.
Sam Boyer [Fri, 25 Jul 2008 00:01:20 +0000]
Initial reworking of the bitmask.

5 years agoForward-port of fix to handling of how hook_panels_include_directory() handles
Sam Boyer [Thu, 24 Jul 2008 23:22:37 +0000]
Forward-port of fix to handling of how hook_panels_include_directory() handles
plugin loading.

Original fix was made in version of

5 years agoInitial port of panels mini; still need to work on the "context" ajax stuff and conve...
Earl Miles [Thu, 24 Jul 2008 00:55:35 +0000]
Initial port of panels mini; still need to work on the "context" ajax stuff and convert it to the new system, but the other stuff appears to work at least a little. Also include some fixes to layouts as "id" turns out to be illegal due to Drupal setting its own id string.

5 years agoUpdate existing styles to Drupal 6.
Earl Miles [Wed, 23 Jul 2008 22:21:41 +0000]
Update existing styles to Drupal 6.

5 years agoUpdate panels node legacy to D6; renaming to just panels_node_content (Node panes)
Earl Miles [Wed, 23 Jul 2008 22:05:25 +0000]
Update panels node legacy to D6; renaming to just panels_node_content (Node panes)

5 years agoTemplatize all panel layouts; give each layout its own directory for cleanliness...
Earl Miles [Wed, 23 Jul 2008 21:14:29 +0000]
Templatize all panel layouts; give each layout its own directory for cleanliness. Slight improvement to the API needed for the move to work.