Log of /contributions/modules/banner/banner.module
Parent Directory
| 
Revision Log
| 
Revision Graph
Revision
1.73 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jan 30 21:53:10 2007 UTC
(2 years, 9 months ago)
by
wulff
Branch:
MAIN
Changes since
1.72: +24 -6 lines
Diff to
previous 1.72
# 89003 - clearing up installation instructions - thanks sun
# 99861 - URL restricted to 128 characters - thanks sun
#102676 - wrong placeholders used in t() - thanks ac
#102832 - blocks displaying though no banners are available - thanks ac/heine
#109245 - wrong status for week statistics - thanks plumbley
#114165 - no menu item for admin settings page - thanks pebosi
Revision
1.70.2.8 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jan 30 21:52:34 2007 UTC
(2 years, 9 months ago)
by
wulff
Branch:
DRUPAL-4-7
Changes since
1.70.2.7: +39 -7 lines
Diff to
previous 1.70.2.7
, to
branch point 1.70
, to
next main 1.74
# 89003 - clearing up installation instructions - thanks sun
# 99861 - URL restricted to 128 characters - thanks sun
#102832 - blocks displaying though no banners are available - thanks ac/heine
#109245 - wrong status for week statistics - thanks plumbley
#109325 - get size of remote banners - thanks plumbley
Revision
1.65 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jul 19 07:28:12 2006 UTC
(3 years, 4 months ago)
by
wulff
Branch:
MAIN
Changes since
1.64: +74 -51 lines
Diff to
previous 1.64
#71645 - Fixed queries in banner_cron() (scheduler integration still needs to be done)
#74130 - Fixed parameter name in cache handlers - thanks jrsturrock
#72762 - Missing target attribute on text banner links
#72767 - Problem with reporting of clicks per day/week/all time
#65378 - Minor additions to the docs - thanks js1
Revision
1.57 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Apr 9 11:07:19 2006 UTC
(3 years, 7 months ago)
by
wulff
Branch:
MAIN
Changes since
1.56: +64 -52 lines
Diff to
previous 1.56
#57881 - Remove border=0 from theme_banner_show - thanks dan_aka_jack
#55141 - Banners with no URL go to an empty page - thanks jlinares
#09895 - Add banner URL to link title - thanks njivy
#09903 - Define banner owner by name instead of uid - thanks njivy
Revision
1.52 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 15 13:03:00 2005 UTC
(4 years, 4 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.51: +4 -1 lines
Diff to
previous 1.51
- banner.module
o handle when banners configured for taxonomy but not enabled
- banner.mysql
o fix typo that prevented script from running
----------------------------------------------------------------------
Revision
1.51 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 26 19:00:24 2005 UTC
(4 years, 5 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.50: +153 -25 lines
Diff to
previous 1.50
5/26/2005:
- banner.module:
o add ability to display banners based on taxonomy
(sponsored by jo1ene at Advanced Web Design)
- new global configuration option to associate banners with one or more
vocabulary
- new per-banner configuration option to associate banners with one or
more taxonomy term
- add new dimension to cache structure to support terms
o make path to cache files relative
o convert some form_selects to form_radios
- banner.mysql:
o add new banner_term table for associating banners with terms
- banner_file.php
o support new banner cache format
----------------------------------------------------------------------
Revision
1.41.2.5 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed May 11 03:55:24 2005 UTC
(4 years, 6 months ago)
by
jeremy
Branch:
DRUPAL-4-5
Changes since
1.41.2.4: +52 -40 lines
Diff to
previous 1.41.2.4
, to
branch point 1.41
, to
next main 1.74
sync with HEAD, adding support for multiple cache files. (tested under
multiple Slashdotting, removes locking bottleneck providing much better
performance under a heavy load, and still retaining accurate display and
click-through statistics. 10 cache files was more than enough.)
- banner.module:
o remove "key" concept for cache files
o updated to support multiple cache files
o auto-create cache files on _settings page
- banner_file.php:
o complete rewrite, support multiple cache files to handle busy web servers
o auto-detect failure to read cache files, auto create as needed
o defaults to old-style with 1 cache file
o needs testing to determine if the number of cache files should be left
as a configurable, or if a sane default can be chosen
o issue #20805: add proper content-type header
- banner_db.php:
o issue #20805: add proper content-type header
Revision
1.49 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Apr 19 12:57:42 2005 UTC
(4 years, 7 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.48: +52 -40 lines
Diff to
previous 1.48
- banner.module:
o remove "key" concept for cache files
o updated to support multiple cache files
o auto-create cache files on _settings page
- banner_file.php:
o complete rewrite, support multiple cache files to handle busy web servers
o auto-detect failure to read cache files, auto create as needed
o defaults to old-style with 1 cache file
o needs testing to determine if the number of cache files should be left
as a configurable, or if a sane default can be chosen
o issue #20805: add proper content-type header
- banner_db.php:
o issue #20805: add proper content-type header
Revision
1.47 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Feb 19 18:07:14 2005 UTC
(4 years, 9 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.46: +4 -3 lines
Diff to
previous 1.46
o issue #15881: new 'add banner' permission required to for banner managers
to be able to upload new banners
o issue #15927: db_query updated to not send renewal reminder for banners
that never expire
Revision
1.46 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Feb 19 17:12:13 2005 UTC
(4 years, 9 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.45: +56 -30 lines
Diff to
previous 1.45
- banner.module:
o move file cache into standard (configurable) file path (out of misc/)
o verify banner_file.php and baner_db.php are properly installed
o utilize core file functions as much as possible when reading/writing
file_cache (no locking provided by core file functions, so we still have
to make some direct calls to fopen, flock and fclose. Also, when using
the file cache we don't have access to file.inc so we make all direct
calls.)
Revision
1.41.2.2 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Dec 23 04:14:44 2004 UTC
(4 years, 11 months ago)
by
jeremy
Branch:
DRUPAL-4-5
Changes since
1.41.2.1: +19 -17 lines
Diff to
previous 1.41.2.1
, to
branch point 1.41
- banner.module
o added support for auto-detection of progressive jpegs (thanks to
Alberto Gaiga for pointing out the need)
o added the ability to manually edit the auto-detected mime-type
o don't send notifications if a banner is disabled
- INSTALL
o added brief FAQ
Revision
1.41.2.1 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Nov 1 03:24:01 2004 UTC
(5 years ago)
by
jeremy
Branch:
DRUPAL-4-5
Changes since
1.41: +43 -43 lines
Diff to
previous 1.41
- banner.module
o allow drupal to handle menu permissions, fixing some buggy behavior
o use 'show banners' permission instead of nonexistant 'access banners'
Revision
1.42 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Nov 1 03:07:08 2004 UTC
(5 years ago)
by
jeremy
Branch:
MAIN
Changes since
1.41: +43 -43 lines
Diff to
previous 1.41
10/31/2004
- banner.module (Ryan Phillips)
o allow drupal to handle menu permissions, fixing some buggy behavior
o use 'show banners' permission instead of nonexistant 'access banners'
- README.txt (Jeremy)
o removed install directions, refer to INSTALL file
Revision
1.41 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Oct 30 19:46:56 2004 UTC
(5 years ago)
by
jeremy
Branch:
MAIN
Branch point for:
DRUPAL-4-5
Changes since
1.40: +15 -13 lines
Diff to
previous 1.40
- banner.module
o renamed 'position' to 'group' to be more clear on its purpose
o make banner_display() default to group 0
o display banner id on administrative banner overview page
o fix bug #12313: replace oudated call to _banner_show() with a call to
theme_banner_show()
o Drupal 4.5 compatibility: file->path became file->filepath,
file->type became file->filemime
- INSTALL
o rewritten to hopefully make the installation process more clear
- xtemplate.patch
o new example patch shows how to integrate the banner module into the
xtemplate engine. The patch offers examples with both 'bluemarine'
and 'pushbutton'.
Revision
1.40 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Oct 28 02:47:14 2004 UTC
(5 years, 1 month ago)
by
jeremy
Branch:
MAIN
Changes since
1.39: +7 -5 lines
Diff to
previous 1.39
- banner.module
o update to work with Drupal 4.5.0 (fixed _menu hook)
o auto create banner subdirectory if missing
o replace removed FILE_SEPARATOR with '/'
o make 'my banners' menu visible by default
Revision
1.38 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jul 26 16:06:59 2004 UTC
(5 years, 4 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.37: +326 -271 lines
Diff to
previous 1.37
- banner.module
o Fix bug #8736, don't generate anonymous/empty emails
o convert " to ' where logical
o add support for private images
o add support for custom image directory
o optionally generate notification email when user uploads new banner
Revision
1.25.4.9 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Apr 22 04:18:25 2004 UTC
(5 years, 7 months ago)
by
jeremy
Branch:
DRUPAL-4-4
Changes since
1.25.4.8: +2 -2 lines
Diff to
previous 1.25.4.8
, to
branch point 1.25
- banner.module
o patch by Michelangelo Partipilo:
"This solves a bug that was causing banner_cron to throw an error on
Win32/NT when expiration date was 0. I suppose it reported an empty
date on *nix."
(Affects notification mails for banners that don't have expiration date)
Revision
1.37 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Apr 22 04:16:35 2004 UTC
(5 years, 7 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.36: +2 -2 lines
Diff to
previous 1.36
- banner.module
o patch by Michelangelo Partipilo:
"This solves a bug that was causing banner_cron to throw an error on
Win32/NT when expiration date was 0. I suppose it reported an empty
date on *nix."
(Affects notification mails for banners that don't have expiration date)
Revision
1.32 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Mar 20 22:07:50 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.31: +61 -55 lines
Diff to
previous 1.31
- banner.module
o updated user pages:
- replaced custom menus with standard drupal menus
- admins can view all banners, or banners with a specific status
Revision
1.25.4.3 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Mar 20 20:41:45 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
DRUPAL-4-4
Changes since
1.25.4.2: +264 -73 lines
Diff to
previous 1.25.4.2
, to
branch point 1.25
- banner.module
o brought in changes from development branch:
- admin pages use tablesort
- reordered internal status values for proper tablesort functionality
(WARNING: this means you need to update all your banners when you
upgrade to this latest release)
- added new 'admin/banner/view' page to simply view banner info
- updated 'admin/banner/edit' page to allow editing of all fields
- banner_db.php, banner_file.php
o brought in changes from development branch:
- updated to properly use new internal status values
Revision
1.29 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Mar 20 13:24:15 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.28: +50 -24 lines
Diff to
previous 1.28
3/20/2003 (Jeremy Andrews) :
- banner.module
o replaced _banner_status_array() with _banner_status()
- returns text string rather than whole array
- reordered status values to make tablesort grouping logical
(WARNING: this means you manually need to update each banner
status after updating to this version of banner.module)
Revision
1.28 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Mar 19 23:43:43 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.27: +22 -13 lines
Diff to
previous 1.27
3/19/2003 (Jeremy Andrews) :
- banner.module
o convert banner admin page to use tablesort when displaying banners
o beginning to make admin pages more friendly / more functional
(these changes will be backported to 4.4 when fully finished)
Revision
1.27 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Mar 17 15:32:14 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.26: +3 -3 lines
Diff to
previous 1.26
3/17/2003 (Jeremy Andrews) :
- banner.module
o fix bug reported by Michelangelo Partipilo
(two instances of invalid db_query on nonexistent field)
(sync with DRUPAL-4-4)
Revision
1.25.4.1 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Mar 7 18:22:59 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
DRUPAL-4-4
Changes since
1.25: +5 -2 lines
Diff to
previous 1.25
- banner_db.php
o added necessary include_once bootstrap.inc
- banner.module
o update banner_link() to call banner_page() when a banner is clicked
o manually construct url from $base_url to work with non-clean urls
Revision
1.7.2.1 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Mar 7 17:03:00 2004 UTC
(5 years, 8 months ago)
by
jeremy
Branch:
DRUPAL-4-3
Changes since
1.7: +34 -34 lines
Diff to
previous 1.7
Mar 7 2004 (McGraw)
- banner.module (4.3 branch only)
o in SQL queries, wrap database table name in curly braces to
support db_prefix (Patch by "McGraw" -- fix already in
CVS/4.4 version)
Revision
1.13 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Dec 7 15:56:40 2003 UTC
(5 years, 11 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.12: +61 -42 lines
Diff to
previous 1.12
- wrap all tables in db_query with {}
- add auto-renewal-reminder email notifications
(reminds ad owners that their ad is about to expire, and that they
may wish to renew...)
- replace status() with drupal_message_set()
Revision
1.12 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Dec 7 15:01:54 2003 UTC
(5 years, 11 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.11: +32 -6 lines
Diff to
previous 1.11
- cleanup banner_settings using form_group()
- add help text on user page, explaining control panel
- display extra info in control panel (how long until expires, etc)
Revision
1.11 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Nov 29 17:15:53 2003 UTC
(6 years ago)
by
goba
Branch:
MAIN
Changes since
1.10: +28 -21 lines
Diff to
previous 1.10
enable translation of missing parts (in settings and banner admin page), add a hidden menu item to connect banner_page to the banner url, print out the page in the admin function as required by the current CVS, fix banner display on admin page, silence possible warnings and print out the JS as a local URL -> the module now works again with current CVS
Revision
1.6 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Oct 10 00:58:32 2003 UTC
(6 years, 1 month ago)
by
jeremy
Branch:
MAIN
Changes since
1.5: +30 -19 lines
Diff to
previous 1.5
syncronized with HEAD in preperation for 4.3 release:
- changed link type from "admin" to "system"
- return admin pages rather than displaying directly
Revision
1.5 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Oct 2 00:05:36 2003 UTC
(6 years, 1 month ago)
by
jeremy
Branch:
MAIN
Branch point for:
DRUPAL-4-2
Changes since
1.4: +4 -4 lines
Diff to
previous 1.4
cron logic resets daily counters and weekly counters. However, the logic said don't allow day counters to reset until '86400' seconds pass (24 hours), and don't allow week counters to reset until '604800' seconds pass (7 days). This caused the counters to be reset one hour later each day... I dropped 5 minutes from each so the counters are reset at the same time every day.
Revision
1.3 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Sep 27 17:11:43 2003 UTC
(6 years, 2 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.2: +3 -155 lines
Diff to
previous 1.2
- renamed banner_snippet() to banner_display()
- removed shared memory support (only 3% gain not worth supporting)
Revision
1.2 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Sep 27 16:49:53 2003 UTC
(6 years, 2 months ago)
by
jeremy
Branch:
MAIN
Changes since
1.1: +425 -29 lines
Diff to
previous 1.1
o fixed typo on admin page
o added fid column
o fixed admin % field to display actual percentage
o added database columns: day_views, day_clicks, week_views, week_clicks
o updates day_clicks and week_clicks
o banner_cron() resets day/week counters
o wrapped other banner_cron() in timestamp to limit DB DoS abuse
o added index to searched columns:
(fid, publish_date, unpublish_date, status)
o added indexed uid column to give banners owners
o added permission 'manage banners' allowing access to user banner page
o added 'pending' banner status (user uploaded, requires approval)
o added 'blocked' banner status (admin blocked, do not display)
o added 'denied' banner status (admin refused to approve)
o added simple (ugly) user page, can view stats and update banner status
-----
o user page fixes
- properly display banner status
- refresh cache when changing banner status
- properly update all banners if multiple
- prevent user from updating other than enabled/disabled banners
o update _cron to log to watchdog when auto-publish/unpublish
-----
o added watchdog entries ("special"):
- user enables/disables banner
- banner deleted
- banner blocked after reaching max_clicks
-----
o added support for user-controlled day_max_views and week_max_views
- added day_max_views and week_max_views to db banner table
- added fields to (even uglier) user page
o moved logic to reset day/week counters into _banner_refresh_cache
(this is required to support caching)
- introduced $param[] array to _banner_refresh_cache()
-----
o fixed bug in banner_delete, wasn't replacing %d with banner id
o created _banner_reset_counters function rather than duplicate code
- called from _banner_refresh_cache whether or not cache is enabled
(to be sure non-cached counters are reset too)
- only call _banner_refresh_cache once from _cron
o cleaned up user page (round one)
- moved each banner into own box
- added navigation box
- added status box
- added upload page
o added link to user banner page
-----
o added support for daily and weekly user banner summary emails
- added 'day_notify', 'week_notify' and 'failed_notify' database fields
- added banner_settings options to configure e-mails
- added _cron logic to send cache mails, sending at very end
- added functions 'banner_mail()' and '_banner_mail_text()'
- added logic to auto-disable user-notifications after n failed
attempts
-----
o removed blank line at end of module (broke rss feed)
o changed user page url 'banner/edit' to 'banner/view'
o added administrative user page 'banner/view/all'
Revision
1.1 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Sep 27 16:30:45 2003 UTC
(6 years, 2 months ago)
by
jeremy
Branch:
MAIN
banner module
+ different banners in the same page ("positions")
+ scheduling
+ count views and clicks
+ chance: stronger banners appear more frequently
+ set a limit to views and clicks
+ permission not to see banners
+ optionally uses shared memory for extra performance
+ uses javascript to have banner in cached pages too
+ a function to write the required javascript (_banner_snippet)
+ optionally set the format and size and don't use javascript (not useful)
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
select a symbolic revision name using the selection box, or choose
'Use Text Field' and enter a numeric revision.
