| /[drupal]/contributions/modules/coder/coder.module |
Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#607592 by japerry: - changed menu paths. - updated arguments to theme() function calls and definitions. - changed drupal_add_css/js calls to use #attached instead. - changed #markup theme() calls to use #theme. - coding style fixes. - added CHANGELOG.txt files
#571086 by sun: Updated for new function signature for form builder callbacks.
changed module paths
changed #filename and #filename-not to include the \. so it's not added by core coder.module to the regex.
fixed summary error count
fixed parsing of non php files
#483288 by Dave Reid - fix for drupal_get_page() warning.
menu description change
#477336 - changed menu definitions.
#477336 - fix coder settings page not appearing.
Improved patch reviewing - class and filename matching wasn't working.
Fix for different patch format parsing.
Fixed warning doc links, again.
Fix for php errors.
Fixed php errors when running one of the predefined reviews, e.g. 'core'.
#467862 - fix for documentation links being broken.
#271028 by douggreen, jcnventura - coder no longer tests for camelCase in classes.
made changes for drupal_get_form() and menu changes.
#466934 by John Morahan - fix for empty lines added in patches being lost.
#466934 by John Morahan - fix for empty lines added in patches being lost.
Changed menus.
#337809 - by scor, changed 'patches' to 'patch hunks' in status message.
#317254 - fix for undefined offset in array index, and fix for error caused when $warning['#link'] is not set.
coder re-org
Drupal 7 port.
Removed some trailing spaces.
#315447 - fix for broken "Drupal Docs" links.
#315447 - fix for "Drupal Docs" link not working
move coder_test from the module to the test case (and rename as runTest)
#311154 - add po file translation review
#314268 - fix initializing the new quote arrays
#314268 - change parsing of quotes to store multiple values per one line, this is the API change that required the 6.x-2.x version
fix the in_comment check to an exact check
fix the simpletest system so that the tests are returning (hopefully) correct results, but now many of the tests are broken
Fixed a couple of internationlization issues: +125: Menu item titles and descriptions should NOT be enclosed within t(). +1776: The $text argument to l() should be enclosed within t() so that it is translatable.
#311252 by John Morahan - ignore ?> in comments
fix case of "Selection form"
allow #filename-not => ''
#307876 from Dave Reid - make sure that code doesn't save all of the themes and modules to the variables table
#307877 - fix all E_NOTICE errors from unset variables, that were introduced in recent patches
#308412 - fix false positive on l(check_plain( ... and also reorganize tests a little
#304150 by Pasqualle and stella - don't start t() with a space
fix bug, use our own cache table
use our own cache table
add new command line argument to just check contrib
#281399 by hailu and me - commit simpletest framework and the first few tests
change include_once to include based on Ras's talk at DrupalCon
add check in menu system based on DrupalCon talk by chx and pwolanin
better handling for missing files
Change a few text strings to follow sentence capitalization.
#296777 by morbus - add file exclusions to the include files
#185373 - added in new feature to review patch files (Stella), added #filename and #filename-not directives for rules (Doug), added coder drush support for reviewing patches (Doug).
fix the 6.x drush upgrade
#281670 - fix for code review links not appearing.
The Drupal coding standards (http://drupal.org/coding-standards) says that all pre-defined PHP constants (e.g. null, true, false) should be in uppercase. I've added a check for this to coder_style.inc and fixed instances of it in the coder code.
The Drupal coding standards (http://drupal.org/coding-standards) says that all pre-defined PHP constants (e.g. null, true, false) should be in uppercase. I've added a check for this to coder_style.inc and fixed instances of it in the coder code.
#263783 by webchick - fix php warning
#258391 - Fixed issue introduced by typo in earlier patch.
#180226 - added Doug's patch for warning about accessing array elements without the quotes.
#180226 - added Doug's patch for warning about accessing array elements without the quotes.
#222672 - added in Doug's patch to allow coder run the trailing space check on blank lines.
#222672 - added in Doug's patch to allow coder run the trailing space check on blank lines.
#212405 - removed t() calls from menu items' titles and descriptions (D6 change).
#245774 - fix for error appearing on modules confirmation page.
#240301 - fix reference to theme function that was renamed
add check for missing modules, standardize theme_cols
add check for missing modules, standardize theme_cols
change drush ignore syntax
change drush ignore syntax
forward port some drush changes
implement summary option for drush
show errors/status messages in drush
add severity settings to drush command line, add drush command line help
add severity settings to drush command line, add drush command line help
fix include of coder.drush.inc
fix include of coder.drush.inc
add support for drush
add support for drush
#212388 - restore processing of .schema files
#212388 - remove processing of .schema files
#212388 by webchick - review .test files
#212388 by webchick - review .test files
#226403 - add a simple help to the admin/settings/coder page - slight change to the text
#226403 - add a simple help to the admin/settings/coder page
#226403 - add a simple help to the admin/settings/coder page
#219417 - forward port 5.x count fix to 6.x
#219417 by csevb10 - fix error counts
remove some extra spaces, change the trailing spaces error to severity=minor
#200880 - added php function documentation based on ezyang's work for the 6.x version.
Couple of commenting fixes.
remove trailing spaces
remove trailing spaces
#212390 by webchick - remove include of schema files
#210828 - add if ($may_cache) to hook_menu
#207830 by grugnog2 - Fix $_POST hack in form submission
#207830 by grugnog2 - Fix $_POST hack in form submission
#200880 by ezyang, snpower - comment coder according to doxygen and Drupal standards
fix the calculation of the column totals in theme_coder_checkboxes
fix the calculation of the column totals in theme_coder_checkboxes
theme modules and themes in 3 rows for easier viewing/checking
theme modules and themes in 3 rows for easier viewing/checking
#203060 by webernet - update core modules list for 6.x
fix #never 'continue'
fix #never 'continue'
add #never flag so we can prevent matches of <?php on lines that don't indent properly
add #never flag so we can prevent matches of <?php on lines that don't indent properly
#173508 - replace basename with filename in drupal_system_listing
#173508 - replace basename with filename in drupal_system_listing
#199847 - fixed uninitialized variable warnings
#173508 - fixed issue where there was no checking on install file when a schema file was present, etc.
#173508 - fixed issue where there was no checking on install file when a schema file was present, etc.
#180235 by snpower
#180235 by snpower
#177246 - Correct api.drupal.org links
#177246 - Correct api.drupal.org links
the coder cache is not longer "experimental" so remove this word from the settings form
the coder cache is not longer "experimental" so remove this word from the settings form
correct name of sql review, and add it to the defaults
correct name of sql review, and add it to the defaults
only display link to review help if it exists
only display link to review help if it exists
fix 'Code Review' html on admin/build/modules page, that had a dangling div
fix coding style violation involving quoted strings
doh - moving the current development from DRUPAL-5 to DRUPAL-5--2
#107453 - fix link on admin/build/modules
#107453 - fix link on admin/build/modules
#167029 - fix bug replacing titles on admin/build/modules
#167029 - fix bug replacing titles on admin/build/modules
check schema files too
check schema files too
fix php E_ALL error
#107453 - make the coder link on the system admin page more visible
#107453 - make the coder link on the system admin page more visible
fix sorting by line numbers
fix sorting by line numbers
#157581 - bug found by Steven - only look for trailing ?> outside quotes
#157581 - bug found by Steven - only look for trailing ?> outside quotes
add support for rules #link
add support for rules #link
fix bugs found while reviewing 6.x
add new core modules to list of core modules
more 6.x porting
fix check for #function
fix check for #function
#156638 - fix #submit handler that was broken when upgrading to 6.x, the #submit handler changes were accidentally backported
fix check for last modified time
fix check for last modified time
get coder working again on 6.x head (more)
get coder working again on 6.x head
fix use of cache functions
#148417 - display statistics about number of files and errors
#148417 - display statistics about number of files and errors
don't use hook_init - this was inefficient (init'd on every page) and prevents code from running with aggressive caching installed, refactoring this code actually made it simpler too!
don't use hook_init - this was inefficient (init'd on every page) and prevents code from running with aggressive caching installed, refactoring this code actually made it simpler too!
sort the modules and themes in the selection form
sort the modules and themes in the selection form
sort the review names in the selection form
sort the review names in the selection form
add 'comment' #source and implement first rules for comments
add 'comment' #source and implement first rules for comments
fix function check check .install files
check .install files
fix _submit handlers that use form_state - I accidentally backported this from the 6.x version
backport changes from HEAD
fix additional E_ALL error
coder re-upgraded to current version of 6.x (CVS HEAD)
port 5.x updates to 6.x
write the bulk of the 6.x upgrade rules at the CivicActions engineering co-working session, with help from the whole team. An additional patch in the issue queue will handle FAPI changes.
#140150 - the space is optional before a heredoc name
#140150 - the space is optional before a heredoc name
#121388 by sun - fix bug in _coder_search_string
#121388 by sun - fix bug in _coder_search_string
add #function to regex processing to limit searches to a function
add initial coder_6x review
doh - fix syntax error from last checkin
remove 5.x menu code from HEAD/6.x branch
remove D6 menu code from D5 branch (D6 development is now in HEAD).
update to work with 6.x theme registry and hook_form_alter changes
copying DRUPAL-5 to HEAD for D6 development
#126938 by sun - add coder_format script to be distributed with cod coder_format implements an alternative solution to formatting source code
improvements to performance review; and ... eating my own dogfood - fixes to coder module based on output of performance review.
when form_alter'ing a form using confirm_form, make sure that you're not in the confirm form portion of the form. I didn't know that this happened, I'm going to have to check every place I form_alter for this one!
improve new warning descriptions to theme nicer and moved the js code to the .js file
add messages/descriptions to improve the user experience
#121388 by sun - more performance reviews, better styling of error and display of descriptions, and some performance enhancements within the coder code - Thanks!
fix admin/settings/coder not getting default modules and themes
add additional permission for "all" review, mainly so that it can't be run on my test site (it's a resource hog)
#109875 - add support for All
more E_ALL changes for D6
add support for themes
Implement tabs; clean up text, defaults, and selection form; fix minor bugs
First attempt to make D6 compatible: fixes a few E_ALL warnings implements D6 menu (uses VERSION to decide which ones to create)
#109875 - when selecting core, also review top level php and includes
invalidate the cache when the code is updated -- this is going to help avoid alot of headache when people upgrade versions
#118872 - use title that hints about options used #118866 - add images to display severity
#118880 by webchick - add help to coder page
#118866 from webchick - add severity to warning message
change coder_cache default to 1
#118865 from webchick - fix menu names
add experimental cache option that dramatically improves performance
copy new UI from HEAD
*** empty log message ***
add css styling to severity levels; fix bug that displayed 'minor' warnings when level was 'normal' or higher;
#114711 - implement rule severity and user option
significant UI improvements that: moves the settings form to coder page display of warnings in fieldsets
copy from D5 branch and add experimental UI using forms
remove D4.7/5 check for system_listing
#107608 by webchick - hook_help isn't needed in 5.x
#110170 - fix "active" links on settings page
#110170 - fix "active" links on settings page
#109386 from webchick - add link to warning about info files; fix t() with links per http://api.drupal.org/api/HEAD/function/t;
#107448 - add <<< processing; add rules for <br> and uppercase XHTML; move includes/tests to tests and move coder_drupal.inc coder_style.inc;
#108849 reported by add1sun - because coder was not properly handling multi-line quotes, had to significantly overhaul the parsing, which should be more accurate and much faster now, and also adds the capability to check html.
not my night - one more change to affect menu change from admin/coder to coder
replace all paths with coder instead of admin/coder
#107434 from webchick - move from admin/coder menu to coder
Fix #107642 that was introduced by the fix to #107391 - proper display of links in warnings
Fix #107444 from webchick - only perform regex rules on php, not html - skip characters between ?> <?php
Fix #107617 reported by oadaeh - display multiple errors from same line
Fix #107598 - oops, broke this earlier today with #107172 fix.
#107607 from webchick - remove redundant permissions check
#107430 from webchick - allow globals defined in the Drupal 5 modules directory
#107391 by webchick - Display relevant line of code with error. I reworked the patch and added an option setting to disable. Thanks for suggesting this, it's a great addition!
fix #107172 - if the user supplied argument was not a valid module, it performed a review of every .inc file under the Drupal directory - a major system hog, to say the least
implement better stdclass rule; fixed case-insensitive check that was accidentally removed; started a tests folder and added a couple of style tests
fix rules in drupal coding standards: 1. camelcase should allow stdClass - http://drupal.org/node/106585 2. allow global variable names from core 3. fix check for extra spaces between the function name and parenthesis added #not rule to facilitate above
remove #case option, instead use regex (?-i) for case sensitive matches
better handling of multi-line strings that will allow us to catch errors on the same line as the trailing quote.
handle multi-line strings - http://drupal.org/node/106493
thanks to yched! fixing the string concatenation rule http://drupal.org/node/106411
use php variable functions for version specific function usage (cleaner code requires only one usage of the function and is less likely to be buggy).
Use sentence capitalization instead of Case Capitalization
fix php4 error - http://drupal.org/node/106097
improve rule warning's to include links to the approriate drupal api functions; this is actually a major overhaul of the rule warning system -- implementing a #warning_callback option and moving the t() processing out of the rule.
better comment about my break from the string concatenation style suggestion
fix quote/string processing to handle escaped quotes
Add TODO comment (this is the source of the false positives in coder_47.inc)
alter theming of results with link to full results page on summary page; fix false warning; fix misspelled word;
changed do_coder_review args to array for more flexibility; added upgrade50 check for .info file
Fix default review values
display partial paths
fix php pass-by-ref deprecate warning by using call_user_func_array()
Backout attempt to display partial paths, because of bugs
support 4.7 and 5 with single code base
Remove unnecessary unset
Fix _coder_default_reviews to return checked status
Tighten up the logic for finding includes, avoiding getting entries outside of the file subpath
Implement camel case check
Add #original tag to distinguish between using $lines and $orig_lines; Add security warning about $REQUEST_URI
Let preg_replace handle array of lines when possible; Replace quoted strings with empty strings, to avoid false positives
Fix bug in new comment processing; Add a few more Drupal coding styles; Remove #coder_ignore in preparation for better string handling
Strip comments so we get fewer false positives
don't handle includes when doing the full list -- it takes too long fix display of <? ?> in coder_drupal.inc
Prevent processing of same include file more than once
Perform code review on include files Add #coder_ignore directive Remove ?> from include files
Add for to control structures list Look for trailing ?> (probably unnecessary because CVS strips this from modules)
Link to coder page from coder module settings
Add first cut at security callback (not functional at all)
Sort warnings by line number
Theming changes
Implement most of Drupal Coding standards
Theme coder_line Minor mods to rule definitions getting ready for other types
add link to system_modules form add access denied message to page
Recommitting to HEAD tag
Removing coder files that were inadvertantly checked-into the DRUPAL-4-7 tag instead of the HEAD tag... hopefully CVS will let me recreate this project starting with HEAD
add argument processing to support admin/coder/modulename
Developer Module that assists with code review and version upgrade that supports a plug-in extensible hook system so contributed modules can define additional review standards. Built-in support for: - Drupal Coding Standards - http://drupal.org/node/318 - Converting 4.6.x modules to 4.7.x - http://drupal.org/node/22218 - Converting 4.7.x modules to 5.x - http://drupal.org/node/64279 - Handle text in a secure fashion - http://drupal.org/node/28984
file coder.module was initially added on branch DRUPAL-4-7.
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, select a symbolic revision name using the selection box, or choose 'Use Text Field' and enter a numeric revision.
| ViewVC Help | |
| Powered by ViewVC 1.1.2 |