Log of /contributions/modules/filefield/filefield.module
Parent Directory
| 
Revision Log
| 
Revision Graph
Revision
1.201 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 3 20:38:13 2009 UTC
(4 months, 3 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.200: +12 -12 lines
Diff to
previous 1.200
#494176 by catch: Less restrictive hook_file_download(), check access on all nodes containing a file before denying access.
Revision
1.191 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Apr 12 20:37:37 2009 UTC
(7 months, 2 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.190: +118 -31 lines
Diff to
previous 1.190
#369560 and #380200: New APIs for retreiving a list of files within a node, and the inverse of retreiving a list of nodes that reference a file.
Revision
1.190 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Apr 12 19:14:02 2009 UTC
(7 months, 2 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.189: +11 -1 lines
Diff to
previous 1.189
#366434 and #430196: FileField specific Views support, adding the "list" filter and the "data" field.
Revision
1.185 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Mar 30 01:19:34 2009 UTC
(7 months, 4 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.184: +43 -2 lines
Diff to
previous 1.184
#417774: Add Public FileField API Functions and fix field_file_references() to not be field specific.
Revision
1.171 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Mar 11 03:29:40 2009 UTC
(8 months, 2 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.170: +2 -2 lines
Diff to
previous 1.170
#367267: Reverting line needed for multigroup support, since it breaks groups until the multigroup patch is applied.
Revision
1.168 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Mar 11 01:41:58 2009 UTC
(8 months, 2 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.167: +7 -67 lines
Diff to
previous 1.167
#397578: Uncouple ImageField from custom FileField hooks. Implement ImageField as a dependent widget for FileField.
Revision
1.165 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Mar 1 05:17:37 2009 UTC
(8 months, 3 weeks ago)
by
quicksketch
Branch:
MAIN
Changes since
1.164: +5 -1 lines
Diff to
previous 1.164
#387194: Major FileField UI Refactoring. Putting File info side-by-side the preview, hiding fields that are unnecessary before uploading a file.
Revision
1.163 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Feb 5 19:54:43 2009 UTC
(9 months, 2 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.162: +13 -6 lines
Diff to
previous 1.162
#303286 by dopry, drewish, moonshine, Add field to file during validation so it is available during hook_file_insert.
Revision
1.155 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Nov 16 06:57:21 2008 UTC
(12 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.154: +3 -2 lines
Diff to
previous 1.154
#334468 by Sutharsan, cck/content_admin.inc not found during update.php. applied to head tnx.
#295620, Call to undefined function field_file_load().. decided to include field_file.inc at a global level.
Revision
1.142 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Aug 11 21:00:07 2008 UTC
(15 months, 2 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.141: +2 -1 lines
Diff to
previous 1.141
dodge devel.module errors... I still really hate that I can't send the application/javascript content type..
I'm gonna track that bug down one day.
Revision
1.139 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Aug 11 18:50:10 2008 UTC
(15 months, 2 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.138: +15 -23 lines
Diff to
previous 1.138
#286834 by quicksketch and dopry, so AHAH was in place... If you're using ahah make sure your wrapper id exists,
otherwise stuff can be a real mess. Also the jQuery form plugin does file submission in an iFrame and you can't
trust the post in the network console. I had to put the ahah wrapper in #prefix/#suffix and they have to be
overridden in the JS callback to prevent duplicate div wrappers appearing... I kind of wish ahah replaced it's
wrapper rather than inserting inside the wrapper. ce la vie. but here is working JS upload and remove.
Revision
1.133 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jul 30 18:02:41 2008 UTC
(15 months, 3 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.132: +18 -3 lines
Diff to
previous 1.132
#288426 by drewish, Imagefield doesn't validate image resolution. with modificcation.
we're going to simple require that each validation callback require a matching help
callback. I don't even want to bother with function exists.
added help callback for core file_validate_image_resolution callback.
added node_form_submit_build_node which snuck in there but was needed anyway...
Revision
1.131 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jul 23 14:44:39 2008 UTC
(16 months ago)
by
dopry
Branch:
MAIN
Changes since
1.130: +25 -3 lines
Diff to
previous 1.130
#286144 by Moonshine with modifications. Set default values for CCK properly. Issues remain with 'Add a new item' on
unlimited value fields.
Revision
1.130 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jul 23 00:05:30 2008 UTC
(16 months ago)
by
dopry
Branch:
MAIN
Changes since
1.129: +5 -5 lines
Diff to
previous 1.129
updating list option settings a little... adding list options update to .install...
merging all drupal 6 updates into a single update function...
Revision
1.128 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Jul 17 04:54:15 2008 UTC
(16 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.127: +5 -3 lines
Diff to
previous 1.127
beginning to restore ahah magic... need to figure out the change from the old multiform callback,
and the current widget system....
Revision
1.125 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jul 16 16:35:00 2008 UTC
(16 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.124: +11 -10 lines
Diff to
previous 1.124
initialize data as array, and deserialize on item load, since the 'serialize' flag in the schema
only works on the way in.
Revision
1.121 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jul 15 04:26:36 2008 UTC
(16 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.120: +4 -5 lines
Diff to
previous 1.120
remove after_build...
add pass through to {$element['#type']}_widget_{$callback} to filefield_widget_{$callback}'s
imagefield now completely extends filefield... and filefield can use the imagefield widgets...
dirty promiscuous widgets...
Revision
1.118 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jul 14 23:29:39 2008 UTC
(16 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.117: +17 -5 lines
Diff to
previous 1.117
adding initial widget development notes.
remove some debug code...
add field_settings callback implementations.
Revision
1.117 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jul 14 20:09:19 2008 UTC
(16 months, 1 week ago)
by
dopry
Branch:
MAIN
Changes since
1.116: +23 -4 lines
Diff to
previous 1.116
hook_widget_settings merge code for filefield widgets.
allows modules to simply call filefield_widget_settings($op, $wiget)
and implement {$widget_type}_widget_settings_{$op} callbacks.
filefield_widget_settings will try to dynamically include {$module}_widget.inc
so you can put the settings outside your module as desired.
Revision
1.108 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jul 7 08:56:34 2008 UTC
(16 months, 2 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.107: +2 -1 lines
Diff to
previous 1.107
move initialization of update_name to be fore it is first used.
add data column to file fields for widgets to store serialized data per item. (display settings, transform settings, etc).
Revision
1.107 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jul 7 05:50:32 2008 UTC
(16 months, 2 weeks ago)
by
dopry
Branch:
MAIN
Changes since
1.106: +11 -24 lines
Diff to
previous 1.106
update hook_file implementation to reflect modt recent core hook_file path with callbacks per $op.
add field_file_references($file, $field) to load references by field.
rename $item['filefield_delete'] to more descriptive $item['field_name'].
Revision
1.105 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Jul 3 17:38:39 2008 UTC
(16 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.104: +50 -2 lines
Diff to
previous 1.104
#183864, #277943: File size restrictions.
Extensible via hook_filefield_filesize_restrictions(), used for
displaying the upload form as well as for validating the actual uploads.
And of course, this comes with the new per-file and per-node file size
restriction "examples".
Revision
1.100 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 29 20:04:34 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.99: +130 -947 lines
Diff to
previous 1.99
Filefield was becoming too large, so let's split it up.
filefield.formatter.inc and filefield.theme.inc work completely
with declarational 'file' properties in the various hooks,
whereas filefield.widget.inc still needs to be included manually.
Revision
1.99 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 29 18:26:54 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.98: +28 -19 lines
Diff to
previous 1.98
Reorder ($field, $file) parameters to ($file, $field), as I already
stumbled over a few instances where the former is suboptimal.
Also, pass possible file formatter settings to the theme function.
Revision
1.98 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 29 17:14:42 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.97: +3 -3 lines
Diff to
previous 1.97
Oh right, and remove the $info parameter from the widget specific hook,
we don't need that as it's given in the function name anyways.
Revision
1.97 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 29 17:12:37 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.96: +75 -29 lines
Diff to
previous 1.96
Remove the generic widget settings form_alter hook in favor of
multiple file widget specific ones. In tandem with that, add
file formatter settings to the field settings. Let's see if it works.
Also, make hook_file_widget_info() more like hook_file_formatter_info()
so that the array key doesn't specify the form element but is merely an
arbitrary key, with the need to be unique only inside each module.
Revision
1.96 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 29 14:50:16 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.95: +310 -56 lines
Diff to
previous 1.95
Next major stroke, admin UI: make file widgets and formatters sortable
and have a checkbox to enable/disable them.
The latter comes with additional functionality in terms of a validator
that only accepts files when any enabled widget handles it.
a.k.a. easy mimetype based upload restrictions. Makes it a breeze
to have image-only filefields without specifying the allowed extensions.
Revision
1.95 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 28 20:53:40 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.94: +26 -25 lines
Diff to
previous 1.94
Move filefield_check_directory() next to filefield_file_upload(),
which is the only place where it's actually used.
It had kind of an orphan status further down, which I didn't like.
Revision
1.92 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jun 27 23:36:31 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.91: +218 -47 lines
Diff to
previous 1.91
Take modularization a step further, expanding it to formatters as well.
Also, for consistency, files are converted to objects (and back, in case)
every time they are passed to other modules.
Plus the usual minor cleanups and documentation fixes.
Revision
1.90 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jun 27 18:29:59 2008 UTC
(16 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.89: +2 -2 lines
Diff to
previous 1.89
Seems like using '#value' in the process callback is not such a good idea,
let's rather use '#default_value' where I stored the file.
Revision
1.87 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Jun 26 10:41:28 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.86: +2 -2 lines
Diff to
previous 1.86
content_field_form() doesn't reference but only alter the form
which the widgets are added to. Therefore, the original unbuilt form
should be passed, not the built one that is going to be scrapped.
Revision
1.85 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 25 19:43:01 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.84: +9 -1 lines
Diff to
previous 1.84
Fix the "AHAH behavior not attached after replacement of the element" bug.
Thanks to yched for a hint into the right direction (form_clear_id())
and fago for bringing to my attention that script tags can also be
inserted in the HTML body and are executed instantly.
Take that, JavaScript! Hah.
Revision
1.84 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 25 19:09:07 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.83: +38 -17 lines
Diff to
previous 1.83
#274791: Validate empty upload fields on '#required' == TRUE.
Also (which took far more time), change the AHAH callback so that it gets
its replacement element from CCK instead of constructing it directly.
Not only does that merge stuff like '#required' into the element but
it also gets rid of a theming bug. That's how I like it :)
Revision
1.83 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 25 09:42:01 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.82: +6 -8 lines
Diff to
previous 1.82
Use filefield_view_access() also in hook_file_download(), so that
the same objective isn't coded twice. As a downside, doing it this way
will not squeeze every last inch of CPU cycles out of this loop. Whatever.
Revision
1.82 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 25 00:25:49 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.81: +3 -5 lines
Diff to
previous 1.81
You know what, let's make use of the view access function in the formatter.
CCK checks for itself before calling it, but who knows how it gets abused
in evil other ways, so let's be prepared for that situation.
Revision
1.81 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 23:51:28 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-6--1-0-ALPHA2
Changes since
1.80: +17 -4 lines
Diff to
previous 1.80
Add a filefield_view_access() function so that themers can check if they
should display a file or not, in case they're not using the regular
CCK formatters. Since I removed the access check from theme_filefield(),
this function's premier use is probably to salve my conscience.
Revision
1.79 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 23:26:48 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.78: +3 -3 lines
Diff to
previous 1.78
Write some lyrical watchdog notifications in case uploading a file fails
for whatever reason. Not that I like writing such text, but hey, these
were the last two @todo items in filefield.module. Coolio.
Revision
1.78 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 23:00:08 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.77: +79 -21 lines
Diff to
previous 1.77
Better permission checking for private file downloads.
The even better news is that I've been able to get completely rid
of the annoying 'view filefield uploads' permission by replacing it
with the more fine-grained field-level permissions from content_permissions
which ships with CCK 6.x.
The new code makes our hook_file_download() a bit more complex,
but on the other hand only cares about files that are actually
contained in at least one file field. Yay for correctness and flexibility!
Revision
1.77 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 20:16:55 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.76: +17 -10 lines
Diff to
previous 1.76
* Make uploads work for users != user 1. eheh. well.
* Use an error string similar to what Drupal core is using.
* Passive JavaScript errors (in a red error box) instead of alert().
Revision
1.75 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 18:33:02 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.74: +61 -63 lines
Diff to
previous 1.74
* Lots and lots of CSS finetuning. I believe I can't make it any better
than this, only CSS gurus should be able to improve it even more.
* On the coding side, file edit widgets are now real form elements.
That means no buttons for such widgets, but instead they can come up
with their own value callbacks and widget theme functions.
Plus I now have them in their walled garden where they belong.
Revision
1.74 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 24 14:38:34 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-6--1-0-ALPHA1
Changes since
1.73: +164 -128 lines
Diff to
previous 1.73
AHAH uploads and deletions.
Includes a bit more modularization of the uploading/deletion code.
Known bugs:
* Uploads work in Firefox but not in Konqueror, that is a regression
compared to the D5 version. An ahah.js bug? (Drupal isn't even invoked.)
* The AHAH submit-replacement behaviour won't attach to the new form,
it seems. I experienced the same thing with the CCK "add more" button,
let's have a look what goes wrong there.
Revision
1.73 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 23 20:06:20 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.72: +6 -7 lines
Diff to
previous 1.72
Bugfix time:
* Re-add '#name' properties for the buttons, so that the right one
is selected on submit.
* Scrap the broken condition (using a wrong, previous variable name)
so that the replaced file is added to the form state again on uploading.
Revision
1.72 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 23 18:29:23 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.71: +207 -186 lines
Diff to
previous 1.71
* Move non-button elements to the respective container form elements.
That way we can encapsulate as much as possible, and that's good for
grouping the code. Consequently, widget code order is now sane at last:
first comes hook_widget() which decides between upload and edit widget,
then comes the upload widget, and then comes the edit widget.
Finally some structure where I immediately find stuff.
* Move file uploading from the value callback to the submit callback.
I'm pretty convinced that we don't want to upload selected files
if *any* button is pressed (not just the "Upload" button).
* Rename $fieldname to $field_name, like used in core CCK code.
Revision
1.71 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 23 09:20:33 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.70: +4 -2 lines
Diff to
previous 1.70
Refine the CSS, getting rid of unnecessary bottom margin in Konqueror.
Nice side effect: more filefield-classed divs for detailed themeability.
Revision
1.70 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 23 08:27:19 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.69: +19 -19 lines
Diff to
previous 1.69
Views 2 integration. Now that was easier than I expected -
by defining a relationship to the {files} table, we get all
the file filters for free. That's pretty neat.
Revision
1.68 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 22 07:19:34 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.67: +2 -28 lines
Diff to
previous 1.67
* Make the formatter part of the 'force_list' option work again.
* Remove some more code that we most probably won't need anymore.
Revision
1.65 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 21 18:19:45 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.64: +44 -212 lines
Diff to
previous 1.64
* Throw out lots of legacy code
* Comment out the stuff that still has to be ported
* Include the max filesize label from the D5 version
* Add a new token for the formatted filesize (e.g. 7.34 MB)
Revision
1.64 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 21 17:36:06 2008 UTC
(17 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.63: +146 -138 lines
Diff to
previous 1.63
* Make the parent widget of the edit form a custom container element,
so that we can have a nice value callback in order to separate
form structure and result value (as CCK widgets are inside a '#tree').
* Convert filefield back to CCK multiple value handling, replacing the
"Delete" checkbox with a "Delete" button and storing the previous file
as temporary property of the new one, until the node is submitted.
Revision
1.63 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 18 21:06:43 2008 UTC
(17 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.62: +165 -68 lines
Diff to
previous 1.62
Perfect multiple-value handling due to implementing a custom
multiple value widget. This was actually quite a bit of effort
due to the "replace uploads for single value widgets" special case.
I probably also fixed some bugs along the way, the one that I can
actively think of is cleaning up hook_field($op='insert','update')
so that it doesn't try to save deleted files.
Revision
1.62 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 18 17:27:46 2008 UTC
(17 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.61: +50 -50 lines
Diff to
previous 1.61
Move filefield_widget_settings() below filefield_widget_info(), for better
consistency with filefield_field_{setttings,info}(). Might screw up
the CVS history, but I can hardly find my way around the module anymore
without searching, so something needs to change.
Revision
1.61 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 18 17:23:45 2008 UTC
(17 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.60: +153 -120 lines
Diff to
previous 1.60
It seems to me that the "Upload" button was not recognized by the Forms API
because it was only generated inside an element process function.
Fix that by going back to a more imagefield like approach, but not quite -
upload and editing widgets are now separated, with the upload widget only
returning the fid. The combined form element is now gone, and the widget
is directly composed in filefield_widget().
Bonus feature (on the way to deprecating imagefield): other modules can now
provide their own replacement edit forms, with priority based ranking of
which one is used. Might need a bit of work, but it's a good start.
Revision
1.59 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 18 09:48:39 2008 UTC
(17 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.58: +374 -366 lines
Diff to
previous 1.58
#269073 by Crell and jpetso: Initial Drupal 6 port of filefield.
Don't expect anything usable yet - it works, but still has a long way to go.
Thanks a lot to Crell for getting this thing rolling.
Revision
1.58 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 10 14:08:38 2008 UTC
(17 months, 2 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.57: +469 -176 lines
Diff to
previous 1.57
Argh, I did *not* resync all files from DRUPAL-5--2 to HEAD?
Why is that? Bah. [insert random cursing]
So at least now everything should be in sync again.
Revision
1.50.2.40 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jun 3 01:46:40 2008 UTC
(17 months, 3 weeks ago)
by
jpetso
Branch:
DRUPAL-5--2
CVS Tags:
DRUPAL-5--2-3
Changes since
1.50.2.39: +176 -12 lines
Diff to
previous 1.50.2.39
, to
branch point 1.50
#196957 by myself: Add icons to default filefield formatters,
And because we want a sane method for icon retrieval if it's
that exposed, this patch comes with a rather large improvement:
freedesktop.org icon naming specification compliant usage of icon names
and fallback algorithms. Not exactly like the desktops do it, but close.
Revision
1.50.2.38 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 2 23:54:02 2008 UTC
(17 months, 3 weeks ago)
by
jpetso
Branch:
DRUPAL-5--2
Changes since
1.50.2.37: +41 -5 lines
Diff to
previous 1.50.2.37
, to
branch point 1.50
Workaround (or partial fix, if you prefer) for #180023:
Display the maximum possible file size for file uploads,
so that users at least have a clue why uploads might not work.
In the process, also take the '<br/>' being out of the t() function.
Revision
1.50.2.36 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue May 27 08:50:27 2008 UTC
(18 months ago)
by
jpetso
Branch:
DRUPAL-5--2
CVS Tags:
DRUPAL-5--2-3-RC4
Changes since
1.50.2.35: +26 -4 lines
Diff to
previous 1.50.2.35
, to
branch point 1.50
#236059, original imagefield patch by dopry, ported by myself: Support node revisions.
So that works, but now there's a different bug that doesn't get
empty filefields back when reverting from a non-empty filefield revision.
But well, that might just be the lesser of both evils.
Revision
1.50.2.28 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Mar 9 19:26:24 2008 UTC
(20 months, 2 weeks ago)
by
dopry
Branch:
DRUPAL-5--2
Changes since
1.50.2.27: +13 -11 lines
Diff to
previous 1.50.2.27
, to
branch point 1.50
commiting icons provided by yoroy... the icon selection is totally hackish now.. I've got some more
free desktop style icon naming in the pipeline, but I am going to wait till another version to add it
so I don't mess up existing sites running on the RC any more than necessary.
Revision
1.50.2.16 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jan 23 07:46:30 2008 UTC
(22 months ago)
by
dopry
Branch:
DRUPAL-5--2
Changes since
1.50.2.15: +17 -15 lines
Diff to
previous 1.50.2.15
, to
branch point 1.50
fix widget settings validation for extension.
#182132 by smithda5, fix required filefield validation. was throwing an error if items was empty on an initial node form submit.
clean up nesting and deleted items counting in validate as well. good thing TRUE == 1 in php.
Revision
1.50.2.9 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Jan 22 23:28:15 2008 UTC
(22 months ago)
by
dopry
Branch:
DRUPAL-5--2
Changes since
1.50.2.8: +0 -0 lines
Diff to
previous 1.50.2.8
, to
branch point 1.50
adding initial version of filefield_meta to the repository with basic height/width/duration detection.
@todo: add more fields (author, license, copyright, etc), need to look at different common meta tags.
@todo: views filter integration.
Revision
1.50.2.5 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Dec 5 17:10:18 2007 UTC
(23 months, 3 weeks ago)
by
jpetso
Branch:
DRUPAL-5--2
Changes since
1.50.2.4: +19 -29 lines
Diff to
previous 1.50.2.4
, to
branch point 1.50
Remove the "Show 'List' option" widget setting, and replace it
by an "Always list files" field setting (= !$show_list).
No upgrade path (yet?) - it's not possible to have a universally applicable
upgrade path, but most people probably don't use different widget settings
in different instances of that field... so, I'll try a heuristic solution.
Scheduled for the next commit, that is.
Revision
1.56 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Dec 5 17:09:03 2007 UTC
(23 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.55: +19 -30 lines
Diff to
previous 1.55
Remove the "Show 'List' option" widget setting, and replace it
by an "Always list files" field setting (= !$show_list).
No upgrade path (yet?) - it's not possible to have a universally applicable
upgrade path, but most people probably don't use different widget settings
in different instances of that field... so, I'll try a heuristic solution.
Scheduled for the next commit, that is.
Revision
1.51 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Sep 25 15:30:21 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.50: +4 -1 lines
Diff to
previous 1.50
We introduced the 'view filefield uploads' permission, so use it not only
in hook_file_download() but also in the formatter.
Revision
1.49 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Sep 3 12:40:29 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.48: +11 -10 lines
Diff to
previous 1.48
#136715 by Egon Bianchet and the remains of #140901 by sirkitree:
Fix file path problems that are related to configured default folders.
The most visible affected bug that is fixed with this is path previews.
Revision
1.48 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Sep 3 11:58:23 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.47: +5 -6 lines
Diff to
previous 1.47
#149789: remove the maxlength=64 restriction for file extensions.
The {node_field_instance} table is very large ("mediumtext" in MySQL) so
it's absolutely no problem to store longer file extension specifications.
Revision
1.46 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Sep 3 08:50:04 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.45: +8 -2 lines
Diff to
previous 1.45
#137555 by Egon Bianchet:
Remove default value from the widget settings form and only display
token strings that are actually usable (that is, the "user" ones).
Revision
1.45 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Aug 31 10:34:10 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.44: +52 -281 lines
Diff to
previous 1.44
Oh damn, sorry, I didn't mean to commit this to the official branch.
Mixed up "cvs commit" and "svn commit". Again, my sincerest apologies.
Revision
1.42 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 20 17:01:04 2007 UTC
(2 years, 4 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.41: +1 -2 lines
Diff to
previous 1.41
Correction to the previous commit: the wrongly applied patch was #113900
(make private downloads work by clearing the field's session variable)
and there wasn't a line missing but it was inserted at the wrong place,
for the 'delete' action instead of the 'insert' one.
So, add it for 'delete' ('insert' has it since the previous commit).
Revision
1.41 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 20 16:52:36 2007 UTC
(2 years, 4 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.40: +2 -1 lines
Diff to
previous 1.40
This session clearing statement seems to have been lost from applying
the database consistency patch, where it originally came from.
Re-add it.
Revision
1.37 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 20 09:54:31 2007 UTC
(2 years, 4 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.36: +12 -4 lines
Diff to
previous 1.36
#155398 and #155402 by myself, also making use of joshk's strtolower() idea:
Don't allow "file.jpg.bmp" to be validated when only "jpg" is allowed,
and make comparisons case-insensitive.
Revision
1.36 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jul 20 09:29:08 2007 UTC
(2 years, 4 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.35: +25 -11 lines
Diff to
previous 1.35
Sanitize handling of the show_list option,
and make attachment lists with replaced files look ok again.
Revision
1.32 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Jun 22 15:10:33 2007 UTC
(2 years, 5 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.31: +6 -5 lines
Diff to
previous 1.31
Restructure filefield_field_formatter() so that it stays functionally
equivalent, but looks like imagefield_field_formatter().
Revision
1.27 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 16 14:13:17 2007 UTC
(2 years, 5 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.26: +6 -2 lines
Diff to
previous 1.26
#144771: Remove filefield dependencies on upload.module by implementing a
new "view filefield uploads" permission for private files configurations.
Original patch by bojanz, modified version committed to imagefield by dopry,
port to filefield by myself.
Revision
1.26 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 16 13:33:28 2007 UTC
(2 years, 5 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.25: +3 -1 lines
Diff to
previous 1.25
#113900 by myself: Make private downloads work by clearing the field's session variable after storing the file.
Revision
1.25 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 16 13:21:01 2007 UTC
(2 years, 5 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.24: +58 -23 lines
Diff to
previous 1.24
#137833 by myself: remove dangling db entries, and ignore those which have
never been created by the user but must exist because of CCK's design.
Revision
1.24 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 16 12:41:26 2007 UTC
(2 years, 5 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.23: +4 -6 lines
Diff to
previous 1.23
#140572 by aggaire: removed unnecessary inner loop in filefield_clear_field_session().
Minimally modified the original patch so that $delta is still listed.
Revision
1.16 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Feb 1 08:50:17 2007 UTC
(2 years, 9 months ago)
by
dopry
Branch:
MAIN
Branch point for:
DRUPAL-5
Changes since
1.15: +93 -70 lines
Diff to
previous 1.15
back porting imagefield preview handling updates. fixing some logic issues with single value uploads, and the
form theme functions. single value fields seem to be working. not sure about multivalue fields... required and
extension validation is still working. try at your own risk.
Revision
1.14 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Nov 15 18:53:39 2006 UTC
(3 years ago)
by
dopry
Branch:
MAIN
Changes since
1.13: +8 -8 lines
Diff to
previous 1.13
changed theme_add_style to drupal_add_css and replaced form_render with
drupal_render.
filefield HEAD should be DRUPAL-5 compatible. I will branch for DRUPAL-5
once I've tested with DRUPAL-5 cck.
Revision
1.12 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Nov 15 06:04:24 2006 UTC
(3 years ago)
by
dopry
Branch:
MAIN
Branch point for:
DRUPAL-4-7
Changes since
1.11: +57 -60 lines
Diff to
previous 1.11
backporting imagefield changes...
Still only works with 4.7
-- support for formatters
-- scalar as array errors on load
-- scalar errors on delete
plus some bric a brac spacing and documenting.
Revision
1.8 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Aug 13 06:11:13 2006 UTC
(3 years, 3 months ago)
by
dopry
Branch:
MAIN
Changes since
1.7: +41 -47 lines
Diff to
previous 1.7
Huzzah... filefield sorta works in a strange way now... It needs some tlc...
and a special patch for cck that modifies the handling of deleted items, and cleans up
some of the multiple fields special cases...
see: http://drupal.org/node/78417
Revision
1.7 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Aug 13 02:57:52 2006 UTC
(3 years, 3 months ago)
by
dopry
Branch:
MAIN
Changes since
1.6: +64 -39 lines
Diff to
previous 1.6
finally figured out some of the insanity... This one requires a special content.module patch to work that may
break lots of other things....
Revision
1.6 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Aug 13 00:41:04 2006 UTC
(3 years, 3 months ago)
by
dopry
Branch:
MAIN
Changes since
1.5: +80 -49 lines
Diff to
previous 1.5
Almost hopelessly broken :).... There are some UI improvements, and a fix to the hook_field op == load
that was nesting a [0] when files loaded from the database are empty(not in db):.
Revision
1.4 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Aug 11 05:52:46 2006 UTC
(3 years, 3 months ago)
by
dopry
Branch:
MAIN
Changes since
1.3: +27 -56 lines
Diff to
previous 1.3
Cleanups with the ui for the allowed extensions section, and some upload validation cleanup...
Need to tackle the widget form soon... any takers?
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
select a symbolic revision name using the selection box, or choose
'Use Text Field' and enter a numeric revision.
