Log of /contributions/modules/versioncontrol/versioncontrol.admin.inc
Parent Directory
| 
Revision Log
| 
Revision Graph
Revision
1.57 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Oct 16 14:15:26 2009 UTC
(6 weeks, 1 day ago)
by
sdboyer
Branch:
MAIN
CVS Tags:
HEAD
Changes since
1.56: +70 -56 lines
Diff to
previous 1.56
Merging in work from git by marvil07 for his GSOC project to OO-ify vcsapi. From this commit forward, HEAD is OO.
Revision
1.56 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jun 21 15:33:07 2009 UTC
(5 months, 1 week ago)
by
jpetso
Branch:
MAIN
Branch point for:
DRUPAL-6--1
Changes since
1.55: +15 -29 lines
Diff to
previous 1.55
Make the "data" column usable by other modules, and migrate more data to it.
This enables us to get rid of the {commit_restrictions} and
{versioncontrol_repository_metadata} tables, whose data is now
stored in $repository['data'] instead.
Requires an update.php run. This commit modifies update 6102 which
I introduced in my previous commit two days ago; if you have already
executed that update then please delete the "data" column from your
{versioncontrol_repositories} table and run it again.
Revision
1.55 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 20 09:30:04 2009 UTC
(5 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.54: +31 -11 lines
Diff to
previous 1.54
Introduce a new "data" column for repositories for additional custom properties.
Third-party modules can store data there instead of in separate tables,
which should eventually contribute to the goal of removing the backends'
{versioncontrol_[backend]_repositories} tables.
Also, make the "allow unauthorized commit access" setting per-repository
instead of global, and store it in the new "data" column.
Revision
1.53 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jun 1 13:22:47 2009 UTC
(5 months, 4 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.52: +3 -2 lines
Diff to
previous 1.52
Refactor user statistics themeing functions, introducing a new item list one.
Also, rework some of the VCS account themeing code for more
consistency or wider applicability.
Revision
1.52 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri May 29 16:20:55 2009 UTC
(6 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.51: +7 -13 lines
Diff to
previous 1.51
New API function versioncontrol_get_operation_statistics().
Replaces the infamous versioncontrol_get_user_statistics() with a
more flexible query-based approach instead of hardly scalable
counting of operation arrays.
In fact, this new function can count operations in pretty much any
combination of grouping and sorting that you might need. Or if you
just need the number of all operations altogether without any
grouping, you can have that as well. (Thus implementing cvslog's
In order to implement this functionality, versioncontrol_get_operations()
and the related query construction functions have been refactored
a bit, so that versioncontrol_get_operation_statistics() shares
lots of code for constructing the query.
On top of that, some pieces of code related to displaying statistics
have been slightly changed and adapted.
Revision
1.47 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jan 25 20:37:35 2009 UTC
(10 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-6--1-0-BETA1
Changes since
1.46: +32 -54 lines
Diff to
previous 1.46
Replace lots of
$form['blah'] = array('#type' => 'value', '#value' => $blah);
elements with
$form['#blah'] = $blah;
as the former is now deprecated in Drupal 6.
I hope I didn't miss any form_alter or $form_state['values'] conversions,
anyways I tried to be as thorough as possible.
A few '#type' => 'value' fields are left still, those are the ones that
the form chooses either as fixed value or as selection, depending on the
permissions. No big deal though, I don't feel offended by those :]
Revision
1.46 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jan 25 18:50:43 2009 UTC
(10 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.45: +6 -5 lines
Diff to
previous 1.45
Rename hook_versioncontrol_extract_{repository,account}_data() to
hook_versioncontrol_{repository,account}_submit().
That's consistent with most similar mechanisms known to me in general,
and with Rules' way of doing it in particular.
With this commit, we also get rid of the last instances of $form_values.
Revision
1.45 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Jan 15 17:52:49 2009 UTC
(10 months, 1 week ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-6--1-0-ALPHA1
Changes since
1.44: +10 -11 lines
Diff to
previous 1.44
A dynamic set of tabs, at least with regards to Version Control API's
potentially large number VCS accounts, is near to impossible with Drupal 6.
(Sam knows it, he practically wrote the book on that topic.)
Therefore, fix the remaining menu system hassles by throwing it all
into a single "Repository accounts" tab (in the user edit section),
and filling it with either a VCS account edit form or a list of accounts
that forwards to that VCS account edit form. Also, the insane
hook_user() hack has made a disappearance due to that new method.
Works reasonably well and comes with the advantage that it will now even
look exactly like on drupal.org ("CVS" tab title if appropriate), the only
issue that I couldn't find a solution for is that the second row of tabs
is lost when additional query arguments are passed. Bug in D6? hm.
Revision
1.44 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jan 11 14:17:56 2009 UTC
(10 months, 2 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.43: +24 -27 lines
Diff to
previous 1.43
Having the account filter form rendered to HTML before embedding it in the
account list form causes the "Filter" submit button not to trigger in D6.
Therefore, include it as a part of the account list form. Not the 100%
cleanest solution, but a sufficiently nice one. Better ideas are welcome.
Revision
1.43 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jan 11 02:05:25 2009 UTC
(10 months, 2 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.42: +8 -3 lines
Diff to
previous 1.42
Ensure D5 compatibility, only setting that form value if a repository
actually exists already. (So that isset() calls keep working as intended.)
Revision
1.41 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jan 10 11:59:56 2009 UTC
(10 months, 2 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.40: +23 -19 lines
Diff to
previous 1.40
* I disagree on some of Coder's suggestions, but let's have it its way
where I don't mind about different indentation and stuff.
* Change &$form to $form in submit and validate functions, as that's
the official version on http://drupal.org/node/144132.
Revision
1.39 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jan 5 11:06:38 2009 UTC
(10 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.38: +5 -5 lines
Diff to
previous 1.38
Unless I missed something, 'versioncontrol_admin_repository_delete_confirm'
(and in turn, confirm_form()) should be called by drupal_get_form()
rather than as page callback, I think.
Revision
1.38 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jan 5 10:59:21 2009 UTC
(10 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.37: +7 -8 lines
Diff to
previous 1.37
Forms and backends have nothing in common apart from both being arrays.
If you don't mind, I'd like to keep them on different lines.
Revision
1.37 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jan 5 10:51:51 2009 UTC
(10 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.36: +2 -1 lines
Diff to
previous 1.36
I had inserted the (technically unnecessary) return statements to
make it clear that code execution does not continue after drupal_goto().
Maybe it's better to directly state that in a comment.
Revision
1.36 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jan 5 07:28:15 2009 UTC
(10 months, 3 weeks ago)
by
sdboyer
Branch:
MAIN
Changes since
1.35: +49 -42 lines
Diff to
previous 1.35
A few menu cleanups and tweaks, but other than that, almost entirely D6 FAPI compliance updates. Still a few fuzzy things in there that will need revisiting later.
Revision
1.35 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Jan 4 22:17:58 2009 UTC
(10 months, 3 weeks ago)
by
jpetso
Branch:
MAIN
Changes since
1.34: +26 -49 lines
Diff to
previous 1.34
D6 upgrade task 1.: Entirely new menu system.
...and yup, that did some heavy changes. Most notably, we're finally able
to get rid of that hook_user() category hack, which is great. I'm pretty
sure that it doesn't work the way it stands now (I can tell *that* much
by looking at the user.module sources), and most probably we'll need some
hook_menu_alter() magic, but the bulk of the menu conversion is done.
This was probably the most unwieldy chunk of the D6 port, everything else
should be more or less straightforward :)
Revision
1.31 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Jan 21 10:52:40 2008 UTC
(22 months, 1 week ago)
by
jpetso
Branch:
MAIN
Changes since
1.30: +9 -7 lines
Diff to
previous 1.30
Holy moly! Here comes the big fat operation factoring commit.
Commits, branch operations and tag operations now derive from one
base object (an "operation") which has most of its properties stored
in the new {versioncontrol_operation} table.
+ More consolidation, less duplicate code,
and less duplication in the table structure.
+ One operation id to rule them all.
+ Potential for introducing a combined versioncontrol_get_operations()
function that can retrieve all three kinds of operations. Later, though.
+ A few bug fixes.
+ Comes with an upgrade path. Scary, though, I hope I won't ever
have to do an update function like this again.
- Even more abstraction, which makes the database scheme even harder
to grasp.
- One more join in important SQL queries.
Revision
1.30 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Nov 9 20:23:25 2007 UTC
(2 years ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--1-0-RC4
Changes since
1.29: +4 -1 lines
Diff to
previous 1.29
This isn't the first time that a query fragment like 'WHERE column = ()'
causes problems. Try to avoid those cases by explicitely checking
the constraints on emptyness and returning FALSE for constraints
that are set but empty.
Also, prepend hook_versioncontrol_filter_account() instances with a check
if there are accounts in the list at all. Fixes the bug that was reported
by "world" on #drupal-dev.
Revision
1.29 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Nov 2 13:39:12 2007 UTC
(2 years ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--1-0-RC3
Changes since
1.28: +2 -4 lines
Diff to
previous 1.28
Starting the Subversion backend shows quite a bit of buggyness...
but that's fixable:
* Make sure that the delete_{repository,branch,tag,commit}() functions
work from [vcs_backend]_uninstall().
* Make sure that disabled backends never cause *more* results
to be retrieved by the query functions. That bug was the reason
that my test data is now gone. Well it wasn't more than 4 pages anyways.
* Make sure that the FakeVCS backend never handles form value extraction
hooks if it hasn't altered the form beforehand.
* Fix a stupid typo (or rather, copy-n-paste-o) in the FakeVCS backend.
* Polish for the repository edit form: require a repository name,
and remove a duplicate form element description.
Revision
1.28 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Oct 30 01:59:50 2007 UTC
(2 years, 1 month ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--1-0-RC1,
DRUPAL-5--1-0-RC2
Changes since
1.27: +19 -5 lines
Diff to
previous 1.27
Last TODO item for Version Control API 1.0 (code-wise):
Introduce the get_url_log_view() API function and the
'file_log_view' repository URL in the database / repository admin form.
Used by Commit Log for linking file names (whereas the content view URL
is used for linking revision numbers).
Also, a bit of bug fixing:
* Make branch replacement tokens work for repository URLs.
* Delete entries from {versioncontrol_repository_metadata}
if the repository is deleted itself.
* Better URL encoding in Commit Log.
Now let's copy the Version Control API overview from g.d.o and we're set.
Revision
1.27 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Oct 29 21:02:21 2007 UTC
(2 years, 1 month ago)
by
jpetso
Branch:
MAIN
Changes since
1.26: +9 -9 lines
Diff to
previous 1.26
The right way to write '%d' is without quotes, so remove all of those.
Also, add a few configuration variables to the uninstallation function
that have been forgotten before.
Revision
1.26 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Oct 2 14:58:58 2007 UTC
(2 years, 1 month ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--1-0-BETA1
Changes since
1.25: +3 -3 lines
Diff to
previous 1.25
* Rename the $form['#id'] values from vcs-* to versioncontrol-*.
The previous names had their merits from a logical point of view,
but were a bit confusing for me nonetheless.
* Add a setting for the Commit Log's pager limit.
Revision
1.25 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Sep 26 17:36:59 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.24: +4 -3 lines
Diff to
previous 1.24
Themeability is good, but it's even better if it can be done
by non-coders in a straightforward way.
So, a few preparations for the D6 way of theming (work in progress),
by separating the logic from the presentation in some places.
Also, a bit more clarity, plaintextability and documentation.
Revision
1.24 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Sep 23 22:10:16 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--0-9-RC1
Changes since
1.23: +4 -4 lines
Diff to
previous 1.23
So if we're already messing big time with the table structure,
let's rename the repository_internal_data one into repository_metadata,
which is less scary and fits better.
Revision
1.23 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Sep 23 21:54:22 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.22: +4 -4 lines
Diff to
previous 1.22
Simple but effective repository caching. Does not flush the cache when
the repository is changed, but that is anyways unnecessary in about 100%
of all cases.
Also, replace SQL "column = 'value1' AND column = 'value2'"
with "column IN ('value1','value2')" where reasonable.
Revision
1.22 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Sep 23 19:46:01 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.21: +26 -441 lines
Diff to
previous 1.21
The Last Great Mess-up: make authorization methods a per-repository setting
instead of a site-wide one. For example, that enables us to have an
application-based contrib repository next to a purely admin-controlled
core one.
Changes that go with this commit:
* One more column in the repository table
* One less column in the account status strings table
* Introduction of hook_versioncontrol_alter_repository_selection()
for selectively disallowing repository registrations
* Reshuffle the admin interface
* While we're at it, move the non-admin pages out of .admin.inc
and into .pages.inc
* Simplify the Account Status module by dropping the
site-wide authorization method, which isn't very practical anyways
* Apidox updates
* ...and a few bug fixes, I think.
Revision
1.20 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Sep 8 15:39:50 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--0-9-BETA2
Changes since
1.19: +8 -10 lines
Diff to
previous 1.19
* Postgres support.
* Factor out the account export function so that backends
can use it by calling from a cron script.
* Pass a proper branch/tag operation array to the has_*_access() hooks.
Revision
1.19 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Sep 4 13:07:42 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.18: +147 -16 lines
Diff to
previous 1.18
Filtering, paging and more efficiency for the account list. Whoo!
Also, properly hook into the submit handler for the global settings form.
Revision
1.18 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Sep 3 07:03:54 2007 UTC
(2 years, 2 months ago)
by
jpetso
Branch:
MAIN
CVS Tags:
DRUPAL-5--0-9-BETA1
Changes since
1.17: +4 -4 lines
Diff to
previous 1.17
* A bit of refactoring in the account status module so that we're able
to distinguish between user submitted and programmatically submitted
insertions and updates.
* Together with that, a small API change for more consistency.
* And of course, bug fixes.
Revision
1.17 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Aug 30 12:07:31 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.16: +227 -12 lines
Diff to
previous 1.16
* import/export functionality
* an option to allow or disallow unauthorized commits
* a "Most active developers" block
Revision
1.15 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Tue Aug 21 12:32:39 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.14: +5 -5 lines
Diff to
previous 1.14
A few fixes and the introduction of versioncontrol_get_parent_item().
Also, display the project item as base directory in the commit log
if the commit corresponds to a project.
Revision
1.13 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Aug 20 21:43:20 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.12: +16 -12 lines
Diff to
previous 1.12
Splitting the register account form into a page (markup) and a form part
enables us to call drupal_access_denied(), return nothing and look like
expected.
Revision
1.9 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Aug 20 09:25:46 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.8: +124 -27 lines
Diff to
previous 1.8
Repository specific overview messages, and a demo mode for showing those
to the admin. Also, better watchdog logging.
Revision
1.7 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sun Aug 19 23:15:42 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.6: +180 -111 lines
Diff to
previous 1.6
* Greatly simplify hook_menu() with respect to account registration.
That also prevents fetching all repositories at 'user/$uid/edit'
and is much cleaner in general.
* Together with that, introduce an admin form for general
version control related settings, with account authorization
as default task. Also, introduce a two simple API functions
so that account authorization modules can hook into that.
* Update the README.txt files. It's very tedious to retrieve the exact
maintainers for each line, so let's just name the cvs.module authors
collectively.
* A few other fixes, as always ;)
Revision
1.6 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Mon Aug 13 09:44:39 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.5: +10 -14 lines
Diff to
previous 1.5
Generalize the repository/account hooks so that all modules can provide
additional edit/add form elements (and more importantly, process them)
instead of just the backend modules.
Revision
1.5 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Thu Aug 9 16:38:29 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.4: +2 -178 lines
Diff to
previous 1.4
Move the menu hook to the main file, add a JavaScript username callback,
and only return approved accounts by default. (Account approval can be
denied by implementing hook_versioncontrol_is_account_approved($uid, $repo_id)
and returning FALSE for bad users.)
Revision
1.4 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Aug 3 15:12:15 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.3: +114 -106 lines
Diff to
previous 1.3
Move the account list callback function to the top where it belongs,
add an "edit" link for user accounts, and fix a few potential
security bugs with check_plain().
Revision
1.2 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri Aug 3 14:06:02 2007 UTC
(2 years, 3 months ago)
by
jpetso
Branch:
MAIN
Changes since
1.1: +345 -32 lines
Diff to
previous 1.1
Provide account creation and modification facilities
(still without motivation texts and admin approval for now).
Simplify and complete the backend API.
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
select a symbolic revision name using the selection box, or choose
'Use Text Field' and enter a numeric revision.
