Log of /contributions/themes/interlaced/interlaced.theme
Parent Directory
| 
Revision Log
| 
Revision Graph
Revision
1.9 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Sat Jun 14 03:02:51 2003 UTC
(6 years, 5 months ago)
by
ax
Branch:
MAIN
Changes since
1.8: +72 -123 lines
Diff to
previous 1.8
- fixed [bug] Interlaced Theme does not work with htmlArea | http://drupal.org/node/view/1958 - added theme_footer()
- removed <?xml> declaration - confuses some browsers
- removed <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> - done by theme_head() now
- removed many superfluous lines and trailing spaces - 4600 bytes => 3700
- fixed / improved indentation
it would be nice if theme authors would care a little more about spacing and indentation. just as we have rules for indenting code - because this makes it easier to understand, maintain, and be correct, the same should apply for themes and included html. some hints:
- indent with 2 spaces
- match the indentation of (long) opening and closing block html tags
- distinguish between php and html indentation. not
function header($title = "") {
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html ...>
...
but
function header($title = "") {
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html ...>
...
this not only saves the superfluous leading spaces, but also makes it much easier to find matching opening and closing tags defined in functions with different indentation.
- prefer php in html over html in php. not
function node($node, $main = 0) {
print "\n<!-- node: \$node->title\ -->\n";
print "<div class=\nodetitle\>$node->title</div>";
print "<div class=\nodebody\><span class=\nodedate\>".$this->links(array(format_name($node),format_date($node->created, "small")," "))."</span>";
but
function node($node, $main = 0) {
?>
<!-- node: "<?php print $node->title; ?>" -->
<div class="nodetitle"><?php print $node->title; ?></div>
<div class="nodebody">
<span class="nodedate"><?php print $this->links(array(format_name($node), format_date($node->created, "small"), " ")); ?></span>
after all, PHP is a HTML embedded scripting language - and not the other way round ...
if this will fit the cvs log message?
Revision
1.8 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Fri May 30 00:49:44 2003 UTC
(6 years, 6 months ago)
by
almaw
Branch:
MAIN
Changes since
1.7: +1 -3 lines
Diff to
previous 1.7
Removed now-redundant <base href> tags (update your theme.inc to CVS >= 29 May 2003 11:18).
Added onload body attibutes to themes lacking them.
Cleaned up xsilver and sunflower to make them (more) (X)HTML compliant.
Revision
1.2 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 12 22:24:26 2002 UTC
(7 years, 5 months ago)
by
kika
Branch:
MAIN
Changes since
1.1: +1 -1 lines
Diff to
previous 1.1
- added new CSS style. Designed for specially for boys :)
- made links delimiter CSS based, no more hardcoded bullet images
Revision
1.1 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Wed Jun 12 11:11:41 2002 UTC
(7 years, 5 months ago)
by
kika
Branch:
MAIN
Branch point for:
DRUPAL-4-0
Interlaced is entirely CSS-based theme, all fonts/colors/backgrounds/table widths
are defined in external stylesheet(s).
I provided two different stylesheets for different looks.
To change the stylesheet, just find a following line in interlaced.theme file
<link href="/themes/interlaced/styles1.css" rel="stylesheet" type="text/css" />
and rename 'styles1.css' to 'styles2.css'.
Of course feel free to create your own cool stylesheets :)
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
select a symbolic revision name using the selection box, or choose
'Use Text Field' and enter a numeric revision.
