Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#891476 by solotandem: Fixed Tableselect is missing a column header when not multiple value.
#895896 by Jacine: Fixed Textarea element should not have a value attribute.
#763376 by fago, sun, noahb, effulgentsia, ksenzee, jhodgdon: Fixed Not validated form values appear in ().
- Patch #883336 by sun, andypost: theme_image_button() broken.
- Rollback of #447816 -- didn't meant to commit that just yet.
- Patch #879910 by plach: fixed text_field_prepare_translation() broken.
#727126 by jhodgdon, rdrh555: improve documentation of drupal_execute()
- Patch #690980 by seutje, sun, seanyo, aaroncouch: disabled form elements not properly rendered.
- Patch #800460 by effulgentsia, sun: WTF coupling between ()['cache'] and form processing.
- Patch #827430 by David_Rothstein: drupal_form_submit() no longer works with checkboxes.
- Patch #561226 by fago, effulgentsia, sun, YesCT, marcingy: orms (elements) need to able to specify include files to be loaded for building.
#776956 by CrashTest_, Damien Tournoud, effulgentsia, chx: Fixed critical bug: Complex widgets are not respecting '#disabled' state.
Roll-back of #749748. This broke JavaScript on node add forms, and probably elsewhere.
- Patch #749748 by mavimo, Dave Reid: contact and comment modules do not prefill with user info from cookie.
- Patch #791168 by Berdir: does form_state() cache never get cleaned?
- Patch #736298 by effulgentsia, eojthebrave, andypost, robeano: fixed Refactor file.module to use proper button click detection, enabling FAPI to improve button click detection security.
- Patch #838324 by agentrickard: document form_options_flatten().
- Patch #624086 by limikael, Dmitriy.trt: custom accept-charset for forms.
- Patch #802746 by effulgentsia: documentation fixes.
- Patch #802746 by rfay, jhodgdon: document () and form builder function in form_api() group.
- Patch #804870 by CrookedNumber: docblock for drupal_form_submit() was outdated.
- Patch #803212 by effulgentsia, Heine: protection against forgery of input selection value doesn't work with checkboxes.
- Patch #748390 by rfay, effulgentsia: improve #limit_validation_errors() phpdoc.
- Patch #774346 by jvandyk: fixed documentation.
- Patch #768490 by JohnAlbin, sign: theme_table_select_header_cell() is not really a theme function.
#762434 by pwolanin: make form_build_id generation consistent
- Patch #67439 by sun, effulgentsia: #tree in hook_element_info() does not work.
- Patch #730046 by pwolanin, Damien Tournoud: performance settings page is inconsistent.
- Patch #547490 by ugerhard, Jody Lynn, Matt V.: entering only 'Confirm password' field passes validation and returns success message.
#331951 by aspilicious, sun, jhodgdon, Morbus, et al: Figure out and apply coding standard for casting.
- Patch #723802 by pwolanin, grendzy: convert to sha-256 and hmac from md5 and sha1.
#783438 by sun: Fixed #states doesn't work for #type item.
#767212 by sun, rfay: Fixed #states can't hide/show fieldsets.
- Patch #755030 by jhedstrom, sivaji, kkaefer: #field_prefix()/suffix is displayed before the label. With tests.
- Patch #765860 by effulgentsia, dww, dereine, mikey_p, sun: make drupal_alter() support multiple alter hooks executed by module weight.
- Patch #482816 by sun, Rob Loach: make a consistent wrapper around submit buttons.
#776178 follow-up by David_Rothstein: Fixed PHP 5.3 warning for command line install at the root, rather than the symptom.
- Patch #716496 by JohnAlbin: documentation updates for theme functions.
- Patch #426056 by effulgentsia, Berdir, sun, boombatower, tstoeckler: fixed server-side enforcement of #disabled is inconsistent.
- Patch #741578 by nikgregory, andypost, Berdir, noahb: 'File' is a reserved word that should not be used.
- Patch #558928 by mgifford, brandonojc, Owen Barton, Everett Zufelt: follow-up on making form element labeling more accessible.
- Patch #760738 by yched: includes full form state in unneeded cases.
- Patch #671184 by Scott Reynolds, sun, effulgentsia, yched, rfay, Pasqualle: AJAX form can submit inappropriately to system/ajax after failed validation.
#467296 by Frank Ralf, mgifford, Everett Zufelt, Cliff,seutje, Bojhan, kat3_drx, et al: Accessibility improvements for vertical tabs.
- Patch #684846 by effulgentsia, rfay, quicksketch, aspilicious: AJAX triggered by non-submit element fails if any elements are validated.
- Patch #681538 by aspilicious, jhodgdon, trevjs: fixed possibly broken @see also links.
- Patch #667944 by sun: Javascript #states cannot hide fieldsets, radios, checkboxes.
#335035 follow-up by andypost: Fixed failure in tests.
- Patch #335035 by boombatower, Damien Tournoud, ksenzee, Berdir, Dave Reid, effulgentsia: Simpletest drupalPost() incorrectly submits input for disabled elements, causing unreliable testing of forms that contain them.
- Patch #131432 by dereine, alienbrain, sun: #field_prefix() and #field_suffix() work on textfields only.
- Patch #735628 by sun, Jacine: resizable textarea behavior leads to unpredictable results.
#414424 by sun, chx, Arancaytar, yched, et al: Introduce Form API #type 'text_format' for additional DX/security around rich text fields.
#260934 by plach, ShawnClark, et al: Fixed Static caching: cannot call drupal_validate_form() on the same form more than once.
- Patch #405832 by jhodgdon, arianek: documentation for hook_forms() was incorrect.
- Patch #727126 by jhodgdon: fixed drupal_execute()/drupal_form_submit() documentation.
- Patch #676800 by casey, sun, james.elliott, cosmicdreams, seutje, Jacine: made fieldsets work on all browser.
- Patch #648170 by fago, sun: form constructors cannot enable form caching or form rebuilding.
#302240 follow up by sun, fago: re-enable form rebuilds, when a button of #type button is used
- Rollback #642820 -- test results were green but actually failed.
- Patch #642820 by c960657: fixed PHP notices when submitting form with disabled checkbox.
#539220 follow-up by mr.baileys: Fix test failures.
- Patch #539220 by dww, mr.baileys: missing validation handlers should not be silently ignored by FAPI.
- Patch #681538 by aspilicious, jhodgdon: improved documentation, better @see also links.
- Patch #693614 by asimmonds: fixed PHPDoc spelling typos.
#629794 by yched: Fix Scaling issues with batch API. (with tests)
#482816 by sun and Rob Loach: Add a consistent wrapper around submit buttons.
#370537 by chx, sun, effulgentsia, quicksketch, eaton, Heine, and yched: Allow buttons to only validate sections of forms, e.g. More buttons. (with tests)
- Patch #357021 by Kars-T, yched: fixed #after_build_done() set after first after_build() function was run, instead of all after_build() functions.
- Patch #437018 by JamesAn: convert form_options_flatten() in form.inc to use new static caching API.
- Patch #190867 by David_Rothstein: fixed function name.
- Patch #302240 by fago, sun: fixed button broken.
- Patch #644648 by sun: cleaned up, documented, and corrected some ['#token'] code.
- Patch #558666 by sun, dropcube: revamp text format/filter configuration for better usability.
#658032 by Arancaytar: Fixed theme_tableselect() does not pass on #attributes key.
#528822 by markDrupal, jhodgdon: update batch API example to document file key, reflow key listing to be an actual list
#640050 by heyrocker: fix code example in drupal_execute() phpdoc; password fields should have two string values
- Patch #570314 by jhodgdon: more details for form_set_value() documentation.
- Patch #641356 by fago, sun: cache more of () when form caching is enabled.
- Patch #520946 by jhodgdon: fixed error in API documentation of form_set_error().
- Patch #558928 by brandonojc, mgifford, Owen Barton, Everett Zufelt: improved consistency, flexibility and accessibility of form element labels.
- Patch #648410 by Dave Reid: standardize add 'empty' row functionality to all tables.
- Patch #647130 by fago, sun: cache only once when rebuilding a form.
- Patch #622922 by chx, fago, sun, effulgentsia: form API clean-up, bugfixes and extra tests.
- Patch #644150 by sun: () is stateless, even with enabled caching.
- Patch #642702 by sun: form validation handlers cannot alter structure.
- Patch #644150 by sun: () is stateless, even with enabled caching.
- Patch #641544 by yched:FAPI #type 'container' ids generated twice.
- Patch #640050 by heyrocker: example code for drupal_form_submit() was incorrect.
- Patch #639704 by casey: removed dead code from form_process_date().
- Patch #639418 by sun: #array_parents() do not always map to actual form structure.
- Patch #634440 by fago, effulgentsia, sun: remove auto-rebuilding magic for ()['storage'].
- Patch #583730 by sun: fixed form caching.
#601806 by sun, effulgentsia, and Damien Tournoud: drupal_render() should not set default element properties that make no sense.
#179932 by Damien Tournoud, jromine, kenorb, deviantintegral, sun: Fixed Required radios/checkboxes are not validated.
- Rollback of #447816.
- Patch #619902 by sun: performance improvement: dashboard, region and block building had unnecessary function calls.
- Patch #623992 by sun: fixed the tests. We can re-enable the test bot now.
#560944 follow-up by brandonojc, seutje, and Davy Van Den Bremt: Move collapsible fieldset logic from theme_fieldset() hook to form_process_fieldset().
#528822 by jhodgdon: Batch example should explain that a file must be included when necessary.
#618278 by JuliaKM: minor spelling fix in drupal_get_form()'s documentation
#571086 follow-up by sun: Allow specifying a 'wrapper callback' before executing a form builder function.
#367567 by sun, effulgentsia, yched, and quicksketch: Use AJAX framework for 'Add more' links.
#602522 by effulgentsia, sun, and moshe weitzman: Make links in renderable arrays and forms (e.g. 'Operations') alterable.
#582584 by dww, Jacine, and chx: Move required form element marker into its own theme function.
#617420 by ksenzee: Fixed batch system error on redirection.
#607008 by dww, Gerhard Killesreiter, JacobSingh, and chx: Changed Fix bugs in https support and use https for authorize.php if available.
#610204 by effulgentsia, Gábor Hojtsy, sun, Damien Tournoud and ksenzee: API changes to support overlays: lays ground work for implementation.
- Patch #557272 by kkaefer, Rob Loach, quicksketch: added FAPI JavaScript States system.
#216098 by kwinters, jgoldberg, drawk, sun: Make drupal_goto() use the same parameters as url().
- Patch #594650 by sun, c960657: provide central ()['values'] clearance.
- Patch #593522 by sun: a better and faster drupal_alter().
#118345 by sun: Make user.module conform to standard presave/insert/update/form_alter hook paradigm.
#322344 follow-up by sun: Fix notice.
- Patch #572618 by effulgentsia, pwolanin, sun: all theme functions should take a single argument. Code clean-up and performance improvement. Woot.
#464862 follow-up by kkaefer: Rename drupal_css_class() to drupal_html_class_X(), for better accuracy.
- Patch #555762 by gordon, sun | yched, chx, moshe weitzman, KiamLaLuno, lilou: improvements to batch API.
- Patch #464862 by JohnAlbin, sun, dereine | dvessel, Jacine, Zarabadoo: added drupal_css_class() to clean class names and rename form_clean_id().
- Patch #578520 by sun | c960657, mfb, Dries, catch, mattyoung: make in url() only accept an array. Another nice API clean-up!
Patch #579366 by sun, litwol | chx, Dries: simplified form API redirection handling. I can actually understand it now. ;-).
- Patch #11218 by David_Rothstein, sun, quicksketch, duncf, awood456, dropcube, mgifford | pwolanin, dww, RobRoy, Crell, webchick, beginner, ray007, bjaspan, chx, Gábor Hojtsy, Steven, Dries, lutegrass, sym, guardian, matt2000, geerlingguy, SeanBannister, matt westgate, com2, praseodym: allow default text formats per role, and integrate text format permissions.
#571086 by sun and merlinofchaos: Added a 'wrapper callback' that executes before a form builder function, to facilitate common form elements. Clean-up from form_builder changes from CTools patch. Has nice side-benefit of making all form functions' signatures consistent.
#360605 by Berdir et al.: make Drupal core work with PHP 5.3.0 out of the box (fixes for incompatibilities introduced with PHP 5.3.0)
#302240 by fago: forms were rebuilt on validation errors and when #ahah was used #cache was turned on, but form storage was not actually stored
#539022 by dropcube: Use current theme during Batch API processes.
- Patch #572932 by sun: rename hook_elements() to hook_elements_info() for consistency. Yay to API clean-ups during 'slush'.
- Patch by #565496 by dropcube, pwolanin: changed Allow dynamic attaching of other types of stuff to render() structures.
- Patch by #1577 by chx, boombatower, Bèr Kessels, kkaefer: made SSL support a bit easier by providing two cookies and ... hook_goto_alter.
#560944 by seutje: Fixed collapsible fieldsets in Garland.
#367567 by effulgentsia, yched, quicksketch, sun, and chx: Move AHAH-'add more' to the new generic AHAH callback, and add support for form definition functions being kept in non-.module files.
#505084 by Rob Loach: Added an #attached_library() FAPI property for drupal_add_library(), for consistency with #attached_css and #attached_js.
#547846 by David_Rothstein: Fixed a missing reference operator that caused Drupal installation to fail on PHP 5.3.
#550572 by sun and c960657: Fixed CSS+JS regressions related to form-item-[name].
#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.
Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.
*** empty log message ***
#326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: Convert 'class' attribute to use an array, not a string.
#552744 by drewish: Fixed incorrect documentation for the form.inc theme functions.
#517814 by jmstacey, justinrandell, pwolanin, drewish, Jody Lynn, aaron, dopry, and c960657: Converted File API to stream wrappers, for enhanced private/public file handling, and the ability to reference other storage mechanisms such as s3:// and flicker://.
#544418 by merlinofchaos, sun, drewish, quicksketch, et al: Integrate CTools AJAX framework with Drupal to extend (and replace) existing ahah framework. Everything about AJAX/AHAH is more betterer now.
- Patch #546568 by quicksketch: consistently pass in to #value_callback functions.
#265265 by neochief, jhodgdon: missing phpdoc @code tags on PHP code examples in form.inc and actions.inc
#433992 by David_Rothstein and Frando: Change #theme_wrapper to #theme_wrappers to allow multiple theme functions to execute on renderable objects.
- Patch #524728 by David_Rothstein, JoshuaRogers, JacobSingh et al: refactor install.php to allow Drupal to be installed from the command line.
- Patch #531038 by quicksketch: #value_callback missing drupal_function_exists().
- Patch #523034 by jhodgdon: better documentation for theme_fieldset.
- Patch #517318 by dmitrig01: tableselect needs to be able to give options weights.
- Patch #517542 by David Strauss: renamed functions for clarity. We say 'yay' to clarity!
- Patch #512308 by JacobSingh: add the ability to provide attributes to rows in table select
- Patch #483778 by Frando: some form API clean-up.
- Patch #510398 by asimmonds: incorrect CSS class for form element wrappers.
#315100 by Rob Loach, quicksketch, sun, skilip, aaron, et al: Add ability for modules to register JS/CSS libraries.
- Patch #482636 by quicksketch: further clean-up of the form IDs/classes.
- Patch #495598 by jrchamp: use explode() instaed of spit().
- Patch #67211 by catch, Gábor Hojtsy, yoroy, cdale, et al: drop the colon after form titles.
- Patch #265265 by jhodgdon, neochief: phpdoc fix.
- Patch #274947 by yched: removed the remaining bits from teaser splitter.
- Patch #43493 by sime, sun, et al: add name/type as CSS class for form elements.
- Patch #422362 by JamesAn: convert form.inc to use new static caching API.
- Patch #477944 by Damien Tournoud: fix and streamline page cache and session handling.
#398902 by Nick Urban, alexanderpas, kscheirer: password equality checking was not using strict type checking; we should assume these are strings and compared character to character
- Patch #471070 by stella: millions of code style fixes.
#398902 by kscheirer and alexanderpas: Type-check passwords.
#292565 by grendzy, John Morahan, Jody Linn: remove path munging on 403/404 pages, which caused problems for login redirects
#292565 follow-up by Jody Lynn: Remove ['destination'] hacks to get login redirection working again.
- Patch #353069 by Moshe Weitzman, dmitrig01: make drupal_get_form() return unrendered forms.
- Patch #457532 by Berdir: more PHP5 'fixes'.
- Patch #360128 by chx, quicksketch, Frando et al: security fix for simplified AHAH callbacks.
- Rolled back patch #343415. Needs more work and discussion.
- Patch #408024 by brianV et al: rename drupal_execute() to drupal_submit_form().
Rolling back #343415 given disputes around its change in Drupal 7.
#343415 by Damien Tournoud: the form cache is not automatically cleared on submit if the page cache is activated
- Patch #343415 by Damien Tournoud: form cache is not cleared on submit when page cache is activated.
- Patch #302240 by fago: fixed various problems with form storage and added tests. Yay.
#323112 by dmitrig01, kkaefer, quicksketch, frando and many many more: Now presenting... Vertical Tabs. Fantastic new UI improvement for node forms and hopefully more in the future.
#297972 by wilson98, scor, Steven Jones, yched, heyrocker: make the batch API compatible with drupal_execute(), so things like creating a CCK type or adding fields to it (by submitting forms programatically) are possible in update functions
#292565 by lyricnz, Damien Tournoud, Jody Lynn, kleinmp, John Morahan, akalsey: Make forms work on 404 and 403 pages. Remove any fake destination set by drupal_not_found() or drupal_access_denied() so that we can properly redirect from those pages.
#304330 follow-up by sun: Clean-up of text format widget patch.
#297972 by scor, yched, Steven Jones, and heyrocker: Allow drupal_execute() to be performed within batch API (with tests).
- Patch #322344 by merlinofchaos, Frando, catch, sun: form improvements from Views.
- Patch #394616 by csevb10: converted to new database abstraction layer.
- Patch #244904 by keith.smith, edmund.kwok, xano, David_Rothstein: rename 'input formats'.
#292565 by John Morahan and lyricnz: Fix 404 on search form from a 404 page (with tests).
#150851 by pwolanin and chx: different radio buttons in the same set should have different HTML id values (XHTML validity fix). Backport #367689 by gollyg.
#314286 backport of some of #229129 by assimonds: disbaled checkboxes did not receive their values properly from the default value set
#152098 by hunthunthunt, mgifford, Dave Reid: add 'for' attribute to 'label' tags on checkboxes and radio buttons, even if the 'label' wraps the element - accessibility best practice
- Patch #355236 by Frando: refactor drupal_render() theming.
#360128 by quicksketch: Create centralized ahah callback to reduce duplicate code.
#242962 by Heine: Add a 'tablesort' Form API element to unify various places we use a big table with JS-enabled checkboxes next to each item (with tests).
- Removing whitespace.
- Patch #360605 by Berdir: made CVS HEAD compatible with PHP5.3.
- Patch #244904 by edkwh, keith.smith: renamed 'input format' to 'text format' based on UMN usability study.
- Patch #201122 by c960657, Moshe Weitzman: never write anonymous sessions, unless something has been written to . This is an important performance improvements -- as long as you use modules that use carefully. It might be good to report some analytics about this in the performance settings page so administrators can see if there is a 'broken' module.
#152098 by mgifford: Improve accessibility of radios and checkboxes.
#356782 by quicksketch: remove unused unset($edit) from _form_builder_handle_input_element()
- Patch #329407 by dereine, birdmanx35, hswong3i et al: report running time of simpletests.
#356782 by quicksketch: remove needless line of code.
- Patch #352470 by scor: fixed typos and grammar in comments.
#333658 by sun: Code clean-up for batch.inc.
#348269 by Darren Oh. Add missing * in the expand_password_confirm() comment.
- Patch #335086 by recidive: rename node, filter and comment module tables to singular for consistency. Oh my.
Removing #137932 which was committed prematurely.
#337820 by Dave Reid: Rename menu path 'logout' to 'user/logout' for consistency.
- Patch #337454 by earnie: fixed the phpdoc of drupal_render_form().
- Patch #337454 by earnie: fixed the phpdoc of drupal_render_form().
#334732 by swentel: Fix notices in form.inc visible from update.php.
- Patch #332123 by webchick, lilou: remove t() function from schema descriptions.
#299742 by Darren Oh: missing #ahah support on checkboxes
#315798 by Rob Loach, mfer, Grugnog2, and sun: Add weighting to drupal_add_js().
- Patch #329273 by Damien Tournoud: make map_month() happier.
- Patch #329019 by dww, sun: fixed PHP warning.
- Patch #329019 by dww, sun: fixed PHP warning.
- Patch #299742 by Darren Oh: #aha didn't work for checkboxes.
- Patch #319408 by Crell: converted queries to new database abstraction layer.
#284887 by Dave Reid, dww: Avoid a 403 on autocomplete fields, when people do not have access to the path used for autocompletion; by disabling the autocomplete altogether in this case.
- Patch #320374 by Damien Tournoud, pwolanin et al: worked around a max_allowed_packet size issue with the simpletests.
#242873 follow-up: Missed a couple files with drupal_set_title().
Roll-back of #242873: This caused horrendous problems with SimpleTest on some configurations.
#282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.
#242873 by pwolanin and bjaspan: Make drupal_set_title() do check_plain() by default.
#319466: SA-2008-47 (#295053): CSRF in cached forms.
#284887 by Dave Reid and dww: Disable autocomplete if user does not have access to the callback.
#318575 by jvandyk: Change 'remaining' to 'completed' in Batch API, to better reflect what's actually happening.
#125315 by chx, sun, Gábor Hojtsy, drumm, and friends: Add #input_format FAPI property that can be used by WYSIWYG editors. WOOHOO.
#229129 follow-up by chx: Fix module dependency checking again.
#299672 by fago, chx: Cache form only if any of its element set #cache to TRUE (not if #cache is set at all)
#180063 by andremolnar, TheMystic, R.Muilwijk: There was no way to flush form errors during iterative programatic form submission. Slight API expansion.
#299672 follow-up by chx: Better fix for only caching form if #cache is set to TRUE.
#259623 by dopry and Damien Tournoud: Convert includes/requires to use absolute paths.
#299672 by fago: Cache form only if #cache is set to TRUE.
#180063 by andremolnar, TheMystic, and R.Muilwijk: Add a parameter to form_set_error().
- Patch #305645 by pwolanin: ['REQUEST_TIME'] -> REQUEST_TIME. Improved developer experience.
#181831 by Rob Loach. Backport of #130630 by chx: provide an id on the form item wrapper div.
- Patch #302763 by Dave Reid, Rob Loach: replace time() by ['REQUEST_TIME'] as per Rasmus' suggestion. Removed drupal_referrer() for consistency.
- Patch #296300 by chx: remove edit[] and fixed Doxygen.
- Patch #279404 by chx: removed old cruft. See http://drupal.org/files/issues/fapi_award.jpg.
Drupal 6.4.
- Patch #290869 by swenterl, cwgordon07: fixed notice in #ahah handling.
- Patch #290869 by swenterl, cwgordon07: fixed notice in #ahah handling.
- Patch #290869 by Wim Leers: AHAH functionality was not working for radio buttons.
- Patch #290869 by Wim Leers: AHAH functionality was not working for radio buttons.
#117748 by webchick, Pancho, Rob Loach, pwolanin: required field values were not properly trim()ed on validation
- Patch #245001 by kkaefer et al: unify #process callback naming.
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
- Patch #273523 by aclight: fixed E_NOTICE in theme_fieldset().
- Patch #273523 by aclight: fixed E_NOTICE in theme_fieldset().
- Patch #243773 by chx, catch, boombatower, yched, dmitrig01, et al: use the batch API for running the tests instead of an all-in-one approach. Great work.
- Patch #216515 by chx, Damien Tournoud, et al: fixed form API glitch with caching.
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit et al. Can you say 'registry'? Drupal now maintains an internal registry of all functions or classes in the system, allowing it to lazy-load code files as needed (reducing the amount of code that must be parsed on each request). The list of included files is cached per menu callback for subsequent loading by the menu router. This way, a given page request will have all the code it needs but little else, minimizing time spent parsing unneeded code.
- Modified patch #230374 by killes, jakeg, Eaton et al: corrected problem with form API caches not being flushed. This could lead to performance issues.
- Modified patch #230374 by killes, jakeg, Eaton et al: corrected problem with form API caches not being flushed. This could lead to performance issues.
#88892 by darthsteven and flobruit: form_set_value() documentation was misleading, updating that
- Patch #88892 by darthsteven et al: improved the PHPdoc of form_set_value(). Great work. Much better. :)
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
- Patch #117748 by pwolanin: made account creation work again.
- Patch #216059 by nedjo, theborg, karens, goba, webchick et al: AHAH triggered by text input enter key press breaks autocomplete.
#216059 by nedjo: AHAH events were tiggered by text input form key press (eg. autocomplete)
#117748 by webchick, Pancho, Rob Loach, pwolanin: required field values were not properly trim()ed on validation
#216515 by chx and myself: cached forms made all subsequent forms on the page cached (critical); and a comment op check was buggy
- Patch #210131 by dvessel, catch, John, et al: updated jQuery library.
#117748 rollback: this was not well tested
#117748 by quicksketch: short fix to trim() required fields for validation, with documentation
#216061 by Eaton: nid was not set in node creation (programatic node creation regression)
#216042 by Eaton: provide the complete form to element validators as well (critical regression for CCK)
#214922 by Eaton: fix code typo which prevented from image buttons in a tree form from working
#206955 follow up by merlinofchaos: avoid misusing default values for image buttons
#194327 by dvessel, David_Rothstein, catch, theborg: IE form submission button correction was buggy
#195283 by pwolanin: code documentation for the 'forms' function group
#201017 by chx: AHAH callbacks were not working for regular buttons
- Patch #204900 by webernet: code style fixes. Likely my last patch of the year. Fiew. Thanks all, and see you on the other side. :)
#194652 by Heine: specify explicit accept-charset for forms to avoid browser guessing
#195176 by chx: form_set_error doxygen was misleading
#203274 by Pasqualle: remove excessive witespace from our code (minor)
#192767 follow up by chx: array_shift() should not be called with runtime references
#192767 by fago, Eaton, chx: taking form_state per reference in form constructor function. Will be replaced with a nicer PHP 5 solution in Drupal 7.
#198579 by webernet and hswong3i: a huge set of coding style fixes, including: - whitespaces at end of lines - indentation - control structure usage - whitespace in empty lines - phpdoc comment formatting
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
XSS fixes forward ported from Drupal 5.1 - previously not committed parts of http://drupal.org/cvs?commit=53675
- Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues.
#194652 by Heine: specify explicit accept-charset for forms to avoid browser guessing
#193191 by chx: allow form elements to enable form caching - allows custom form elements to leverage the AHAH framework
#193274 by dmitrig01 and quicksketch: send submit button data with AHAH submissions
- Patch #146466 by douggreen, Steven et al: Remove temporary table usage from search module
#191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate
#190283 by myself and JirkaRbyka: use get_t() in pre-database setup code, add missing javascript key to language objects (kills notices) and document st() better
Patch #168829 by Neil Drumm: fixed link in documentation.
- Patch #168829 by Neil Drumm: fixed link in documentation.
- Patch #172097 by Eaton: improved PHPdoc of form API.
- Patch #89196 by catch, keith, earnie, webchick et al: string massaging.
#111719 follow up patch by multiple contributors: ensure proper XHTML id attribute values for form elements
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
#111719 follow up patch by chx: roll back form item ID patch
- Patch #111719 by dvessel et al: ensure clean form IDs.
#181328: pass on whole form to #process functions to enable advanced form handling (such as required by some CCK widgets)
#182178 by bragon: cols is a required attribute on textarea
#169079 by yched: improve consistency of menu API and batch API by allowing batch definition in non .module files, which opens the possibility of better performing batches (which are likely to reside in .admin.inc files generally) - apply this change in locale.module - improve batch API code documentation
Four watchdog() calls which still used t(), identified by myself after implementing extraction code for Drupal 6 at #182765
#182310 by chx: remove #DANGEROUS_SKIP_CHECK, as with the AHAH functionality now we have safer methods to add things in the cached form for validation, so we don't need this security hole possibility kept anymore.
#181741 by quicksketch: fix AHAH throbber/progress bar issues and generalize progress display configuration to allow module developers to choose from the throbber and progress bar
- Patch #172636 by chx: fixed watchdog call.
#157752 by quicksketch: extend AHAH functionality to most types of form elements, without writing JavaScript. Also AHAH enable the blocks admin page.
#145251 by chx: document that one needs to include the proper 'op' value in arrays passed to drupal_execute() to trigger the right action
#177529 by chx: if no checkbox was selected, we still need an empty array()
#172824 by yched: let the batched processes perform drupal_execute() properly
#150851 by pwolanin and chx: different radio buttons in the same set should have different HTML id values (XHTML validity fix)
- Patch #172950 by webernet: code style fixes.
- Patch #146667 by coofercat: fixed bug in form builder.
#169247 by profix898 slightly modified: fix E_NOTICE when form_id is not set on a non-programmed form
#165013 by Eaton: fix image button behaviour by processing the right values coming in the request
#85208 by neclimdul and bjaspan (slightly modified): if no maxlength was specified, do not generate an empty HTML attribute
- Patch #162708 by Eaton and Earl: add support for image buttons to FAPI3. This is a small form API extension (doesn't break existing code) that facilitates the Drupal 6 upgrade of the Views module. A good example of why it can be beneficial to start upgrading your modules early on in the code freeze. ;)
Drupal 5.2
