Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Links to DRUPAL-5-0-BETA-1: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#64280: Renamed from block.module to block/block.module
#71772 by Bart Jansens, fix various php warnings
- Patch #18018 by dww, nedjo, tostinne, luke et al: block visibility by role.
#62262 by dww, fix block help text.
#61802 by Zen, Double spaced sentences clean up
#60563, missing block name in delete dialoge, patch by Steve McKenzie
- Removing trailing whitespace.
#56813: Simplify admin/block code, and fix sorting of blocks in the listing
- Patch #52381 by Zen:
* Converts the block administration page to the fapi model.
* Removes some 'type=markup' elements.
* Adds a form_render($form['form_id']); in the theme function. Adding a form_render($form) just outputs an unthemed form. I suspect this is because of the heavy nesting of form elements and the rather dodgy array declaration, but I'm unsure.
* Documentation/language fixes.
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
- Patch #46827 by wulff: fixed incorrect links.
- Patch #36029 by asimmonds/dopry: fixed critical bug in block administration.
- Patch #46106 by markus: usability improvement: moved the block description textfield up.
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
- Patch #44163 by m3avrck: fixed typo in permission and fixed incorrect description.
- #43495: Separate permission for PHP-based block visibility
- Patch #35667 by Crell: bug fix: on ?q=admin/block style.css was imported twice.
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
- Patch #37714 by asimmonds: fixed saving of blocks.
- Patch #35524 by asimmonds / drewish: converted the custom block forms code to the forms API's execute model.
- Patch #35644 by webchick: forms API simplificiations.
- Patch #36029 by asimmonds: fixed typo that prevents 'admin - block - configure' from working.
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Removing tabs and trailing whitespaces.
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
- Patch #30801 by Allie Micka, m3avrck, 1uv4t4r et al: fixed block problems.
- Patch #30801 by Allie Micka and m3avrck: performance improvements: improved the database scheme and queries of the block.module.
- Patch #29385 by chx: no ?> add end of files.
- Patch #16216 by nedjo: multiple block regions!
- Patch #27713 by tostinni: fixed two problems on the block add page: + description field isn't marked as requiered +when the field isn't unique, an error is displayed, but the wrong text field is set as erronous.
- #27551: Rename check_output() to check_markup(). Needs contrib updates!
- Patch #26217 by HellRaider: fixed problem <front> setting in presence of slashes.
- Patch #26233 by Goba: fixed problem with block regions being buggy.
- Fixed problems with filter formats and problem with XML-RPC server.
- Patch #25603 by Stefan: made the sizes of forms consistent. TODO: document the defaults in the PHPdoc comments.
- Patch #22192 by tostinne: fixed invalid XHTML code
- Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
- Patch #21939 by Usability Poobah Chris: added missing </p> tag.
- Patch #21445 by Goba: added missing t() function.
- Patch #21353 by chx: implemented PHP-mode for blocks.
- Patch 20910 by chx: centralize print theme page.
- Improved consistency.
- Patch #19965 by Robin Monks: fixed problem with duplicate block titles.
- Modified patch #19694 by chx: makes sure that block.module deals by default only with regions 0 and 1 as it does now but lets you use block_list with any region you define. This opens many possibilites. You may do a multi region module, with your admin UI using the blocks table as storage and the block_list matcher. Or you may do a sections module using the block matcher without cluttering the current blocks list.
- #18817: Clean up plain-text checking (see drupal-devel!)
- #18939 (Stefan): Always use paragraph tags around page help text.
- Renamed some more 'region's to 'sidebar's
- Patch by Neil: fixed typo.
- Patch #18382 by Neil: usability improvement: organized the blocks on the block administration page by region. (I wanted to do that myself!)
#18329: Unify confirmation messages (and make them themable)
- Block admin usability: display block title if no description was given.
- #17868: Remove hardcoded align="center"
#17216: Restore missing "delete" link for blocks.
- Patch #16399 by James: fixed typo in block.module.
Typos.
- Code style
- Patch #16074 by Andre Molnar: add configuration option to show blocks only on pages of certain node type.
#15185: Fix front page handling of blocks
- Patch #14532 by andre molnar: tidied up some block.module code.
- Removed some cruft: left-over xxx_help_page() functions.
- Patch #14209 by nysus: improved the clarity and readability for a group of radio buttons for a block's visibility settings.
- Patch #12353 by Stefan: usability improvement: don't show 'throttle fields' unless the throttle module is enabled.
- Patch #12783 by Stefan: various small consistency/usability improvements.
- Modified patch by Jeremy: throttle module improvements and fixes: + throttle module: flush cache when the throttle enables/disables + throttle module: prevent throttle being enabled by 0 users or guests when disabled + system module: remove requirement for statistics.module + block module: update help text to reflect access log is no longer required + statistics module: throttle is now enabled/disabled, not using levels 0-5
- Refactored the throttle module. Patch by Jeremy and me. * There are only two throttle levels instead of 5, namely 'enabled' and 'disabled'. This makes it a _lot_ easier to predict when the throttle will kick in. However, if you maintain a module that is throttle-aware, it needs to be updated! * The throttle mechanism now uses the current number of anonymous users or the current number of authenticated users to kick in. This is a _lot_ more intuitive than the old throttle mechanism. * The throttle block has been removed -- you can now use the "Who's online" block to determine the good throttle settings. * Most of the documentation has been removed because it was deprecated. * It's less code!
- Patch #11875 by Neil Drumm: block module configuration improvements. The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
- Patch #10677 by drumm: removed dead code. Leftover.
#10677: Confirmation when deleting a block + unifying confirmation screens.
- Patch #11401 by Goba: documentation updates: + Made error strings in blog.module consistent. + Explained a bit better what the RSD setting is for in the blog module. + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
- #10689: Group permissions by module in UI + minor code cleanups. - Adding a drupal_goto to the block admin.
- Patch #8179 by JonBob: reintroduced menu caching.
- Patch #10622 by Adrian: fixes various PostgreSQL related problems. 1) Menu problems with Postgres (this is a highly critical 1 line fix) 2) Archive module fails with Postgres 3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch) 4) Book module fails with Postgres 5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug. 6) Creating accregator_item_table in PostgreSQL 7) Postgres - Polls not displayed on Poll Page 8) Blog module has sql errors with postgres This should not affect MySQL users (hopefully).
- #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken.
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
- Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
- Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs. Here's an overview of the changes: 1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations. The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before. The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs. 2) Filters have toggles Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it. 3) Multiple filters per module This was necessary to accomodate the next change, and it's also a logical extension of the filter system. 4) Embedded PHP is now a filter Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter. This change means that block.module now passes custom block contents through the filter system. As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters. 5) User-supplied PHP code now requires <?php ?> tags. This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code. Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal. 6) Filter caching was added. Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table. 7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists. 8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
- Patch #9330: ucfirst() gives problem when used with multibyte charset. Replaced the use of ucfirst() with a CSS-based solution.
- Oopsie when committing.
- Cleaning up the rediculously long 'if' statement for checking block visibility. - #9811: Remove session ID before matching block path
- Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
- Simplified the block help a bit by removing some dated information. It should be simplified more.
- 'add block' -> 'add'
- More tab-improvements by JonBob: improved support for the default tabs!
- Patch #8975 by drumm: remove block placement preview. Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site. Anything else that can be removed? Less is more.
I refactored quite a bit of the user.module: $ diffstat user.patch database/database.mysql | 4 database/database.pgsql | 2 database/updates.inc | 10 - modules/block.module | 20 +- modules/locale.module | 9 modules/profile.module | 108 +++++++---- modules/system.module | 8 modules/user.module | 456 +++++++++++++++++++----------------------------- 8 files changed, 289 insertions(+), 328 deletions(-) More functionality, less code. Here is a list of the changes: - Some user API changes: + When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'. + A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.) - The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages. - Profile module improvements: + Added support for private fields to the profile module! + Improved workflow of profile administration pages. + Improved the form descriptions. - Code improvements: + Unified user_edit() and user_admin_edit(). + Unified and cleaned up the validation code. Fixed some validation glitches too.
- Patch #8708 (modified) by Stefan: refactored the 'add new block' form a but.
- Patch #8681 by stefan: fixed some broken URLs and help texts.
- Patch #8598 by cetron: fixed typo in the help text: 'shuold' -> 'should'
Tabs patch!
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
- Patch #8234 by mathias: using block path with Drupal subdirectory installs.
- Code improvements by JonBob. Thanks.
- Fixed missing block selection on user edit page.
- Code improvements by JonBob. Thanks again.
- Added support for 403 handling. Patch by JonBob. As a side benefit, administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
- Patch #6725 by TDobes: update block module _user() hooks.
Patch 6523 by Steven: - Strips the leading / from URLs to match with block paths. The reason is that everywhere else in Drupal, we use URLs without leading slash (e.g. URL aliasing). For consistency we should keep this behaviour everywhere. The replacement uses ereg_replace instead of str_replace, but the expression now only match the beginning of the URI so in fact it's faster, esp. for longer URIs. - Updates the block docs about path matching: gets rid of leading slash, adds initial matching operator '^' and emphasises the slash behaviour (which was not mentioned anywhere before) - Replaces the example expression for a negative match. It was horribly broken and odd, the replacement in this patch is correct and simpler.
- Patch #6543 by Michelangelo: block path matching breaks when clean URLs are disabled.
- Restored the old block path behavior.
Fixed an apparently old bug which always defaulted user-togglable blocks to off, and clarified the explanation a bit.
- Patch by Steven: removed redundant permission checks. These are no longer required thanks to the new 404 handling.
- Batch two with profile module improvements: + Reworked the 'account administration' page. + Fixed bug in the 'edit account' page. + Removed some dead code from the system.module.
- First batch of profile module improvements:
+ Tidied up the profile configuration page: grouped form elements.
+ Tidied up the block configuration settings: removed hard-coded
table.
+ Changed the profile API to return the preferred group name, and
changed the user module to group settings. Modules implementing
the _user hook will need to be udpated.
+ Removed register_form and register_validate for now.
Patch 5287 by Stefan: multiline help texts should become inside a single $output.
Patch 5187 by Goba: - puts the long multiline help text into one string - fixes the ambiquity of calling two things on the same name: "custom block" now the user customizeable blocks are called custom blocks, and the admin defined blocks are called Administator Defined Blocks - added info on throttle to the explanation on when a block is displyed - also fixing some small typos
- Removed instances of the 'throttle_enable' variable.
- Patch #5184: fixed block path and aliases. Patch by Nick.
- Patch #5021: clean up URLs in _help texts. Patch by UnConeD.
- XHTML improvements: <b> -> <strong>. Patch by Stefan.
- Tidied up some inconsistencies in the code: scripts/code-style.sh is your friend.
- Tidied up the DoxyGen comments. Patch by Kjartan.
- Patch 0185 by Jeremy: made it possible to automatically disable modules when under heave load.
- Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc.
- Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
- modules: status() is no more; use drupal_set_message() instead.
- themes: use drupal_get_message() to check for status messages and
visualize them.
- More throttle improvements. Patch by Jeremy.
- Bugfix by Jeremy.
- Made it possible to auto-throttle blocks. That is, blocks can be configured to be disabled when under excessive load. Patch by Jeremy.
- Committed phase 4 of JonBob's menu system changes.
Patch by Ax to fixe and improve to the core doxygen PHPdoc:
* fixes all doxygen warnings [#]_ in the current code base
+ changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc)
+ documents all undocumented parameters
+ escapes / fixes html warnings
+ fixes @defgroup in theme.inc
* adds more groupings [#]_
+ drupal_{set|get}_title, drupal_{set|get}_breadcrumb
+ pager.inc: pager_api (pager_query(), pager_display()), pager pieces
* adds a new group "themeable" which contains all themeable functions.
- Patch by JonBob: Phase 2 of the menu system integration project. This unifies the interface used by admin and non-admin pages, and deprecates the _page hook in favor of explicit callbacks from menu(). Breadcrumbs, titles, and help text go away as a result of this patch; they will return in the phase 3 patch, printed by the theme.
- Block and theme improvements. Patch by Ax.
+ block_list() (in block.module): returns an array of block objects for
$region.
+ theme_blocks() (in theme.inc): uses block_list() and theme("block") to
actually render them.
Advantages:
+ Decouples blocks content and layout, allows block_list() to be used
for non-output purposes (think "pull").
+ Unifies naming in theme.inc: render_blocks()) didn't really fit there.
+ Puts block_list() in blocks.module where it logically belongs.
- Removed some cruft from the Xtemplate theme. Patch by Ax.
- table(...) -> theme("table", ...)
- Usability improvement: replaced many selection boxes by radio buttons. Patch by Stefan.
- Committed part 3 of Michael's help system improvements: removed the $help parameter from the menu() function.
- Help system improvements: eliminated the _system hook. Patch by Michael. - Bloggerapi module fixes. Patch by Kjartan. - Coding style fixes. Patch by Michael.
- Bugfix: the block module's help was not being displayed. Patch by Gabor.
- Help improvements and translation improvements from Michael. Thanks!
- Block module fixes. Patch by Kjartan.
- Translation improvements for the block module help. Patch by Gabor.
- More translation fixes for the menu items. Patch by Gabor.
- Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
menu.
2) The user module part of the patch did not apply due to Kjartan's earlier
patch.
- Committed the admin menu integration patch. Thanks Adrian, Stefan and others.
- Committed a partial administration page integration patch.
- Fixed bug #2689. Patch by Bruno.
- Documentation fixes by Michael F.
- Block module documentation improvement. Patch by Gerhard.
- Help system improvements from Michael.
- Committed a slightly modified version of Slavica's table prefix patch.
- Bugfix: fixed calendar block caching. Patch by Al. Fixes bug #2131. - Improvement: improved the block module documentation. Patch #59 by Gerhard.
*** empty log message ***
- Bugfix: renamed "create PHP content" to "create php content". Reported by Simon, patch by Gerhard. - Improvement: synchronized the import module help with the version on drupal.org.
- Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al. - Bugfix: fixed translation problems in the user module and the block module. Patch by Stefan. - Improvement: made it impossible to delete user role #1 and #2. Patch #38 by Al. - Improvement: fixed the "Allowed HTML tag" issues. Makes for better code and improved usability. Patch #35 by Al. NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
- Improvements: XHTML-ifications. Patch by GmbH. See feature #1813.
- Improvements: XHTML-ifications. Patch by GmbH.
- Documentation improvements: improved and updated the block module documentation. Patch #44 by Al. We should add some real-life path examples! - Fixed the "blog it" image size. Patch #49 by Al. - Some SQL performance improvements to the forum module. This should also be more PostgreSQL safe. Patch by me. mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0; ==> 0.63 sec changed to: mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0; ==> 0.00 sec
Fixed some typoes...
- Michael Frankowski's excellent help text improvements!
- Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski. - Fixed a typo in the MSSQL database scheme. Patch by Michael Frankowski. - Removed dependency on "register_globals = on"! Patches by Michael Frankowski. Notes: + Updated the patches to use $foo["bar"] instead of $foo['bar']. + Updated the INSTALL and CHANGELOG files as well. - Tiny improvement to the "./scripts/code-clean.sh" script.
- Applied Michael Caerwyn's "%s -> %d" patch. - Changed all occurences of '%d' to %d as suggested on the mailing list.
- Added some missing quotes.
- Applied modified version of Al's "block delta" patch. I left out the blogroll feature as I think it would get very confusing. I don't mind to add it but it need some thought and documentation as it somewhat conflicts with the existing cloud module. These changes require you to run update.php.
- Fixed some SQL query directives.
- Fixed typo in the block delete link. Reported by Paul C.
- New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
* glossary module
* feed module (Breyten's version)
* mailhandler module
* notify module
* project module
* smileys module
* admin module
* style module
* taxonomy_dhtml module
To avoid unexpected problems menu_add() is deprecated (it will print an
error message when used) and menu() should be used instead.
- Everything is using theme("function") now instead of $theme->function().
- Tidied up XHTML. Patch by Ulf. - Added missing t() function. Patch by Stefan.
- Clean URL patch.
- Bugfix: some variables were not being reset causing wrong links to be displayed. Patch by Ax.
- Tidied up the use of check_output(). Might make rendering pages a bit snappier (performance improvement).
CHANGES: - Usability improvement: made the block administration pages use the new table rendering functions. By the way, the old code rendered invalid HTML code. - Usability improvement: saving block changes will now show a status message. - Usability improvement: quite a few strings could not be translated. TODO: - I think the "enabled" and "custom" field are somewhat confusing. Suggestions?
- Refactored the administration pages.
* Applied slightly modified version of Marco's taxonomy patch: - Fixed a bug with get_tree and multiple parents. - Fixed 3 wrong caches (this will avoid some queries). - Extension to taxonomy_term_count_nodes() (feature #159): "currently calling taxonomy_term_count_nodes() returns the amount of nodes in each term, would it be possible to extend this function so that it would only return the amount of nodes of a certain type under each term. - Confirm deleting a vocabulary or a term (requested by Moshe). - Use form_weight() in vocabulary and term forms. - After submitting a term, we end up at the term page (requested by Moshe). - Added status messages when adding, editing and deleting vocabularies and terms - Minor clean ups * Made sure all modules use the same link delimiter; "|" for now.
- changing case for consistency.
Patch based on work of Kjartan: - Changed cache API. - Fixed caching bug in comment.module. Odd this hasn't been reported yet. - Fixed caching bug in forum.module. - Fixed caching bug in system.module. - Fixed caching bug in block.module. - Simplified caching support in forum.module thanks to improved cache API.
- Fixed bug in block module: "Array" was displayed on the user information page.
- Fixed glitch in block module: the admin links were not composed
correctly. Patch by Stefan.
- Added missing t() functions and improved the %x directives for
better readability and to ease the process of translating your
site. Patches by Stefan.
- Made two small additions to the 'code-clean.sh' script; it will
now remove patch related junk.
NOTES:
- I removed the · related bits. Let's tackle these later on
in a separate patch after we got some sort of consensus.
- I removed the 'module_exist("drupal")' check in the user module;
I *think* it is incomplete and therefore incorrect.
- Stefan, try using quotes in your translations and check whether
everything still works. Example: translate the "Create account"
button to "Create \"haha\" account \'hihi\'" and see if you can
still create new accounts. Maybe automate this using a quick
hack in the locale module ...
- Made sure blocks are sorted by weight. Patch by Ax.
- Committed Marco's block rewrite:
+ Blocks are not longer called if not rendered: major performance
improvement.
+ Fixed some bugs (preview option was broken, path option was broken).
+ Removed "ascii"-type blocks.
+ Added permission to for "PHP blocks"
+ ...
NOTES:
+ You'll want to run "update.php":
ALTER TABLE blocks DROP remove;
ALTER TABLE blocks DROP name;
+ You'll want to update your custom modules as well as the modules in
the contrib repository. Block function should now read:
function *_block($op = "list", $delta = 0) {
if ($op == "list") {
return array of block infos
}
else {
return subject and content of $delta block
}
}
- removed function module_rehash(). - updated database dump. - removed tables modules, layout and referrer (don't forget to backup!).
- fixing block configuration not working when user is disabling all blocks.
- Applied Axel's patch to sort blocks by weight.
- Changed a " drupal " into " Drupal ".
- improved module descriptions. - removed admin options for queue and comment module if the modules are not loaded. - nodes are now auto promoted when queue module isn't enabled. - moderation result block is now visible by the node author.
- adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
* security check isn't in effect if the db hasn't been updated.
* instructions re-organized.
* fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
- Added missing translations and the like.
- applied Stevens link patch. - fixed block permissions. - fixed user admin page errors: http://www.drupal.org/node.php?id=173. - cleaned up common.inc a bit: removed format_info, path_img, field_merge.
- changed block, module and theme config pages to use checkboxes. - coding style clean ups. - fixed taxonomy causing errors.
- user.module used a obsolete variable_get. - set blocks for new users.
- changed from a select to checkbox on edit account page. - added a basic help text.
- small update .htaccess, fixed the blog link. - some interface changes in block admin page.
- merged block and box modules. modules/box.module should be removed
or disabled as it will cause errors otherwise.
- split status into status and custom. Status will turn the block
on/off, and custom defined if the user can change the status.
Requires sql update.
- reintroduced user page to configure blocks.
- Bugfix: solve problem with locales being "disabled". Reported by Jerritt, fixed by Marco.
- bug fixes:
* fixed mails not being parsed properly.
* tracker now shows user name when you view your own recent
comments.
* link to submission queue now points to the right place.
* fixed jabber module.
* theme is now activated when changed.
- applied Gerhards coding style patch.
- Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.
+ Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.
+ XHTML-ified some HTML.
+ Wrapped a lot of text in the administrative pages in a t()
function.
+ Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().
+ Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
RSS code).
+ Fixed some bugs in the taxonomy module (eg. tree making bug), added
new functionality (eg. new APIs for use by other modules), included
Moshe's taxonomy extensions, and some documentation udpates.
+ ...
code-style.pl - allow $var++ and $var-- syntax. update.php / block.module - cleaned up coding style, and trailing spaces.
- A large batch of updates, amongst them a rewritten node system. More information available on the mailing list.
- added a path field to the blocks. Its a regexp to define which pages you want the blocks to show up on. - updated the help. - did some XMLification. - SQL update script has a new table collumn which needs to be applied.
- added the CVS keyword $Id$ to all files to make future version tracking easier. Also changed the <? tag to <?php in some cases.
- Removed a node's link ID (lid) as discussed on the mailing list. See 'updates/3.00-to.x.xx.mysql' for the required MySQL updates. - Renamed some "author" fields to "uid" fields for sake of consistency. - Fixed the coding style of some PHP files. - Fixed the moderation queue (fairly untested though). - Re-introduced the temporary SQL table in _node_get(). - Added a missing 'auto_increment' to 'updates/3.00-to-x.xx.mysql'.
- various small updates: + fixed 2 small HTML typos in meta.module + better watchdog messages in comment.module + fixed typo in block.module
Extremely large commit: - Fixed tiny quote problem in account.php. - Fixed tiny bug in comment.inc. - Fixed tiny bug in comment.module. - Fixed tiny bug in meta.module. - Simplified user_access() API. - Rewrote link system: still needs fine-tuning and testing so don't upgrade if you are running a production site. ;) Updated all modules and themes to reflect this change. All other themes and modules need updating too!
- Small but significant improvements to block and box.module which makes the ever-confusing "rehash modules" (see module.module) no longer needed, hence making module.module redundant. :-) - Removed module.module. - Renamed conf.module to system.module, and added some information about the available modules to system.module. - Various small changes.
- Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).
+ Once installed, click the help-link for more information.
+ See updates/2.00-to-x.xx.sql for the SQL updates.
- Modified loads of code to use our new access.module. The system
still has to mature though: new permissions have to be added and
existing permissions need stream-lining. Awaiting suggestions.
- As a direct result of the new access system, I had to rewrite the
way the top-level links in admin.php are rendered and displayed,
and xhtml-ified admin.php while I was at it.
TODO
- Home-brewed modules need updating, home-brewed themes not.
(Examples: file.module, trip_link.module)
- As soon we *finished* the refactoring of the user system (KJ has
been working on this refactoring already) we should consider to
embed this role and permission code into account.module ...
- block.module:
+ renamed 'overview' to 'preview' as suggested by Kristjan.
- meta.module:
+ renamed 'verify' to 'preview' to make it consistent with
block.module.
+ fixed comma-bug with attribute list reported by Kristjan.
- node.module:
+ fixed typo: "id$nid" should have been "id=$nid"
- Made the main page display sub-topics when a specific topic is selected. - Made theme_link() less "hard coded", we still have to make it fully configurable though. - Fixed glitch in story submission: the warning messages were not displayed. - Tidied up block.module a bit.
- Uhm. Rewrote the module system: less code clutter, less run-time overhead, and a lot better (simpler) module API. I had to edit a LOT of files to get this refactored but I'm sure it was worth the effort. For module writers / maintainers: None of the hooks changed, so 95% of the old modules should still work. You can remove some code instead as "$module = array(...)" just became obsolete. Also - and let's thank God for this - the global variable "$repository" has been eliminated to avoid modules relying on, and poking in drupal's internal data structures. Take a look at include/module.inc to investigate the details/changes. - Improved design of the content modules "story", "book" and "node" (to aid smooth integration of permisions + moderate.module). I'm still working on the permissions but I got side tracked for which I "Oops!".
A lot of small changes (search-n-replace) make a big commit: - fixed update bug in book.module - provide a log message when both adding and updating book pages - all configurable variables are now accessed through "variable_get()": - rewrote watchdog and submission throttle and removed watchdog.inc - improved robustness of sections.inc - imporved story.module - updated ./database/database.sql
- applied David Norman's patch to turn all <?'s into fully qualified <?php's.
A rather large and important update: revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks). For drupal's sake, try to screw something up. See the mail about PHPNuke being hacked appr. 6 days ago. The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required). I beg you to be evil. Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
- documentation updates contributed by Michael O'Henly <michael@tenzo.com> and myself
- removed redundant spaces
- rewrote the block placement stuff and updated the themes.
IMPORTANT: you have to drop 2 tables "blocks" and "layout"
and you have to recreate them again with those
in database/database.mysql
- integrated the documentation written by UnConeD
Surprise, surprise. After nothing but code, a large batch of changes: - removed droplets - added (optional) admin_blocks module - added (optional) affiliate module - added (optional) about module (only placeholder, under construction) - fixed some tiny bugs (e.g. quote bug in search.php) - partionally rewrote some modules to be big, bad and better - partionally rewrote some modules to be more uniform - added GNU GPL license to CVS Also: - installed PHP 4.0.4 on my localhost and now working towards PHP 4.0.4 compatibility. - I think I'll baptize the engine "drupal". If you have a better idea, try convincing me ASAP. Todo: - more testing (also with PHP 4.0.4) - make "project"-module: download, info, blah blah - complete documentation
- some improvements and code polishing - added a few extra blocks to choose from
- intermediate updates
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, select a symbolic revision name using the selection box, or choose 'Use Text Field' and enter a numeric revision.
| ViewVC Help | |
| Powered by ViewVC 1.1.2 |