Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#633134 by arianek and jhodgdon: Update Book Module to new help documentation standards.
- Patch #583730 by sun: fixed form caching.
Roll-back of #595084; type-hinting parameters at stdClass makes it so you can't ever pass in another type of class.
- Patch #607244 by sun: added permission to decrease performance impact of contextual links.
#552478 by pwolanin, samj, dropcube, and sun: Improve link/header API and support on node/comment pages rel=canonical and rel=shortlink standards.
- Patch #595084 by c960657: use type hinting for .
#600974 by effulgentsia, JohnAlbin, sun, and Damien Tournoud: Allow theme functions to take one argument without any hacks. NOTE: This is an API change in hook_theme().
- Patch #599804 by effulgentsia, catch: unify page, AJAX 'path', and AJAX 'callback' callbacks. Oh my, this is the beginning of something big.
#557292 by peximo, plach, catch, and yched: Convert node title to Field API.
- Patch #572618 by effulgentsia, pwolanin, sun: all theme functions should take a single argument. Code clean-up and performance improvement. Woot.
- Patch #578520 by sun | c960657, mfb, Dries, catch, mattyoung: make in url() only accept an array. Another nice API clean-up!
- Patch #550718 by alexanderpas, Gábor Hojtsy | Dries, webchick, ugerhard: tabs on admin pages are not accessible from overviews and menus.
- Patch #283723 by pwolanin, sun | eddified, moshe weitzman, Dries, aether, Arancaytar: Added Make menu_tree_output() return renderable output.
#564632 by moshe weitzman: Unify various _build() functions and remove duplicate copy of content.
- Patch by #565496 by dropcube, pwolanin: changed Allow dynamic attaching of other types of stuff to render() structures.
- Patch #495968 by Frando, moshe weitzman: added drupal_render() cache pattern. Start using it for blocks.
- Patch #560746 by dropcube: rename hook_block_list() to hook_block_info() for consistency in the API.
#509584 by pwolanin: Various API fixes for menu_tree_data() including depth param.
#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.
Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.
*** empty log message ***
#326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: Convert 'class' attribute to use an array, not a string.
#544418 by merlinofchaos, sun, drewish, quicksketch, et al: Integrate CTools AJAX framework with Drupal to extend (and replace) existing ahah framework. Everything about AJAX/AHAH is more betterer now.
#545306 by alexanderpas: De-op hook_node_type().
- Patch #536768 by chx: use the database to do type casting so we can clean up some code. ;-)
- Patch #535564 by Gábor Hojtsy: the D7UX mockups call for a top level Content item, which would immediatey lead to the "Find content" screen. The current Drupal 7 code is almost there, but still has an RSS settings item blocking the implementation of this by default and aggregator and book also add subitems.
- Patch #521474 by bangpound, JuliaKM et al: rename admin/site-building to admin/structure.
- Patch #506976 by catch: rename hook_perm to hook_permission.
#373201 by moshe weitzman, chx, Frando, eaton: Allow renderable array properties to be passed directly to theme functions.
- Patch #409750 by yched et al: overhaul and extend node build modes.
- Patch #372743 by bjaspan, yched, KarenS, catch et al: node body and teasers as fields. Oh, my.
- Patch #480412 by JamesAn: converted to drupal_static().
- Patch #472642 by stella, agentrickard: remove 'implementation of' nominalizations from Docblocks.
Drupal 5.18
- Patch #457532 by Berdir: more PHP5 'fixes'.
- Patch #449718 by alienbrain: node_feed() is now using new node building API.
- Patch #361529 by j.somers: illogical syntax for book_toc().
#444920 by Damien Tournoud: Fix broken book breadcrumbs (with tests).
#323112 by dmitrig01, kkaefer, quicksketch, frando and many many more: Now presenting... Vertical Tabs. Fantastic new UI improvement for node forms and hopefully more in the future.
#408562 by BruceBGordon: Code clean-up.
#383066 by David Strauss: Rename hook_nodeapi_X to hook_node_X.
#203323 by JirkaRybka, robertgarrigos, lilou, thePanz, c960657, sun: move the LANGUAGE_* constants to bootstrap.inc and remove several defined() checks on them now that they are always defined
#125030 by kkaefer, quicksketch, dvessel, Steven, and John Resig: Allow compatibility with other JavaScript libraries.
- Removing whitespace.
#203323 by JirkaRybka, robertgarrigos, thePanz, c960657, and sun: Fix undefined index locale in install.php and clean up crufty code.
- Patch #352054 by catch: convert calls to db_placeholders() in static queries.
- Patch #302207 by John Morahan et al: updated book module to new DB layer.
- Patch #349504 by keith.smith: clean up sentence spacing in code comments.
- Patch #323528 by jhedstrom: fixed alias usage in queries for PostgreSQL.
- Patch #345866 by alexanderpas, justinrandell, Dave Reid: remove from hook_block().
- Patch #339929 by Moshe et al: move node links into ->content.
- Patch #319356 by recidive: clean up hook_nodeapi_ fucntion signatures and documentation because of previous node API clean-ups.
- Patch #324313 by catch et al: load multiple nodes and terms at once.
- Patch #74645 by drewish, roychri et al: modify file_scan_directory to use a regex for the nomask (and code clean-up).
- Patch #302207 by John Morahan: converted book module to the new database abstraction layer.
- Patch #319666 by Dave Reid: remove unnecessary boolean ternary conditaionals.
- Patch #232095 by birdmanx35, keith.smith: improve book module description.
#313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names
- Patch #310212 by justinrandell: killed in _node hook, as well as twelve sable tooth tigers.
- Patch #161301 by Eaton, Sun, moshe and webchick: make checking for node edit forms easier. DX improvement.
#108979 by ewhipple, catch, and sun: Order permissions consistently, keep node type related permissions together.
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
- Patch #276846 by pwolanin: fixed malformed cid.
- Patch #276846 by pwolanin: mailformed cid due to fauly menu item.
- Patch #251239 by pwolanin: revert.
- Patch #257730 by Senpai: code clean-up for book module.
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit et al. Can you say 'registry'? Drupal now maintains an internal registry of all functions or classes in the system, allowing it to lazy-load code files as needed (reducing the amount of code that must be parsed on each request). The list of included files is cached per menu callback for subsequent loading by the menu router. This way, a given page request will have all the code it needs but little else, minimizing time spent parsing unneeded code.
- Patch #253022 by beginner: fixed typo in code comments.
- Patch #253022 by beginner: fixed typo in code comments.
- Patch #251239 by R.Muilwijk: performance improvement.
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
- Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php. The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:
block-user-0.tpl.php --> block-user-navigation.tpl.php
block-user-1.tpl.php --> block-user-login.tpl.php
You get the picture.
#231587 by pwolanin, killes: (performance) use two level cache in menus, instead of storing very large amounts of data multiple times
- Patch #231587 by pwolanin et al: fixed scalability issue in the menu system.
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
- Patch #221057 by pwolanin: book module may overwrite another node's link.
#221057 by pwolanin: make sure existing node mlid's are not overwritten on node cloaning
- Patch #215858 by pwolanin, goba, catch et al: localized menu link data getting saved back to the database.
#215858 follow up by pwolanin: fix a fatal error in book module breadcrumb creation (critical)
#207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks
#205075 report by ktabuer, patch by myself, testing by ktauber and Lynn: book block throws notice when used on non-book-node page (with a little bit of code cleanup)
#203274 by Pasqualle: remove excessive witespace from our code (minor)
#202425 by keith.smith: standardize reference to block placement page as 'blocks administration page' to avoid any confusion
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
- Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues.
- Patch #192736 by quicksketch et al: drag and drop for book module.
#191360 by chx: allow contributed modules to override the book and menu parent selectors (to improve usability and performance)
#160200 by dvessel and chx: better theming support for book module
#100569 by keith.smith: improve explanation of what a book is about (in book.module)
#181125 by quicksketch and dmitrig01: AHAH usability improvements for book module - book outline form reordering in real-time - better context sensitive book parent editing
#172840 by Crell: break up book module to improve performance
- Patch #172961 by webernet: code style cleanup.
#111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7
#111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op)
- Patch #145218 by profix898, bennybobw, Crell, forngren et al: use href instead of @import for CSS.
#165675 follow up patch by pwolanin: retain menu information on node previews to check, do not use the newly selected values yet, to be consistent with the DB
- Patch #80951 by killes, yched et al: block caching.
#166913 by pwolanin and webernet: fix book outline removal confirm form parameters and improve user documentation
#165675 by pwolanin: only show allowed parent items in menu/book select fields to avoid going deeper then what is allowed
- Patch #154470 by pwolanin et al: optimize menu queries and indices.
#160039 by prakashp, chx and pwolanin: fix node saving: - centralize/reuse some node form saving code - fix uploads without JS - fix reappearing teasers on node save
#164348 by pwolanin: improve book block performance
#164545 by pwolanin: fix call time pass by reference warning
- Patch #146425 by pwolanin et al:
* Removes the hard-coded 'book' type and perform all node actions
equally on any node type via hook_nodeapi.
* Achieves 100% integration with the menu system. Improves
performance of book rendering.
* All the algorithms have been changed to use the tree data structure
returned by the menu system.
* Added support for 'multiple books'.
* Some UI improvements.
This is a momumental patch that took 69 iterations. Although there is
room for improvement, this is a big step forward. Thanks for the
persistence, pwolanin.
- Patch #142157 by xqus: fixed problem with l() conversion.
- Rollback of patch #147723: delete API. Talked to Steven and Gabor and we unanimously agreed to rollback the deletion API. We all support the features this patch added, yet not its actual design and implementation. After some talk, we decided that it would be better for Drupal -- in the long term -- not to go with a solution that isn't 100%. We also recognize that in the short term, this patch would have been useful addition. So let's figure out how we can implement this properly in D7.
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
- Patch #153364 by webernet: notices and RTL issue with book.module.
#147723: Deletion API (by hunmonk). Woop woop.
#145737 follow up patch by yhager: include right to left styles for print.css
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
- Patch #76588 by Gabor: made log messages translatable. Yay.
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
- Patch #107061 by Steven et al: add jQuery teaser splitter.
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
#130971: Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
- Patch #114745 by moonray: book module: can't remove top-level node.
- Patch #128081 by Eaton: remove #base, paving the path for a simpler form API.
#114745 by moonray. Fix a sloppy if condition.
- Patch #113603 by chx: first crack at re-implementing tabs.
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
- Rollback of E_ALL patch. Too much extra breakage.
- Patch #112715 by webchick et al: fixed some E_ALL errors.
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
#107443 by webchick. Proper . placement.
- Patch #107306 by webernet: fixed incomplete break-tag clean up.
#100963 by Eaton. Use new pattern for node rendering in printer-friendly version.
#26552 by Heine. Add child page to unpublished book nodes doesn't work, so remove the link.
#100350 by dvessel. Adda missing <p> tag.
- Patch # #98366 by webchick and ac: simplified strings for translators.
- Patch #97889 by pwolanin, webchick et al: book documentation improvements.
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
- Patch #93678 by chx: book module not updating the database properly.
#87474 by webernet. Move the log message field from book to node module.
#72467 by m3avrck. Better display for long book page and forum topic titles.
#90395 by joshk, mj2308, and kkaefer. Fix book outline saving.
#84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc
- Patch #84117 by misawie: make book outlining work with PostgreSQL.
- Patch #83397 by edkwh: -> . Getting rid of super-globals.
#83494 by edkwh. Fix the book outline.
- Patch #75465 by chx: fixed Doxygen of book.module.
- Rollback of patch #68418: clean up node submit hooks. Needs more thinkering. Restores the old node API.
- Patch #80952 by earl, webchick, neclimdul et al: .info files
- Patch #68418 by Moshe et al: clean up node submit hooks.
#4074 by riccardoR, save the book weights if they aren't editable.
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
#76802: Introduce placeholder magic into t() See: http://drupal.org/node/64279#t-placeholders
#39124 by dww. Don't default the log message to the last log message.
#77183 by m3avrck and timcn, split up drupal.css by module.
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing. Once again, we're paving the path for CCK in core ... :)
- Patch #72343 by dww: removed stray status message.
- Patch #77422 by timcn: corrected various paths in the documentation.
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
#73884 by RobRoy, various code cleanup.
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
#73605 by RobRoy, make hook_link() implementations consistent with documentation.
- Patch #72343 by Chris Johnson: removed checks for the moderate-flag from the SQL queries.
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
#71925 by Steven, remove # prefix from link array keys.
- Patch #71014 by fgm: fixed the parent navigation link.
- Patch #71014 by fgm: fixed the parent navigation link.
#71613 by keve, fixing some PHP notices in the book module. , backport from Head
#71613 by keve, fixing some PHP notices in the book module.
#69151, book_export_html is not themeable and the html page title is not set., patch by Flanker, backport from HEAD.
- Patch #69151 by flanker: make exported book pages themeable.
- Patch #67229 by dww and chx: cleaned up book_load().
- Patch #67229 by dww: cleaned up book_load().
- Patch #67229 by chx: cleaned up book_load().
- Patch #66991 by dww and killes: infinite recursion in book_location_down() when there are multiple revisions.
#66991, infinite recursion in book_location_down() when there are multiple revisions, patch by dww, modified
#46290 by Neil, Egon, et al: when deleting a book page under 'orphan pages' we are returned to the homepage, backport from HEAD
- Patch #46290 by Neil, Egon, et al: when deleting a book page under 'orphan pages' we are returned to the homepage.
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
- Patch #60224 by rkerr: one page book showing another book in navigation links.
- Patch #60224 by rkerr: one page book showing another book in navigation links.
#61802 by Zen, Double spaced sentences clean up
#61696 by Zen, book module: Missing t()
#61696, missing t(), patch by Zen
- Removing trailing whitespace.
#58539, removed duplicate menu item, patch by Markus Petrux
#56105, remove title validation, already enforced by #required, patch by Moshe
#53826, Book export: db_rewrite breaks sql query., patch by puregin
#55493, Editing an existing book page kills Drupal, patch by chx
#54565, cannot remove pages from book outline. Patch by Zen.
#50987: book next link breaks with php 5.1
#50987: book next link breaks with php 5.1
#53956: Don't allow moving away top-level book pages if you cannot move them back.
#11206, Editing a top level book page inadvertently changes parent, patch by chx.
- sa-2006-002: XSS issues with username
- sa-2006-002: XSS issues with username
- Patch #50821 by Zen/merlinofchaos: convert book.module to form API so the forms can be altered/themed.
- #47844: Book module doesn't delete table entry for nodes added to outline.
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #49131 by puregin: refine book permissions.
- Patch #47098 by JonBob: fixed book navigation divs when book has no child pages.
- Patch #47066 by Zen: removed dead code.
- Patch #46827 by wulff: fixed incorrect links.
- Patch #46400 by m3avrck: clean up book navigation markup + UI improvements. (Hint: the forum module has previous and next links too.)
- Patch #45706 by markus: keep up with CSS improvements.
- Patch #45706 by markus: keeping up with CSS improvements.
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
- Patch #45301 by Morbus: corrected the weight of form item titles of nodes.
- Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions.
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
- Patch #31323 by Gerhard: delete extra data when a revision is deleted.
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
- Patch #1482 by djun: we're moving the DocBook output to a contributed module. It's not a core feature.
- Patch #38296 by Tobias Maier: fixed bug with book links.
- Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms.
- Patch #38611 by Neil: redo book administration. The book module's current administration is actually a patchwork of one form per book page crammed into a table with another form at the bottom. This simply didn't work.
- Patch #38296 by Ber: generate rel-tags for book pages. Makes it easier to browse in some browsers.
- Patch #35644 by webchick: forms API simplificiations.
#36791: node_validate was called twice
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #34920 by tangent: reorganized the node submission form a bit.
- Patch #34932 by tangent: fixed the placement of the 'log'-textarea on book preview pages.
- Patch #33220 by Tobias: improved themeability of book module.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Patch #27999 by Tobias: made book export functionality configurable.
- Removing tabs and trailing whitespaces.
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
Improved error-handling of book module.
- Patch #32584 by Gerhard: removed reference to node_revision_load() and fixed input validation error..
- Patch #10056: allow the node title forms to be customized.
- Patch #31496 by Goba: added missing $node object in book export.
- Patch #30308 by gordon: fixed broken SQL query.
- Patch #7582 by Gerhard: improved node revisions! All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created. TODO: 1. Provide upgrade instructions for node module maintainers! 2. Upgrade modules that implement node types. 3. Provide an upgarde path for revisions. Dependency on the upgrade system.
- Renamed _node() to _node_info()! We reserve _node for _nodeapi.
- Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
- Patch #29385 by chx: no ?> add end of files.
- Patch #25706 by Neil: book 'previous' link does not respect unpublished node setting
- Patch #25706 by Neil: book 'previous' link does not respect unpublished node setting
- #27707: Use local tasks for book administration
- #26688: Add mbstring support to Drupal and clear up string handling fuzzies.
- #27108: Columns in ORDER BY clause must be SELECTed on (pgsql)
- #27108: Columns in ORDER BY clause must be SELECTed on (pgsql)
- Patch #24805 by Ber: removed some dead code.
- Patch #25634 by chx: simplified node_load().
- Patch #25928 by Uwe: 'the the' -> 'the'.
- Patch #25928 by Uwe: 'the the' -> 'the'.
- Patch #25603 by Stefan: made the sizes of forms consistent. TODO: document the defaults in the PHPdoc comments.
- Patch #25504 by kumo: fixed problem with the weights of book pages not being remembered.
- Patch #25504 by kumo: fixed problem with the weights of book pages not being remembered.
- Patch #1898 by Djun: more book module improvements including but not limited to OPML export functionality, better code comments, better help texts, etc.
- book_render() was broken after a faulty commit. Adding back. See: http://cvs.drupal.org/viewcvs/drupal/drupal/modules/book.module?r1=1.294&r2=1.295
- Modified version of patch #1482 by Djun: This patch enables export of books as XML documents. The XML is DocBook "at the level of structure", but node contents are wrapped as CDATA, since we can't be sure that the contents are valid XML. Several other bugs/feature requests are also addressed with this patch: - Fixes bugs http://drupal.org/node/1898 http://drupal.org/node/1482 http://drupal.org/node/8049 http://drupal.org/node/1899 Should go a long way towards implementing feature request http://drupal.org/node/2062 It should also be easy to extend this to produce OPML, for example. - Adds about 170 lines, of which more than 100 are comments - Added doxygen comments - Made doxygen comment format consistent; fixed minor grammatical slips - A proper Doctype and more informative HTML element is generated for printer-friendly HTML output. - Refactored book_print() to use book_recurse(). - Refactored book_recurse(). Applies 'visitor' callback functions to nodes during weight/title order tree-traversal. The parameterized visitor callbacks can be used to generate different kinds of output. There are many other kinds of operations on books which can be implemented by writing a pre-node/post-node pair of callback functions: word-count/ statistics gathering, comparison, copying, search and replace... - Introduced book_export() which uses book_recurse() to generate DocBook-like XML to export book contents in a structured form. An md5 hash is computed for each node to help import code to decide if a node needs to be updated or not.
- Patch by factoryjoe: made printer-friendly book style sheet themable.
- Patch #23320 by Chris Messina: made it easier to theme the printer-friendly book pages.
- Patch #22123 by Djun: fixed off by one error in printer-friendly book pages.
- Patch #22123 by Djun: fixed off by one error in printer-friendly book pages.
- Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
- Modified patch #21441 from puregin + RobinMonks: fixed some bugs surrounding the book administration and beautified some code making it more consistent with the rest of Drupal. :-)
- Patch #21687 by faago: fixed boroken 'delete'-link on the book administration page.
- Patch #21687 by faago: fixed boroken 'delete'-link on the book administration page.
- #21195: book admin broken under php5
- #21195: book admin broken under php5
- Patch 20910 by chx: centralize print theme page.
- Work by chx and myself: added a site-wide contact form to the contact module.
- Patch #20661 by rooey: fixed formatting of book navigation. Added missing '<div id=menu>'.
- Patch #20661 by rooey: fixed formatting of book navigation. Added missing '<div id=menu>'.
- Patch #20451 by Moshe: some ancient code was assuming that all apges in a book are of type 'book'.
- Patch #20451 by Moshe: some ancient code was assuming that all apges in a book are of type 'book'.
- Patch #19960 by Gerhard: removed left-over DISTINCT. Spotted by BuddaBoy.
- #18817: Clean up plain-text checking (see drupal-devel!)
- Patch #19169 by TDobes: allow the book navigation to be themed.
- Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
- anchor link fix in distributed auth help
- "my account" link fix in user help
- spelling correction in tracker.module help
- I also changed 'admin/access/perms' to 'admin/access/permissions'.
- Patch #16462 by Moshe: book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page.
- Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch.
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
- Patch #15948 by matteo: the book module should call the nodeapi hook when printing printer-friendly pages.
- Patch #15948 by matteo: the book module should call the nodeapi hook when printing printer-friendly pages.
- Patch #15843 by Ber: in book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15.
- The real code fixes ;)
- Patch #14731 by chx: made it possible to rewrite node queries.
- Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);
* Specify a severity in case you are reporting a warning or error.
* The $link-parameter is now the fourth parameter instead of the third.
TODO: document this in the upgrade guide.
- Patch #12366 by mathias: fixed missing book edit tab.
- Patch #12366 by mathias: fixed missing book edit tab.
- Bugfix: the book module incorrectly assumed that there is an active revision if n.moderate = 0. We can (and need) to rewrite this when the revision changes hit core. In essence, we need an efficient query to retrieve the 'last puslished revision that is not in the moderation queue'.
- Patch #13907 by Neil: less ways to set the page title. * Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
- Removed some cruft: left-over xxx_help_page() functions.
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend. Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
- Modified patch #8552 by Gerhard: added 'add child page' link to book pages you can edit.
- Patch #12783 by Stefan: various small consistency/usability improvements.
- Patch #10632 by Gerhard: the book permissions in today's cvs are not consistent with the rest of Drupal. We have a "maintain books" and a "edit own book pages" permission. All other modules have a "create foo" permission. Thus the existing "maintain books" permission should be renamed to "create book pages" and a new "maintain books" permission should be introduced that allows editors to update book pages they haven't created themselves even without having "administer nodes" permission.
- Patch #11875 by Neil Drumm: block module configuration improvements. The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
- Patch #11879 by Moshe: deprecated the _content hook. TODO: + Update Doxygen hook list (if required). + Document this in the developer's upgrade section.
- Patch #11947 by puregin: ensured that a book node's weight is captured when the book node lists returned by book_location() and book_location_down() are generated. This information is required when selecting next page candidates in book_next(). Note that book_location_down() was missing an explicit field b.weight in the SQL SELECT statement, but this value would usually be supplied implicitly because it is used to ORDER the result.
- Patch #11947 by puregin: ensured that a book node's weight is captured when the book node lists returned by book_location() and book_location_down() are generated. This information is required when selecting next page candidates in book_next(). Note that book_location_down() was missing an explicit field b.weight in the SQL SELECT statement, but this value would usually be supplied implicitly because it is used to ORDER the result.
- Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output. Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
- Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output. Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
- Mofified patch #8862 by puregin: improved book module documentation.
- Fixed bug #11312: menu caching to aggresively. I did not apply the proposed patch but moved the menu-logic to the $may_cache clause and added some checks to avoid SQL overhead. I think this is the most performant solution.
fixing typoes.
- Code improvement: removed some redundant code from the book module.
- Patch #11401 by Goba: documentation updates: + Made error strings in blog.module consistent. + Explained a bit better what the RSD setting is for in the blog module. + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.