Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
- Patch #582378 by sun, David_Rothstein: fixes for the filter system and additional tests.
#600974 by effulgentsia, JohnAlbin, sun, and Damien Tournoud: Allow theme functions to take one argument without any hacks. NOTE: This is an API change in hook_theme().
- Patch #606796 by jhodgdon: fixed documentation inaccuracy with filter_form().
- Patch #593746 by #593746 by sun, andypost: prepare Drupal core for dynamic data translation.
- Patch #582378 by sun: more filter system clean-up.
#569238 by sun, swentel, catch: Changed Make check_markup() not cache by default.
#562908 by sun and dropcube: Fixed issue where {filter}.module is not saved.
- Patch #572618 by effulgentsia, pwolanin, sun: all theme functions should take a single argument. Code clean-up and performance improvement. Woot.
#464862 follow-up by kkaefer: Rename drupal_css_class() to drupal_html_class_X(), for better accuracy.
- Patch #464862 by JohnAlbin, sun, dereine | dvessel, Jacine, Zarabadoo: added drupal_css_class() to clean class names and rename form_clean_id().
- Patch #11218 by David_Rothstein, sun, quicksketch, duncf, awood456, dropcube, mgifford | pwolanin, dww, RobRoy, Crell, webchick, beginner, ray007, bjaspan, chx, Gábor Hojtsy, Steven, Dries, lutegrass, sym, guardian, matt2000, geerlingguy, SeanBannister, matt westgate, com2, praseodym: allow default text formats per role, and integrate text format permissions.
#571086 by sun and merlinofchaos: Added a 'wrapper callback' that executes before a form builder function, to facilitate common form elements. Clean-up from form_builder changes from CTools patch. Has nice side-benefit of making all form functions' signatures consistent.
- Patch #470840 by salvis, sinasquax, sun: fixed bug in node_access() if we specify an account. Extend filter_access() to take custom account.
- Patch #570930 by sun: allow to retrieve all filters (including disabled) in a text format.
- Patch #563272 by David_Rothstein: renamed parameter for readability.
#560740 by sun and David_Rothstein: 'Escape all HTML' filter did not escape any HTML. Now that's a problem. (with tests)
- Patch #560502 by Gabor Hojtsy: created 'content authoring' category.
- Patch #559658 by sun, dropcube: store filter settings per format, general API clean-up and documentation improvements.
- Patch #300993 by dropcube, Dave Reid: user roles and permission API. Great patch.
- Patch #428296 by dropcube, sun, catch: filter system doesn't communicate with other modules about filter format changes/deletions.
- Patch #546336 by sun, dropcube: code clean-up and documentation improvements for the filter hooks.
- Patch #556832 by dropcube: add text format API to manipulate formats.
- Patch #554946 by dropcube, sun: cache info from hook_filter_info() and allow to be altered.
#446518 follow-up by sun: Removed logic branch in check_markup() for string being NULL.
#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.
Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.
*** empty log message ***
#542658 follow-up by sun: Move action 'tabs' out of local tasks and into local actions.
#326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: Convert 'class' attribute to use an array, not a string.
- Patch #546350 by dropcube: remove hardcoded numeric deltas from hook_filter_info().
#541708 by catch: Removed unnecessary query in _filter_tips().
- Patch #446518 by sun: remove argument from check_markup().
#362972 by tic2000 and stewsnooze: Have nofollow filter remove 'rel' attributes instead of just adding rel='nofollow'.
- Patch #548308 by dropcube: remove hook_filter_tips() as part of the hook_filter() refactoring.
- Patch #546336 by dropcube: transform hook_filter from having a paramater to hook_filter_().
- Patch #542742 by tic2000: create wrapper functions to load/serialize a DOM.
#359276 by lyricnz, Heine, Frando: Fix named entity handling in filter_xss(), so it does not clash with other entities and result in wrong encoding
- Patch #537678 by Bojhan: remove drag-and-drop help text.
- Patch #374441 by tic200, Damien Tournoud, scor: refactor Drupal HTML corrector using PHP5's XML/Dom parser.
#523542 by tgeller: Fix link in filter help text.
- Patch #506976 by catch: rename hook_perm to hook_permission.
- Patch #480152 by jhodgdon: updated filter API documentation.
#446898 by RoboPhred: Change URL of text formats settings page to admin/settings/formats rather than filter.
#212285 by wrwrwr: hr should be treated as a block level tag. Backport by alexanderpas.
- Patch #369011 by catch, sun, et al: performance improvement in text_field_load().
#473992 by andypost: Fix indentation.
- Patch #472642 by stella, agentrickard: remove 'implementation of' nominalizations from Docblocks.
#467474 by Josh Waihi: Type-cast booleans to work around PostgreSQL PDO bug.
- Patch #133188 by John Morahan, frega: make sure that long string are line-break-ed correctly.
- Patch #471070 by stella: millions of code style fixes.
- Patch #470632 by sun: move filter_xss*() into common.inc.
- Patch #445992 by oestrich, doq: missing point.
Roll-back of #310467: Breaks installer requirements check and update.php.
- Patch #310467 by chx, moshe weitzman: made hook_theme slimmer.
- Patch #424640 by mustafau: remove non-existing reference.
- Patch #394146 by ksenzee, csevb10, dropcube: converted to the new database abstraction layer.
- Patch #428242 by David_Rothstein: small code clean-up in check_markup().
#304330 follow-up by sun: Clean-up of text format widget patch.
Roll-back of #401956, which needs more discussion.
#401956 by chx and Damien Tournoud: Add an optional filter to turn [internal:node/123] into a link to an internal Drupal page.
- Patch #244904 by keith.smith, edmund.kwok, xano, David_Rothstein: rename 'input formats'.
#304330 follow-up by Damien Tournoud: Fix whitespace.
#304330 by ximo, alpritt, Amitaibu, edmund.kwok, Xano, ff1, BrightLoudNoise, et al: Dramatically improved text format widget. USABILITY AWESOMENESS.
- Patch #179244 by tangent: line break filter operates on object element.
- Patch #244904 by edkwh, keith.smith: renamed 'input format' to 'text format' based on UMN usability study.
- Patch #352470 by scor: fixed typos and grammar in comments.
- Patch #212236 by wrwrwr: automatic line breaking sometimes results in an unpaired end of paragraph tag.
#202688. Backport from 6.x.
- Patch #349504 by keith.smith: clean up sentence spacing in code comments.
Drupal 6.7
Drupal 5.13
- Patch #341885 by sun: remove absolute argument in theme_filter_tips().
- Patch #335086 by recidive: rename node, filter and comment module tables to singular for consistency. Oh my.
- Patch #334030 by justinrandell: replace module_list with module_implements when calling a hook.
- Patch #299778 by hswong3i, Arancaytar, Dave Reid et al: code clean-up.
- Patch #319788 by stella, nedjo et al: pass language code to filters when available.
- Patch #279516 by c960657: removed many PHP4-isms. Great patch.
- Patch #320747 by lilou, UltimateBoy: removed double semicolons.
#282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.
#313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names
- Patch #309488 by kbahey: correct capitalization of TRUE and FALSE.
follow up to #280621 by lilou: the object tag was disallowed in a previous version in filter_xss_admin(), so disallow param as well, which is only meaningful inside an object tag
follow up to #280621 by lilou: the object tag was disallowed in a previous version in filter_xss_admin(), so disallow param as well, which is only meaningful inside an object tag
- Patch #305645 by pwolanin: ['REQUEST_TIME'] -> REQUEST_TIME. Improved developer experience.
#214516 by mfb: Add the Real Time Streaming Protocol (RTSP) to the allowed protocol list in filter_xss_bad_protocol().
- Patch #302763 by Dave Reid, Rob Loach: replace time() by ['REQUEST_TIME'] as per Rasmus' suggestion. Removed drupal_referrer() for consistency.
- Patch #64967 by Arancaytar, meba: ereg -> preg for performance reasons and future compatilbility. PHP6 is rumoured to drop ereg support.
#197425 by lilou, Nick Lewis, mooffie, and friends: Add <blockquote> to list of default allowed HTML tags.
- Patch #280621 by pwolanin: remove 'param from allowed tags in filter_xss_admin().
- Patch #225450 by Crell, chx, bjaspan, catch, swentel, recidive et al: next generation database layer for Drupal 7.
- Patch #272952 by NancyDru and chx: fixed documentation issue.
- Patch #272952 by NancyDru and chx: fixed documentation issue.
- Patch #285575 by jk, Bart, Damien Tournoud, et al: fixed XSS problem in default input formats.
Drupal 6.4.
Drupal 5.10.
Patch #254725 by Steve Dondley and BioALIEN: maxlength field for 'allowed HTML tags' is too short. Backport by scor.
- Patch #254725 by Steve Dondley and BioALIEN: maxlength field for 'allowed HTML tags' is too short
- Patch #254725 by Steve Dondley and BioALIEN: maxlength field for 'allowed HTML tags' is too short
- Patch #245329 by christefano and dmitrig01: code comment love.
- Patch #214516 by mfb: add RSTP to protocol list.
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
- Patch #280621 by pwolanin: remove <object> from allowed tags in filter_xss_admin().
Drupal 5.8.
Drupal 6.3
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit et al. Can you say 'registry'? Drupal now maintains an internal registry of all functions or classes in the system, allowing it to lazy-load code files as needed (reducing the amount of code that must be parsed on each request). The list of included files is cached per menu callback for subsequent loading by the menu router. This way, a given page request will have all the code it needs but little else, minimizing time spent parsing unneeded code.
- Patch #253706 by zoo33: renamed 'header' to 'heading' for correctness with the W3C standard.
- Patch #240988 by David_Rothstein: fixed left-over documentation after the HTML escaping became a filter of its own.
- Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6.
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
- Patch #240988 by Gabor: break out HTML escaping to its own filter.
Drupal 6.2
- Patch #229517 by keith.smith and flobruit: de-html selected interface strings.
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
- Patch #222183 by Gabor and Keith: make the input formats reorderable as a first step towards better input format handling, and ultimately, good WYSIWYIG support.
#208700 by pwolanin. Fix bad backport of #194579. Modified to use Form API.
#212285 by wrwrwr: hr should be treated as a block level tag
#211322 by keith.smith: drag and drop documentation for input formats was missing, damn
Drupal 6 RC2
Drupal 5.6.
#207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks
#194579 patch by pwolanin: clear filter cache when allowed HTML tags configuration changes in an input format
#176748 follow up by pwolanin: fix bad breadcrumbs and missing/wrong titles
#203274 by Pasqualle: remove excessive witespace from our code (minor)
#194351 by David Strauss, JirkaRybka: (performance) pass on cache id information to filters
#189879 by keith.smith: filter module help text cleanup, better for translators with more concentrated explanations
- Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries.
rollback of #197425 following on Steven Witten's discontent on how it looks in Garland
#197425 by mooffie, slightly modified: add blockquote support by default and blockquote theming to Garland and Bluemarine (other themes have it already)
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
#198579 by webernet and hswong3i: a huge set of coding style fixes, including: - whitespaces at end of lines - indentation - control structure usage - whitespace in empty lines - phpdoc comment formatting
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
#184954 by scor: fix reference to 'input formats' in the help text
- Patch #179244 by tangent: line break filter operates on object element.
#175779 by pwolanin: fix filter format addition page and add proper titles for filter configuration tabs
- Patch #161185 by Crell: split filter module.
- Patch #68853 by matt and telcontar: improved documentation for the html input filter.
#150851 by pwolanin and chx: different radio buttons in the same set should have different HTML id values (XHTML validity fix)
#109829 by doq: do not trim URLs is the added ellipses would result in a longer link title then the original URL itself
- Patch #172961 by webernet: code style cleanup.
- Patch #164974 by ricflomag: correct usage of t().
#164974 by ricflomag. Better use of t().
#161351 by webchick and mlsamuelson: fix notice on filter formats config page
- Rollback of patch #147723: delete API. Talked to Steven and Gabor and we unanimously agreed to rollback the deletion API. We all support the features this patch added, yet not its actual design and implementation. After some talk, we decided that it would be better for Drupal -- in the long term -- not to go with a solution that isn't 100%. We also recognize that in the short term, this patch would have been useful addition. So let's figure out how we can implement this properly in D7.
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
#153781: Convert all remaining confirm_forms() to deletion api.
- Patch #103079 by yched: check_plain('') returned </p>
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
- Patch #103079 by yched: check_plain('') returned </p>
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
- Patch #54833 by Steven: added an HTML corrector.
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
- Patch #76588 by Gabor: made log messages translatable. Yay.
- Patch #46941 by Zen and Ber: move PHP input filter to dedicated module.
- Patch #118660 by agentrickard: re-order arguments of cache_set() to match PHP/Drupal conventions.
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
- Rollback of patch #84797: the font-tag is deprecated.
- Patch #84797 by RobRoy: add support for font-tag.
#105031: Allow both upper and lower case for allowed protocols in XSS checks.
#105031: Allow both upper and lower case for allowed protocols in XSS checks.
- Patch #113603 by chx: first crack at re-implementing tabs.
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
#108269: Convert URLs before exclamation marks (urlfilter)
- Cleanup form attributes.
#103563: Restore removing of HTML comments in filter_xss()
#102174: Default filter format's roles were messed up.
#100679: filter.module - Don't add unnecessary <br /> to empty output.
-Patch
- Patch #101562 by dvessel: <p>-tag clean ups.
- Patch #101775 by Steven: don't cut off posts at a lone <
#99708 by jvandyk. Proper use of ;.
#97824 by Gurpartap. Move enclosing elements outside of their t().
- Patch # #98366 by webchick and ac: simplified strings for translators.
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
- Patch #89285 by profix: code simplifications.
Fix form buttons sticking next to filter tips link
#84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc
#72797 by pwolanin and beginner. Make 'More information about formatting options' link themeable.
- Patch #83222 by edkwh: more theme('placeholder') clean-up. Good catch.
#80844 by Uwe Hermann. Various string cleanup, which should have been put in smaller patches.
- Patch #80952 by earl, webchick, neclimdul et al: .info files
- Patch #79118 by Robrecht Jacques: removed left-over code.
- Patch #81619 by m3avrck: clean up default phpTemplates.
#65765: Merge URLfilter.module into core filter.module
- Patch #72290 by killes: split up the cache table.
- Patch #80895 by webchick et al: make it easier to disable form elements.
- Patch #79612 by webchick: small performance improvement.
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
#76802: Introduce placeholder magic into t() See: http://drupal.org/node/64279#t-placeholders
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing. Once again, we're paving the path for CCK in core ... :)
- Patch #77422 by timcn: corrected various paths in the documentation.
#73884 by RobRoy, various code cleanup.
- Make filter admin work after recent admin changes
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
- Patch #61893 by timnc: remove message_na().
#73683 by keve, properly initialize an array.
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
#71772 by Bart Jansens, fix various php warnings, backport from HEAD
#71772 by Bart Jansens, fix various php warnings
#61802 by Zen, Double spaced sentences clean up
#61692, Filter module: Missing t(), patch by Zen, backport from HEAD
#61692 by Zen, Filter module: Missing t()
- Removing trailing whitespace.
#56947, fix filter link tips, patch by Dries Knapen
#58317: Backport autop improvements from wordpress
#58317: Backport autop improvements from wordpress
#57948: Fix header elements in filter_xss_admin
- #55898: Generic, permissive admin XSS/HTML filtering for mission/footer/... - Clean up some raw output
#56947: Restore missing filter tips (drumm)
Oopsie
- Store correct format id instead of 0 for anonymous users (+ code cleanup)
#41171 James Harvard & freso@freso.dk: Add ABBR & ACRONYM to HTML tips
- theme_placeholder to theme('placeholder')
#52484 by chx: filter_form needs validation
- Patch #52265 by Zen: converted filter.module to file API:
* Converts filter.module to the fapi model (besides filter_admin_overview which has already been done.)
* On the format edit screen, updates to the roles fieldset were being mangled with the previous code. The previous code relied on only checked checkboxes being returned. Fapi for some reason decides to insert non-checked items as well with values 0.
* Makes the name field a UNIQUE field. DB and update patches included. Having a duplicate format name completely b0rks things.
* Adds check_plain to the format name in admin_overview.
* Removes unnecessary #type => 'markup'.
* Moves hook_menu to below hook_help.
* drupal_goto -> return.
- Patch #52341 by m3avrck: corrected phpdoc.
- Patch #50982 by kuba: converted the admin filter overview page to the submit-model.
#48710, incorrect list of roles that can use default input format, patch by RayZ
- #48997: Remove PHP notice from filter.module
- #48997: Remove PHP notice from filter.module
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #49198 by Ber: improved documentation of filter-roles setting.
- #45742: XHTML slash fix.
- Patch #45742 by chx: fixed problem with closed tags being filtered out.
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
- #44772: {} -> [] (in anticipation of PHP de-deprecation)
- Partial patch #43014 by wulff: added missing t() function to filter.module.
- #42828: Auto-p destroys alphanumeric named entities like ½
- #42828: Auto-p destroys alphanumeric named entities like ½
- #27230: Fix XHTML slash in XSS filter
- Patch #39179 by chx: improved validation of forms.
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
- Patch #40975 by chx: filter_format no longer supports multiple filtered areas.
- Patch #40628 by Jaza: added missing fieldset around filter options.
- Patch #40351 by Richard/chx: filter_xss_bad_protocol too hungry.
- Patch #40351 by Richard/chx: filter_xss_bad_protocol too hungry.
- Patch #40351 by Richard/chx: filter_xss_bad_protocol too hungry.
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
- Patch #39155 by Alex/chx: #validate, #submit, #process consistency
- Patch #39605 by Alex: remove form_filter type.
- Improved the protocol whitelist code.
- Improved the protocol whitelist code.
- Improved the protocol whitelist code.
- More fixes
- More fixes
- More fixes
- #39362: Fix code warnings in filter.module
- #39362: Fix code warnings in filter.module
- #39362: Fix code warnings in filter.module
- Various fixes. Updated CHANGELOG.txt
- Various fixes. Updated CHANGELOG.txt
- Various fixes
- Patch #38349 by chx: form API bugfixes.
- Patch #35644 by webchick: forms API simplificiations.
#36242: Array merge problems with module_invoke
- Partial patch #34920 by tangent: improved placement of filter settings.
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #35320 by asimmonds: couldn't save roles in admin/filters/...
- Patch #35596 by ccourtne: form API change introduced input format fieldset even when only 1 input format
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Patch #33433 by chx: fixed a number of form API problems.
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
- Modified patch #30775 by timcn, Souvent22, m3avrck: give file uploads descriptions. (Modified the form a bit.)
- Patch #27364 by Ber, m3avrck: filter GUI improvements. chx: it can be "form API"-ied now. :)
- Patch #29385 by chx: no ?> add end of files.
- Fixed the filter module.
- Patch #28826 by chx: make xmlrpc_multicall working.
- #27551: Rename check_output() to check_markup(). Needs contrib updates!
- Fixed problems with filter formats and problem with XML-RPC server.
- Fixed problems with filter formats and problem with XML-RPC server.
- Fixed problems with filter formats and problem with XML-RPC server.
- Patch #25603 by Stefan: made the sizes of forms consistent. TODO: document the defaults in the PHPdoc comments.
- Patch #16204 by Thox: committed the collapsible form elements patch.
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
- Use & instead of numerical entity in autop.
- Use & instead of numerical entity in autop.
- Line-break filter tag matching was not case-insensitive, so it didn't pick up e.g. <PRE>
- Line-break filter tag matching was not case-insensitive, so it didn't pick up e.g. <PRE>
- Line-break filter now also ignores <style> (already ignored <pre> and <script>).
- Line-break filter now also ignores <style> (already ignored <pre> and <script>).
- Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
- Patch 20910 by chx: centralize print theme page.
- Make the auto-linebreak filter also ignore the contents of <script>.
This makes it easier to use JavaScript (e.g. Google Adsense) inside blocks.
- Make the auto-linebreak filter also ignore the contents of <script>.
This makes it easier to use JavaScript (e.g. Google Adsense) inside blocks.
- Oopsie
- Make the auto-linebreak filter also ignore the contents of <script>. This makes it easier to use JavaScript (e.g. Google Adsense) inside blocks.
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
- #18817: Clean up plain-text checking (see drupal-devel!)
- Cleaner handling of format ID number in URL, for hook_help.
#12369: Linebreak filter should leave <pre> sections alone.
#18329: Unify confirmation messages (and make them themable)
- Patch #16016 by Goba: fixed various bugs in filter tip display.
- Refinements by Walkah, based on suggestions of Steven and myself.
- Patch #15847 by James: added rel="nofollow" support. This is implemented as a filter so it can be enabled/disabled on a per-role basis (eg. some people might want to enable this for anonymous users but not for authenticated users).
#14548: Add optional HTML help to filter.module's HTML filter.
- Patch #13907 by Neil: less ways to set the page title. * Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
- Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
db_query($query, $a, $b, $c);
db_query($query, array($a, $b, $c));
This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
- array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
- $params[] = 0;
- $params[] = 1;
- $result = call_user_func_array('db_query_range', $params);
+ $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
and
- return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
+ return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query. This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself. With the new, documented syntax, there is no more excuse to put data directly in the query.