Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#634820 by arianek, batigolix, and jhodgdon: Update Menu module to new documentation standard.
Roll-back of #595084; type-hinting parameters at stdClass makes it so you can't ever pass in another type of class.
- Patch #607244 by sun: added permission to decrease performance impact of contextual links.
#322703 by BarisW, sun, Shai, and dman: Use on/off checkbox to enable and prepopulate node's menu item.
- Patch #595084 by c960657: use type hinting for .
#600974 by effulgentsia, JohnAlbin, sun, and Damien Tournoud: Allow theme functions to take one argument without any hacks. NOTE: This is an API change in hook_theme().
#473268 by David_Rothstein, sun, yoroy, Gábor Hojtsy, cwgordon7, et al.: Allow contextual editing of dang near everything on the page. Also adds a context system to menu local tasks.
- Patch #511286 by JacobSingh, David_Rothstein, dmitrig01, Gábor Hojtsy, ksenzee et al: add customizable shortcuts to the toolbar.
- Patch #593746 by #593746 by sun, andypost: prepare Drupal core for dynamic data translation.
- Patch #351249 by stBorchert, coreyp_1, BrightLoudNoise, catch, kkaefer, sign: finer control over the Parent Menu select box.
#557292 by peximo, plach, catch, and yched: Convert node title to Field API.
#473082 by sun, Amitaibu, dropcube, and Pasqualle: Added a custom menu API.
- Patch #576916 by BarisW | Bojhan: default menu 'Parent item' should be Navigation, not Primary links.
- Patch #508570 by quicksketch, sun | pwolanin, bec: restore URL consistency for node types and menus.
#564394 by Berdir and Crell: Removed database BC layer. nah nah nah nah... hey hey hey... gooood byeeee...
- Patch by #565496 by dropcube, pwolanin: changed Allow dynamic attaching of other types of stuff to render() structures.
- Patch #495968 by Frando, moshe weitzman: added drupal_render() cache pattern. Start using it for blocks.
- Patch #560746 by dropcube: rename hook_block_list() to hook_block_info() for consistency in the API.
#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.
Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.
*** empty log message ***
#542658 by Gábor Hojtsy, sun, pwolanin: Move action 'tabs' out of local tasks.
#326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: Convert 'class' attribute to use an array, not a string.
- Patch #521474 by bangpound, JuliaKM et al: rename admin/site-building to admin/structure.
- Patch #506976 by catch: rename hook_perm to hook_permission.
- Patch #503822 by berenddeboer: remove drag and drop help text from menu page.
- Patch #472642 by stella, agentrickard: remove 'implementation of' nominalizations from Docblocks.
- Patch #472658 by agentrickard: clean up of inline code comments.
- Patch #471070 by stella: millions of code style fixes.
Roll-back of #310467: Breaks installer requirements check and update.php.
#469386 by Bojhan: Remove obvious menu administration help, and make block-related help conditional on block module.
- Patch #310467 by chx, moshe weitzman: made hook_theme slimmer.
- Patch #457532 by Berdir: more PHP5 'fixes'.
- Patch #394476 by Berdir, pwolanin, Crell: converted the module to the new database abstraction layer.
#317775 by Starminder, pwolanin: do not store the menu router table serialized in cache, since it cases more performance problems then it solves
#323112 by dmitrig01, kkaefer, quicksketch, frando and many many more: Now presenting... Vertical Tabs. Fantastic new UI improvement for node forms and hopefully more in the future.
- Patch #317775 by pwolanin, justinrandell: caching entire {menu_router} table causes MySQL error/slow rebuilds and slows menu_link_save.
- Patch #402226 by stompeers, catch et al: menu admin page uses inconsistent formatting.
#273137 follow-up by David Rothstein: Fix menu descriptions.
- Patch #273137 by pwolanin, David_Rothstein, chx, et al: split navigation to user and administration menu. Will require follow-up patches.
#383066 by David Strauss: Rename hook_nodeapi_X to hook_node_X.
#287725 by mantyla. Sort by mid to avoid inconsistencies when multiple menu items exist for a node.
#326210 by AlexisWilke, grendzy, jhedstrom: Take the menu item in its first submission and menu_nodeapi() by reference, so that any modifications of the item in the saving process will carry over to other submit handlers; making itpossible to write modules extending menu item manipulation
#328110 by marcingy, swentel, Damien Tournoud, pwolanin, David_Rothstein: the link argument is passed by reference to menu_link_save(), so avoid overwriting local variables in menu_enable().
#326210 by AlexisWhite and jhedstrom: Pass ->menu by reference to allow modules to modify it.
- Patch #352470 by scor: fixed typos and grammar in comments.
- Patch #345866 by alexanderpas, justinrandell, Dave Reid: remove from hook_block().
#294450 by blakehall. Match up DB and form max length.
#328110 by marcingy, Damien Tournoud, swentel, and pwolanin: Fix error on admin/build/menu, and robustify the test so we catch stuff like this in the future.
Oops. Roll-back of #328110. Apologies
#328110 by Damien Tournoud: Remove recoverable fatal error from menu system.
#282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.
#313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names
- Patch #310212 by justinrandell: killed in _node hook, as well as twelve sable tooth tigers.
- Patch #161301 by Eaton, Sun, moshe and webchick: make checking for node edit forms easier. DX improvement.
#308534 by Dave Reid: Remove stray whitespace core-wide.
- Patch #225450 by Crell, chx, bjaspan, catch, swentel, recidive et al: next generation database layer for Drupal 7.
- Patch #245329 by christefano and dmitrig01: code comment love.
- Patch #270917 by catch, Bojhan, et al: renamed 'primary links' and 'secondary links' to 'main menu' and 'secondary menu' respectively. Based on usability study conducted with the help of Bojhan.
- Patch #256736 by flobruit: fixed bad HTML in help text. flobruit is on a patching spree!
- Patch #256736 by flobruit: fixed bad HTML in help text. flobruit is on a patching spree!
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit et al. Can you say 'registry'? Drupal now maintains an internal registry of all functions or classes in the system, allowing it to lazy-load code files as needed (reducing the amount of code that must be parsed on each request). The list of included files is cached per menu callback for subsequent loading by the menu router. This way, a given page request will have all the code it needs but little else, minimizing time spent parsing unneeded code.
- Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6.
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
- Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php. The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:
block-user-0.tpl.php --> block-user-navigation.tpl.php
block-user-1.tpl.php --> block-user-login.tpl.php
You get the picture.
Drupal 6.2
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
- Patch #220004 by webernet et al: menu items reorder after edit one of menu item.
#220004 by webernet: menu ordering weight region was not wide enough (like on the menu reordering screen)
#207372 by Pancho, pwolanin, chx: remove duplicate query from menu_enable()
#58806 by fwalch and wicksteedc. Do not override MENU_VISIBLE_IF_HAS_CHILDREN on editing.
#205843 report by asimmonds, patch by chx: menu_valid_path() was used as an API function, but was located in menu.module, move to menu.inc
#202425 by keith.smith: standardize reference to block placement page as 'blocks administration page' to avoid any confusion
#189881 by keith.smith: document drag and drop in menus and clean up some more help text
#199428 by Lynn: default to the primary links for content menu items (usability)
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
#195083 by Rowanw and keith.smith: menu items are not displayed on the main menu page anymore; update help text
- Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues.
#191360 by chx: allow contributed modules to override the book and menu parent selectors (to improve usability and performance)
- Patch #191914 by chx: you cannot add user/register to a menu. Also removed some whitespace.
#178608 by chx: convert menu overview page to a form to overcome any CSRF vulnerabilities
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
- Clean-up menu link
#162276 by Rowanw: usability - reword menu item deletion checkbox label
#170651 by pwolanin: slipt menu module into the module and an admin.inc for admin pages, to help performance
#147657 follow up patch by drewish and bdragon: fixed coding style and a notice
#147657 by chx: menu module update function
#171019 by pwolanin: do not exclude the primary and secondary links from the menu block list
- Patch #169065 by pwolanin: links to new menus can exist outside 'navigation'.
#160168 by kkaefer and pwolanin: restore lost Drupal 5 functionality of being able to set primary and secondary links differently
#166586 by hswong3i: move literal values out of menu module queries (for better db compatibility, ie. easier query rewriting)
#165675 follow up patch by pwolanin: retain menu information on node previews to check, do not use the newly selected values yet, to be consistent with the DB
- Patch #80951 by killes, yched et al: block caching.
#165675 by pwolanin: only show allowed parent items in menu/book select fields to avoid going deeper then what is allowed
- Patch #154470 by pwolanin et al: optimize menu queries and indices.
- Patch #162708 by Eaton and Earl: add support for image buttons to FAPI3. This is a small form API extension (doesn't break existing code) that facilitates the Drupal 6 upgrade of the Views module. A good example of why it can be beneficial to start upgrading your modules early on in the code freeze. ;)
Drupal 5.2
#156626 by pwolanin: allow deletion of custom menus
- Patch #154469 by pwolanin: improve performance of access checks and add localized sorting.
#100641 by kkaefer, ChrisKennedy and RobRoy: change 'Submit' buttons to 'Save' to compliy with the desktop metaphor and actually tell what the button does ('we know it submits the form, but what it does?')
- Patch #94154 by dww, Earl et al: update notifications for Drupal! Woot, woot! :)
#156770 by pwolanin: fix bug to only prepend 'menu-' to menu item names when submitting a *new* menu item, not on all edit operations
- Patch #151055 by pwolanin et al: fixed problems with moving menu items.
#156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes
#156782 by webernet and pwolanin: clean up menu API and menu module code comments, fix typos, wrap lines properly and fix some coding style issues
#156793 by webernet: menu reset confirmation form contained deletion API remainings
- Patch #151583 by pwolanin, Shakur, webernet, Arancaytar et al: various menu module fixes.
- Patch #155986 by Uwe: fixed typos.
- Rollback of patch #147723: delete API. Talked to Steven and Gabor and we unanimously agreed to rollback the deletion API. We all support the features this patch added, yet not its actual design and implementation. After some talk, we decided that it would be better for Drupal -- in the long term -- not to go with a solution that isn't 100%. We also recognize that in the short term, this patch would have been useful addition. So let's figure out how we can implement this properly in D7.
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
#154046: Optimize confirm_form syntax for common usage (and fix some $form_state bugs).
#153781: Convert all remaining confirm_forms() to deletion api.
- Patch #147656 by Shakur: bugfix.
- Patch #147656 by pwolanin and chx: menu module update for Drupal 6.
- Patch #146667 by Jeff Eaton: form API fixes.
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
- Patch #137767 by chx and pwolanin: multiple menu support.
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
- Patch #76588 by Gabor: made log messages translatable. Yay.
- Patch #131009 by chx: menu system fixes/improvements.
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
#130991: Custom menu items, part 1
- Patch #110888 by Eaton: unify hook _alter()
- Patch #128081 by Eaton: remove #base, paving the path for a simpler form API.
- Patch #108730 by add1sun: small code cleanup.
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
- Patch #107097 by webernet: remove bogus xhtml from string.
#99763 by kkaefer. The menus are a system-level thing, and their css should be too.
Properly check if an array key exists.
#98078 by Heine. Fix double escaping on admin/build/blocks.
- Patch # #98366 by webchick and ac: simplified strings for translators.
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
#91089 by Steven. Reshuffle the order of menus on their administration page.
#48178 by kkaefer. Only save the menu item expanded attribute if it is set.
- Menu item capitalization
#84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc
- Patch #83914 by nickl: form API clean-up: remove stuff.
- Patch #83213 by edkwh: removed stray theme('placeholder').
#80844 by Uwe Hermann. Various string cleanup, which should have been put in smaller patches.
- Rollback of patch #68418: clean up node submit hooks. Needs more thinkering. Restores the old node API.
- Patch #80952 by earl, webchick, neclimdul et al: .info files
- Patch #80489 by timcn: fixed problem with resetting menu items.
- Patch #68418 by Moshe et al: clean up node submit hooks.
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
- Patch #76444 by chx, moshe, eaton, angie et al: make it possible to control access to form elements.
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
#76802: Introduce placeholder magic into t() See: http://drupal.org/node/64279#t-placeholders
#77183 by m3avrck and timcn, split up drupal.css by module.
- Patch #77422 by timcn: corrected various paths in the documentation.
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
#73676 by keve, fix an undefined index.
#68807 by jvandyk, a few menu.module cleanups.
#61802 by Zen, Double spaced sentences clean up
#53870, better help text for menu.module, patch by dww
- Menu titles were not escaped properly
#53870, better usability for admin/menu
#55132, Menu module : fapi conversion + fixes, patch by Zen
#55132, reformatting of menu.module, patch by Zen.
#53654, remove module reset button, patch by Zen.
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #47056: improved the consistency of the help texts.
- Patch #46827 by wulff: fixed incorrect links.
- Patch #39430 by Jaza and Richard: code improvements: improved separation between UI and logic.
- Patch #44544 by Richard: made the help text slightly more accurate.
- Patch #44499 by Neil: missing quotes.
- Patch #44373 by m3avrck: improved generated HTML/CSS.
- Patch #39639 by Richard: 'users' appearing twice in menu.
- #42520: Improve translatability of menu admin help
- Patch #42520 by Cvbge: change text for easier translation.
- Patch #36465 by chx / Richard: made it possible to link to the front page.
- Patch #40847: after menu reset, primary and secondary menus need to be recreated.
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
- Patch #40393 by Richard: fixed permissions of URL settings on node submission page.
- Patch #40795 by Richard: fixed problem with editing menu items.
- Patch by Richard: fixing breakage caused by the 'Obliterate nodeapi op form' patch.
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
- Patch #39779 by Richard: removed confusing status messages.
- Patch #32665 by Richard Archer: add more functionality to menu item settings on node/*/edit pages.
- Patch #39440 by Richard: no circular references.
- Patch #37327 by Richard Archer: improved menu item 'create content' indications. Improves usability of the admin/menu page.
- Patch #37327 by Richard Archer: made the menu edit screen slightly less confusing.
- Rollback an accidentical commit.
- Patch #35644 by webchick: forms API simplificiations.
- Patch #22215 by Richard Archer: refactored primary and secondary links.
Deprecates the primary_links module.
This patch was much needed. Thanks Richards!
NOTE: if some themers could investigate if there is room for improvement
with regard to theming, that would be awesome.
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #34920 by tangent: reorganized the node submission form a bit.
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
- Patch #33752 by leafish_paul / adrian: added missing apostrophes to the form API code.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
- Patch #27669 by ax: fixed menu system status reporting.
- Patch #17079 by Uwe: fixed form title of form element in menu module form.
- Patch #29385 by chx: no ?> add end of files.
- Menu: remove array_merge warning when editing a node without menu item.
- Patch #9178 by mathias: improved menu system integration.
- Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
- Patch 20910 by chx: centralize print theme page.
- Patch #19739 by Uwe: corrected many typo's in the documentation and code comments
- #18817: Clean up plain-text checking (see drupal-devel!)
#18329: Unify confirmation messages (and make them themable)
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
- Patch #12783 by Stefan: various small consistency/usability improvements.
- On popular demand, patch #10178 by jhriggs: made it possible to expand menu items.
- Patch #11875 by Neil Drumm: block module configuration improvements. The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
- Patch #11725 by mrrowe: custom menus are not wrapped in <div class="menu"> tags which made their appearance differ from the built-in "navigation" menu.
- Patch #11725 by mrrowe: custom menus are not wrapped in <div class="menu"> tags which made their appearance differ from the built-in "navigation" menu.
- Patch #10869 by JonBob: the menu.module forget the parent item on form error.
- Patch #10961 by Gerhard: fixed PHP warning in the 'add menu item' form.
- Patch #8179 by JonBob: reintroduced menu caching.
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
- Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
- Code improvements by Stefan: made all status messages consistent (and easier to translate).
- Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
- Patch #9864 by JonBob: better form validation in menu administration.
- Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes.
- Patch 9543 by JonBob: use drupal_goto() in menu administration.
- Patch #9464 by Moshe: menu.module omitted a pair of braces when calling db_next_id().
- Patch #9234 by TDobes: the latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible. This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU. It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there). Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
- More tab-improvements by JonBob: improved support for the default tabs!
- Patch #8941 by JonBob: allow local tasks to be ordered by weight, as well as simplifying the theming of local tasks so they can be more easily rendered in a non-tab manner.
- Patch #8681 by stefan: fixed some broken URLs and help texts.
Tabs patch!
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
- Patch by JonBob: killed a warning.
- More code improvements by JonBob. Thanks a bunch.
- Patch #7271 by JonBob: avoid filling the database with menu items.
- Added support for 403 handling. Patch by JonBob. As a side benefit, administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
- Patch by JonBob/Jonathan: reworked the menu system so that menus are configurable! Menu items can be disabled, repositioned, added and so on. Upgrading to requires you to run update.php. This functionality depricates some of the 'navigation modules' in the contributions repository. Furthermore, modules can now 'suggest' menu items and site adminstrators can choose to enable them. Modules in the contributions repository should try to take advantage of this.
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, select a symbolic revision name using the selection box, or choose 'Use Text Field' and enter a numeric revision.
| ViewVC Help | |
| Powered by ViewVC 1.1.2 |