Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Links to DRUPAL-4-7-7: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
500-7002-AS
#106604, no user pictures in previews, patch by prahlad
#73910, node_teaser() not breaking properly, backport
#100399, remove phpdoc that does not apply, patch by Robert Douglass
#104729, node_form_add_preview() destroys existing prefix values, backport
#104618 by robertDouglas and jvandyk: fixed node caching., backport
#100775, Forms in node preview are broken, backport by chx
#103624, Don't throw away relevancy score in node search, patch by Steven, backport
#49926, break, teaser, and php input, patch by JohnAlbin, backport
#86842, node_load broken under PHP5, backport, patch by pwolanin
#41703, fix rss item customization, backport from HEAD, patch by drewish.
#98686, Nodes not indexed when passing directly from Moderation to Promoted, patch by Robert Douglass
#86842, node_load broken under PHP5, backport from HEAD, patch by pwolanin
#83288, a user edit that removes "update" permission fails, backport from HEAD, patch by pwolanin.
- Patch #90128 by gotheric and chx: worked around incompatible change in MySQL 5.0.13. Actually improves portability with databases like Oracle. Critical bugfix as it prevented search indexing from working.
remove trailing spaces
#80989, node_teaser can provide a better teaser, patch by fgm, backport from HEAD
#80271 by chx: node validate prevents programmatic node submission. backport from HEAD
#48772, remove redundant code from node_link, patch by markux_petrux.
#61636, Revision system throws PHP warning when reverting to an earlier revision., patch by JonBob
#75186 by pwolanin, invalidate the cache on saving via the node admin page., backport from HEAD
#64857, node.module - index all content for search during cron run, patch by pwolanin
#50316, Two people editing a node at the same time can result in loss of first changes, patch by hunmonk
Patch #73599 by drumm: proper access checking. backport from HEAD
Patch #71684 by fgm: corrected the header information of RSS feeds: text/xml -> application/rss+xml, backport from HEAD
#68588 by keve, fix a query for postgres., backport from HEAD
- Patch #65801 by Moshe et al: fixed locale initialization slowness.
#53021, Node types at node/add page not ordered alphabetically on non-english sites, patch by Egon Bianchet / chx
#48671 by Jaza: admin form fields not getting rendered at bottom of node form like they should., backport from HEAD
#62147 by Jaza, Breadcrumb for nodes should not include 'content' link, backport from HEAD
#60358, warmer welcome message, backport from HEAD.
#59935, It's impossible to preserve stuff by calling form_set_value from hook_validate to submit, patch by tenrapid
#60729: Index taxonomy terms with nodes
#59935 by chx, make nodeapi consistent with the rest of formapi, enabling the use of form_set_value.
#59428: Correct teaser for japanese period character
- #56617: Search ranking criteria depended on eachother. - XHTML validation of node search form
#46549, more robust node_submit, patch by chx
#58221, Turn #after_build into a functions array in order to make validation of date fields possible. Patch by yched, tenrapid Also makes forms API more consistent (see #pre_render)
#59070, forms on paged versionis of admin/node did not work, patch by tenrapid
- Removing trailing whitespace.
#56921: Remove all reference magic from form api. w00t.
- More inline with other form descriptions.
#58449: Date on preview was broken
#58166, fixes for typos, patch by Uwe Herrmann
#52710: Incorrect timestamp when user has administer nodes permission
#57956: Redirect after node deletion
#52710, fix node timestamp for admin users, patch by hunmonk.
- #55898: Generic, permissive admin XSS/HTML filtering for mission/footer/... - Clean up some raw output
#56911, advanced search broken, patch by Zen.
#56457: hook_search() form API conversion
#56105, remove title validation, already enforced by #required, patch by Moshe
#53348, Handling of deleted/blocked user accounts, patch by jreyero and Zen
#55922, forgotten global $user, patch by singularo
#55632, After deleting the last revision of a node, you're sent to an invalid path, patch by dww
#55550, if editing a node, node author changes to user editing it, patch by merlinofchaos
#54519, remove old bookmarklet code. Use prepopulate.module, patch by budda
#45988, Nodes with menu items bypass node permissions system patch by chx
#45988, Nodes with menu items bypass node permissions system, patch by chx.
-bug #51522 by m3avrck, node teasers are empty
#43032, Can't move forum topics created by anonymous (Authored by not set), patch by Cvbge.
#52586, node preview broken with php5, patch by greggles
#53012, make "Create new revision" respect node type settings, patch by Zen
- Patch #51522 by paddy: break at beginning doesn't work
- #49405: Minor advanced search UI/code tweaks
- #51110: Make search results page more flexible
#44129, patch by Zen
- Patch #51189: fixed submit redirects.
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #50219 by pz: removed some redundant code.
- Patch #50219 by pz: removed death code.
- Patch #50105 by chx: simplified some code.
- Patch #44298 by DriesK: prevent unaccessible links from being generated.
- #35073: Admin/node category filter not working
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
- Patch #47406 by Zen: menu sorting shouldn't be case insensitive.
- Patch #43622 / #46627 by markus: 'delete the selected posts' operation on admin/node doesn't work.
- Patch #48564 by JonBob: grammar fix.
- Node revisions 404/403 handling called drupal_not_found() twice.
- Patch #48021 by Zen: removed unused variable.
- Patch #46933 by Gerhard: moderated nodes are not indexed.
- Patch #46827 by wulff: fixed incorrect links.
- Patch #46705 by killes: don't use array_merge.
- Modified patch #37754 by Thomas: made the status message show up.
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
- #42277: Make node search indexing more robust against bad nodes and timeouts.
- Patch #45206 by markus: attempt at making the node filters somewhat translatable.
- Patch #45259 by chx/drumm: cast to object required.
- Patch #42072 by m3avrck: more improvements to the node revesion overview screen.
- Patch #42072 by m3avrck: improved the revision overview screen.
- Critical feature #40670: made the form array accessible.
- Extended the form description for clarity.
- Patch #42886 by chx: critical feature: allow modules to be reordered.
- Patch #42955 by Cvbge: critical bugfix: users can't create new content.
- #41940: Locale string search broken in some cases (and remove some inappropriate db_escape_string() usage) - #43491: Missing drupal_goto() after saving settings
- Patch #35770 by DriesK: make node preview settings work.
- Patch #43032 by Steve Dondley: critical fix: can't update nodes by anonymous users.
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
- #42234: Use standardized feed icon for RSS
- Bug #42107: redirect to the main page instead of to 'node'.
- Patch #28159 by chx: removed some dead code from the search module's form.
- Patch #42153 by Junyor: slight clean-up of node_revision_delete().
- Patch #30098 by killes: node revisions should only be viewable by admins.
- #41973: Ensure -\>changed and -\>created are equal on node creation
- #34826: Search results don't include last part of longer pages
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
- Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1. Changed code to be compatible with all versions.
- Patch #41211 by Neil: de-dupe XML namespaces in RSS automatically.
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
- Patch #41165 by Morbus: removed rss doctype.
- Patch #41109 by chx: fixed problem with _node_name() returning NULL instead of array() when there are no node types.
- Patch #40587 by wtanaka: execute -> submit
- Patch #36429: remove CONCAT() and speed up node_access query.
- Patch #29326 by Morbus: optimized performance of URL aliasing for newly installed sites. There are a number of small optimizations we could add; like, we should never do more lookup queries than the number of unique URL aliases in the database. When the size of the static cache equals the number of unique URL aliases in the database, we can stop doing lookups. I think this could be implemented with a 2-line change. Takers?
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
- #7940: Remember publishing options when editing node
- Patch #37798 by Neil: fixed problem with node settings.
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
- #35142: Fix mass delete
- Patch #38593 by malex: generate 'guid' in RSS feeds to work around some aggregator glitches.
- Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms.
- Patch #37752 by chx and Richard: renamed #post_process to #after_build.
- Patch #37926 by asimmonds/chx: fixed previewing nodes.
- Patch #37777 by asimmonds: form_id missing from rendered admin/node form.
#37390: Make welcome text link to admin/settings
- Patch #35644 by webchick: forms API simplificiations.
#36791: node_validate was called twice
- Patch #36250 by hunmonk: admin batch delete broken, node_delete needs reworked. This commit changes the node_delete() API. A list of affected modules is available at http://drupal.org/node/36250#comment-52963.
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #34920 by tangent: reorganized the node submission form a bit.
- #35434: Form API - obsolete $param to hook_form() + preview fixes
- #35284: fixing node form
- Patch #35279 by asimmonds: fixed typo in pager code.
- #35264: More form api fixes
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
- #28159: Advanced search features (hello from DrupalCon) Presentation about it: http://www.acko.net/files/drupal-search-slim.pdf
- #33433: More form API fixes, and error handling improvements by Chx.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Patch #33433 by chx: fixed a number of form API problems.
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
- Removing tabs and trailing whitespaces.
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
- Patch #32103 by nedjo: fixed title validation.
- Patch #28786 by Neil: move pagers out of table.
- Patch #10056: allow the node title forms to be customized.
- Patch #3986 by James (and Boris :)):consolidated all feed-related settings in one place.
* adds a "feed settings" section to admin/settings where 2 new settings are introduced:
* number of items per feed
* default length of feed descriptions (title only, teaser, full)
* patches all of core to obey the above - including the new aggregator (out) feeds
* adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
* includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.
- #30128: Call by reference left-overs
- Patch #7582 by Gerhard: improved node revisions! All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created. TODO: 1. Provide upgrade instructions for node module maintainers! 2. Upgrade modules that implement node types. 3. Provide an upgarde path for revisions. Dependency on the upgrade system.
- Renamed _node() to _node_info()! We reserve _node for _nodeapi.
- Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
- Patch #29593 by tostinni: fixed display of title on admin/settings/content-type/ pages.
- Patch #29385 by chx: no ?> add end of files.
- Patch #17592 by killes: improved access denied messages.
- Patch #29335 by jonbob: shuffled the case-statements around for performance's sake.
- Patch #23750 by jerakeen: use the creation date rather than the update date in RSS feeds.
- Patch #24002: fixed node created timestamp changing on node edit.
- Patch #26637 by Robert Douglas: $teaser misnamed in themes theme_node(). TODO: update documentation!
- #25395: Allow for more integers in node_access grant_x columns
- #27864: Correctly distinguish 403s from 404s for nodes.
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
- Patch #27535 by Ber: set 'preview status message' using drupal_set_message().
- #27551: Rename check_output() to check_markup(). Needs contrib updates!
- #26458: node_search doesn't node_view, causing bad snippets.
- #26458: node_search doesn't node_view, causing bad snippets.
- Patch #26467 by drumm: make the destination persist across multiple pages and fixed the node delete form to use a return destination.
- Fix oopsie in node_load() after recent patch.
- Updated handbook-link to reflect the recent handbook restructuring.
- Fixed typo in PHPdoc
- Modified patch #25031 by chx: modified node_list() so one has both the module and its type. TODO: update migration page in handbook.
- Patch #25634 by chx: simplified node_load().
- Fix by darix: fixed content type settings broken by berkes' last patch.
- Patches by Ber: move user settings and node settings to admin/settings.
- Fixed problems with filter formats and problem with XML-RPC server.
- Patch #25603 by Stefan: made the sizes of forms consistent. TODO: document the defaults in the PHPdoc comments.
- Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
up the documentation a little.
chx: can you double-check whether the global $conf variable is secure?
(That is, make sure it can't be send using the URL or something.)
- Patch #25121 by Robrecht J.: changed itemized lists with hardcoded CSS to definition lists.
- Patch #16204 by Thox: committed the collapsible form elements patch.
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
- Removing some whitespace
- #18836: Cleanup teaser generation code, and refine handling of PHP code teasers.
- #18836: Cleanup teaser generation code, and refine handling of PHP code teasers.
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
- Patch #18275 by Steven: "create content" menu displays extraneous links. (Not sure if this needs to be backported to DRUPAL-4-6.)
- #18406: make node_page 404 on meaningless nids
- Sort admin-content by descending node date. This got lost in the refinement-filter patch.
* cue Star Wars theme tune * Return of the JavaScript! - #22519: form_autocomplete(): Ajax based autocompletion. Currently used for user names and folksonomy tags.
- Patch by chx: added a db_rewrite_sql() in node_load() just to make sure.
- Patch 20910 by chx: centralize print theme page.
- Patch #20188 by Goba: Node_feed() instructs the nodeapi view call it invokes to deal with the body of the node, but afterwards it only uses the teaser to generate the feed. So the nodeapi hook should be called with teaser processing in mind. This simple patch fixes that.
- Removed weird phpdoc line
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
- Patch #19739 by Uwe: corrected many typo's in the documentation and code comments
- #18817: Clean up plain-text checking (see drupal-devel!)
- #19353: Fix 'submit' button behaviour wrt optional previewing and form errors.
- #17343: Fix safari CSS issues with node admin.
- #19405: Fix SQL in comment block for anonymous users.
- #19089: Remove depency on taxonomy.module by node.module (kjartan)
- #12401: Non-admins should obey workflow wrt revisions.
- Patch #18216: fixed nodeapi settings hook.
- Bumped the RSS version from 0.92 to 2.0
- Patch #18418 by chx: jonbob node_access_view_all patch changed the return value of node_access_where_sql to empty which breaks nicely all queries which are still using this function. This is a good incentive to upgrade to db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not really trivial why the query suddenly not works. Let's make it trivial -- rename it _node_access_where_sql, it is no longer a function to be called from outside. node_access_join_sql similarly.
#18226: Non-admins were not obeying workflow.
#18329: Unify confirmation messages (and make them themable)
- Patch #18045 by JonBob: the node type admin page uses an unclear callback name, and uses arg() where it is not necessary. The attached patch cleans this up by unifying node_types() with node_types_configure().
- Patch #18123 by chx: the $return['distinct'] in the past should have been module_implements('node_grants') but after JonBob's node_access_view_all_nodes, that part happens only if node_grants is in effect, so it is simplified to 1.
#17747: PGSQL improvements
- #17870: Add preview CSS class to node preview (drumm)
- Patch #17687 by Gerhard: removed some cruft.
- Fixing broken search after sql rewrite patches - Minor code style fixes.
- Patch #16558 by JonBob: improved performance of node access checks.
- Fixed broken colspan. Reported by asimmonds.
- Fixed broken colspan.
- Patch #16960 by Goba: fixed content type options.
- Patch #16246 by Moshe: "Here is a patch for node.module since thta hunk failed last time. Note that I've removed the 'delete' link since it doesn't work and is mostly obsolete with the 'mass delete' feature. I've also added smart destination andling to the 'url alias delete' feature."
- Fixing broken drupal_goto() after node submission on PHP5.
- PHP5 fix due object references: node previewing should not put node output into form.
- Fix warning due to old session variable.
#10296: Clean up admin - content: - Mass-delete functionality (with confirmation) - Flexible filtering for the overview table based on status, type and taxonomy. - Missing drupal_goto's - Clean up watchdog messages - Remove some dead code
- Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible). NOTE: this needs to be documented.
- Patch #16111 by chx: fixed some bugs in the db_rewrite_sql() code.
- Patch #16253 by Goba: incremental improvements to the new content markers. Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
- Patch #6025 by Jeremy: avoid data to get lost when two users are editing a node at the same time.
- Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module.
- Modified patch #14170 by Neil: improved default workflow (default node type) configuration page. Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
- I had to modify chx's patch/change because it did not work with PHP5. Please double-check.
- Patch #16026 by chx: fixed node-level permissions.
Documenting a tricky regexp.
- Another code style fix.
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes). - Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
- #15500: Fix tracker not showing nodes without comments. - Tiny code style fix
- The real code fixes ;)
- Reversing bad commit, sorry everyone.
- Various code style fixes
- Patch #14731 by chx: made it possible to rewrite node queries.
- Make the search settings page more user-friendly.
- Fixing a couple of watchdog() calls.
- Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);
* Specify a severity in case you are reporting a warning or error.
* The $link-parameter is now the fourth parameter instead of the third.
TODO: document this in the upgrade guide.
- Patch #14917 by UnConeD/Steven: 1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module. 2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner. 3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
- Patch #6308 by gordon: allow node_submit() to be used by external interfaces.
#11548: node.module - Ensure that only valid fields are saved
- Patch #14709 by matteo: added missing call to the nodeapi's 'view' hook.
#12793: Remove dependency of node.module on search.module.
- Patch #13907 by Neil: less ways to set the page title. * Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
- Removed some cruft: left-over xxx_help_page() functions.
- Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard.
- Slight addition to INSTALL.txt with regard to PHP versions.
- Updated/reworded some node type descriptions as per Boris' suggestions.
- Adding missing {} around a table name in update.php.
Search: indexing should invoke nodeapi to catch all user-visible data (e.g. file attachment names).
- Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type.
- Modified patch #11840 by Stefan: added conctext-sensitive help text to the 'revision'-page.
- Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
1. Update theme upgrade instructions in the handbook: node_link() is gone.
2. Remove page_link() just like we removed node_link().
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend. Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
Search.module: - Caching index statistics - Minor code cleanup
Search indexing bug: last updated timestamp needs to take last comment timestamp into account.
- Patch #8506 by Gerhard: added basic node_load() caching.
- Patch #12783 by Stefan: various small consistency/usability improvements.
- Patch #11940 by kps: if the user is not allowed to view a newly submitted node, redirect him to the main page.
- Slightly modified the API of node_title_list(): it will no longer call comment_num_all() for each node. Instead, it checks for the availability of the node_comment field, available through the node_comment_statistics table. If updated the Doxygen comments accordingly. People were using node_title_list() without realizing it would do numereous database queries. This change greatly reduces the number of database queries required to render the node statistics block as well as to render the forum block (coming up next). If your module is using node_title_list() and you want the number of comments to be shown as title attributes, chances are you have to update your SQL query to join node_comment_statistics.
- Patch #12232 by Steven: more search improvements: + When a comment is posted, a node needs to be re-indexed. Luckily, we can use node_comment_statistics for this easily. + When a node is deleted, it should be deleted from the search index as well. + The search wipe didn't properly remove links to nodes from the index. + Section url was faulty in _help. + Minor code rearrangement.
- Patch by Steven:
+ Display 'friendly' name rather than module name in search watchdog
messages.
+ Remove left-over from search_total table.
+ Add index wipe button to the admin
+ Moved the admin to admin/settings/search
+ Prevented menu bug when node modules update the breadcrumb in view
(thanks JonBob).
+ Changed search_total table's word key to PRIMARY.
- Patch #11875 by Neil Drumm: block module configuration improvements. The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
- Patch #12232 by Steven/UnConed: search module improvements. 1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ... 2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes. 3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results. 4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first). 5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic. 6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI). 7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen. 8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency. 9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found. 10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
#7607: Sort node types in node/add by translated names.
- Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output. Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
- Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
- Modified patch #10613 by killes: generate a 'page not found'-page when a requested node does not exist. I modified the patch to avoid duplicate 'not found'-checking in the second bulk.
- Code improvement: removed some redundant code from the node module.
- Fixed bug #11405: unchecking the "publish" box in the default workflow admin page (admin/node/configure/defaults) did not cause the default workflow to change. This was caused by the fact that node_validate() forced the value of the status field to "1".
- Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache.
Part of #11280: node_preview() should only generate a teaser if none is present (e.g. provided by a module like excerpt.module).
Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea.
- Patch #10977 by Gerhard: added missing node access controls for RSS feeds.
- Patch #10884 by killes: node_access_where_sql() lost a parameter.
- Bugfix: it was not possible to delete nodes. Reported by Philippe.
- Patch #8179 by JonBob: reintroduced menu caching.
Removing useless 'read more' title attribute, as discussed.
#8424: more meaningful link title=".." attributes for node_title_list().
Replace hardcoded <html lang="en"> with a locale dependant one. This is especially important for asian sites where this has an effect on font selection.
- Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
- Bugfix: removed bogus $name parameters. TODO: when 'previewing' an existing node, the breadcrumb trail is incorrect.
Node.module: teaser autogeneration should not overwrite user/module-supplied teaser data. (makes excerpt.module possible)
- #10342: PHP5 fix with undefined array.
- Fixing bug with PHP5 patch.
- #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken.