Parent Directory
| 
Revision Log
| 
Revision Graph
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Tag: |
#637710 by jhodgdon, heather, and arianek: Update Poll and Dashboard to new help standard.
- Patch #583730 by sun: fixed form caching.
Roll-back of #595084; type-hinting parameters at stdClass makes it so you can't ever pass in another type of class.
- Patch #595084 by c960657: use type hinting for .
#600974 by effulgentsia, JohnAlbin, sun, and Damien Tournoud: Allow theme functions to take one argument without any hacks. NOTE: This is an API change in hook_theme().
- Patch #607802 by catch: fixed broken database query.
- Patch #593746 by #593746 by sun, andypost: prepare Drupal core for dynamic data translation.
- Patch #599804 by effulgentsia, catch: unify page, AJAX 'path', and AJAX 'callback' callbacks. Oh my, this is the beginning of something big.
#557292 by peximo, plach, catch, and yched: Convert node title to Field API.
- Patch #572618 by effulgentsia, pwolanin, sun: all theme functions should take a single argument. Code clean-up and performance improvement. Woot.
- Patch #511986 by tgeller, sun | lambic: made the values for 'Poll duration' should regular.
- Patch #551694 by effulgentsia, rfay, sun | moshe weitzman, Dries: standardized the return of status messages in AJAX callbacks.
#571086 by sun and merlinofchaos: Added a 'wrapper callback' that executes before a form builder function, to facilitate common form elements. Clean-up from form_builder changes from CTools patch. Has nice side-benefit of making all form functions' signatures consistent.
#395132 by jhodgdon: Fix phpdoc comment on poll_node_form_submit(); there is no hook_submit() in Drupal 6 and this gets called based on the form's key
- Patch #453588 by alienbrain, Jody Lynn: poll use for hook_link() no longer applies.
- Patch #560746 by dropcube: rename hook_block_list() to hook_block_info() for consistency in the API.
#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.
Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.
*** empty log message ***
#326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: Convert 'class' attribute to use an array, not a string.
#552520 by merlinofchaos: Fixed AJAX wrappers on poll/upload modules.
- Patch #537862 by Crell, Amitaibu, salvis: simplify and make more flexible the node access by converting hook_access() to hook_node_access().
#516138 by yched, KarenS, quicksketch, bangpound, et al.: CC-FREAKING-K IN CORE! OH YEAH! :D
#544418 by merlinofchaos, sun, drewish, quicksketch, et al: Integrate CTools AJAX framework with Drupal to extend (and replace) existing ahah framework. Everything about AJAX/AHAH is more betterer now.
#395132 by jhodgdon: Fix inaccurate documentation for poll_node_form_submit().
- Patch #506976 by catch: rename hook_perm to hook_permission.
- Patch #409750 by yched et al: overhaul and extend node build modes.
#220233 by Berdir, marcingy, et al: Add useful API functions for extracting node type data.
#372650 by stella and alienbrain: Fixes to poll block.
- Patch #474302 by stella: poll module fixes.
- Patch #472642 by stella, agentrickard: remove 'implementation of' nominalizations from Docblocks.
- Patch #470594 by Moshe: convert more pages and blocks to return arrays.
- Patch #353069 by Moshe Weitzman, dmitrig01: make drupal_get_form() return unrendered forms.
- Patch #457532 by Berdir: more PHP5 'fixes'.
- Patch #440894 by brianV: code style and documentation clean-up.
#404116 by neclimdul: Provide default choices on poll translations.
- Patch #226876 by csevb10, dave reid, et al: converted more queries to the new database abstraction layer.
#371231 by JohnAlbin and EclipseGC: Rename clear-block CSS class to clearfix, which is the lingo that designers use for it.
- Patch #355236 by Frando: refactor drupal_render() theming.
#360128 by quicksketch: Create centralized ahah callback to reduce duplicate code.
- Patch #360605 by Berdir: made CVS HEAD compatible with PHP5.3.
- Patch #360785 by Dave Reid: add timestamp to {poll_votes}.
#8 by sun and most of #drupal: Users can now cancel their accounts. Fixing the 8th issue, almost 8 years later, on January 8th, after working 8 days full-time on it. GREAT WORK :D
- Patch #350984 by Moshe: kick comment rendering out of node module.
- Patch #331708 by chx: poll_choice_js uses FAPI2.
- Patch #331708 by chx: convert poll_choice_js to FAPI2.
- Patch #345866 by alexanderpas, justinrandell, Dave Reid: remove from hook_block().
- Patch #319356 by recidive: clean up hook_nodeapi_ fucntion signatures and documentation because of previous node API clean-ups.
- Patch #324313 by catch et al: load multiple nodes and terms at once.
- Patch #288039 by sun, ff1, agentrickard, fgm, ultimateboy: improved usability of the aliased URL admin page.
#282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.
#319466: SA-2008-47 (#295053): CSRF in cached forms.
#313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names
#206138 by pwolanin: Rename mis-named 'module' attribute in node types.
- Patch #310212 by justinrandell, catch, et all: killed in _user hook, as well as two small kittens.
#67895 patch by goba, tested by JirkaRybka and blackdog: move poll votes with poll options, when an option is removed, instead of dropping all old votes, solving an old data loss bug. Backport by dww.
- Patch #305645 by pwolanin: ['REQUEST_TIME'] -> REQUEST_TIME. Improved developer experience.
- Patch #302763 by Dave Reid, Rob Loach: replace time() by ['REQUEST_TIME'] as per Rasmus' suggestion. Removed drupal_referrer() for consistency.
Drupal 6.4.
- Patch #245329 by christefano and dmitrig01: code comment love.
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
- Patch #193076 by quicksketch, dmitrig01 and paul.lovvik: drag and drop support for poll module.
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit et al. Can you say 'registry'? Drupal now maintains an internal registry of all functions or classes in the system, allowing it to lazy-load code files as needed (reducing the amount of code that must be parsed on each request). The list of included files is cached per menu callback for subsequent loading by the menu router. This way, a given page request will have all the code it needs but little else, minimizing time spent parsing unneeded code.
#153998 follow up by salvis: we should return NULL if access cannot be granted based on permissions so the node level permission system can take it forward
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
- Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php. The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:
block-user-0.tpl.php --> block-user-navigation.tpl.php
block-user-1.tpl.php --> block-user-login.tpl.php
You get the picture.
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
- Patch #209236 by traxer: added a validation function for the poll form.
#153998 by David_Rothstein and myself: clean up permissions in book, blog, blogapi, forum and locale modules
- Patch #202078 by chx: fixed poll AHAH problem with caching.
#203582 by David_Rothstein: some core hook_access() implementations are not using the passed in account
#204996 by chx: poll bar theme gets NULL as default, so use that here as well
- Patch #204996 by chx: fixed access check and warning in poll module.
#64388 by Gábor Hojtsy. Add missing db_rewrite_sql(); not a security issue since it is a count() query.
#89218 by Gábor Hojtsy. Properly initialize a counter variable and fix poll editing.
#67895 patch by myself, tested by JirkaRybka and blackdog: move poll votes with poll options, when an option is removed, instead of dropping all old votes, solving an old data loss bug
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
#189025 by AjK: fix two small E_ALL bugs in poll.module
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
#198579 by webernet and hswong3i: a huge set of coding style fixes, including: - whitespaces at end of lines - indentation - control structure usage - whitespace in empty lines - phpdoc comment formatting
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
- Patch #162381 by Heine et al: properly escape strings.
#120960 by blakehall, JirkaRybka, catch: improve usability of content editing permission names
#189009 by AjK: edit own poll permission was missing from poll module (although available for other content types)
- Patch #89196 by catch, keith, earnie, webchick et al: string massaging.
#184198 by Eaton: move button title change in polls to the theme, so it does not interfere with the cached form
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
#184199 by quicksketch: proper weights for poll form fields, so the fields are not reordered
- Patch #155870 by quicksketch et al: AHAH-ification of the poll module.
#72487 by chx, pwolanin and moshe weitzman: let node_access() work on arbitrary users, so independent user access checks can be done in a request
#110511 by bjaspan: poll listing page should have a 'count_sql' because the original query uses group by, so it is not countable properly
#172642 by dvessel: block theme file name suggestion for poll nodes
- Patch #172836 by Crell: split poll module.
#170677 by chx: roll back poll data loading to the load operation
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
#111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op)
#110511 by bjaspan: poll listing page should have a 'count_sql' because the original query uses group by, so it is not countable properly
- Patch #163723 by Eaton and Frando: fix default page.tpl markup (and removed some whitespace).
- Patch #162871 by merlinofchaos: poll module cleanup + tplified the module.
Drupal 5.2
- Rollback of patch #147723: delete API. Talked to Steven and Gabor and we unanimously agreed to rollback the deletion API. We all support the features this patch added, yet not its actual design and implementation. After some talk, we decided that it would be better for Drupal -- in the long term -- not to go with a solution that isn't 100%. We also recognize that in the short term, this patch would have been useful addition. So let's figure out how we can implement this properly in D7.
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
#147723: Deletion API (by hunmonk). Woop woop.
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
- Patch #142773 by kbahey: made Drupal work correctly when behind a reverse proxy.
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
#130971: Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
- Patch #113603 by chx: first crack at re-implementing tabs.
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
#104617 by robertDouglass. Use more efficient stlye which hits the static cache.
- Patch #102413 by yched: path node/add/[poll|forum|blog] defined twice.
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
#84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc
- Patch #87957 by Eaton: poll module form fixes.
#83998 by erdemkose. Remove ability to cancel votes more than once.
- Rollback of patch #68418: clean up node submit hooks. Needs more thinkering. Restores the old node API.
- Patch #80952 by earl, webchick, neclimdul et al: .info files
- Patch #80860 by eaton et al: use form API multistep for poll.module
- Patch #68418 by Moshe et al: clean up node submit hooks.
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
#39432 by chx. Invalidate the page cache if a poll is voted on.
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
#76802: Introduce placeholder magic into t() See: http://drupal.org/node/64279#t-placeholders
#77183 by m3avrck and timcn, split up drupal.css by module.
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing. Once again, we're paving the path for CCK in core ... :)
- Patch #77422 by timcn: corrected various paths in the documentation.
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
#73884 by RobRoy, various code cleanup.
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
- Patch #72343 by Chris Johnson: removed checks for the moderate-flag from the SQL queries.
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
#71925 by Steven, remove # prefix from link array keys.
- Patch #44920 by Crell et al: added support for a sites/all directory.
- Patch #51561 by dww: fixed broken HTML.
- Modified patch #51561 by dww: optionally allow people to inspect votes, and to cancel their vote.
#61802 by Zen, Double spaced sentences clean up
#57845, fixed broken link in poll help, patch by Markus Petrux
#58166, fixes for typos, patch by Uwe Herrmann
#56921, revert earlier patches, patch by chx
#56921 by chx, removing the $form = from $form = form_builder($form_id, $form) then it works.
#56789, remove left over call to node_title_validate, patch by chx
#53348, Handling of deleted/blocked user accounts, patch by jreyero and Zen
#54508, remove extra </div>, patch by introfini
- Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
- Patch #50045 by merlinofchaos: fixed previews getting lost.
- Patch #48918 by chx: remove POST from poll.
- Patch #41755 by Cvbge: 1. "int(10)" -> "int", fixed typo in index name [pgsql change only] 2. added defaults for uid and hostname (needed for both) 3. postgres supports "DROP column" syntax 4. added missing DELETEs for new table in poll_delete() and poll_update()
- Patch #41755 by Neil: normalize poll.polled database column.
- Patch #40630 by Morbus: made sure $teaser is always defined.
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
- #39054: Missing url() for poll form action
- Patch #38476 by crunchywelch: make voting on polls work from blocks in the sidebar.
- Patch #35644 by webchick: forms API simplificiations.
- SQL query maintenance: '%d' -> %d.
#36791: node_validate was called twice
- Patch #35481 by javanaut: make the 'more choices' option for polls work.
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
- Patch #35086 by stefan: improved themeability of the poll results.
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
- Removing tabs and trailing whitespaces.
- Patch #29465: new form API by Adrian et al. TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
- Patch #10056: allow the node title forms to be customized.
- Renamed _node() to _node_info()! We reserve _node for _nodeapi.
- Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
- Patch #29385 by chx: no ?> add end of files.
- Patch #25634 by chx: simplified node_load().
- Patch #25603 by Stefan: made the sizes of forms consistent. TODO: document the defaults in the PHPdoc comments.
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
- Patch 20910 by chx: centralize print theme page.
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
- #18817: Clean up plain-text checking (see drupal-devel!)
- Clean up some db queries in poll.module
- #14767: Do not display poll block when no polls are active - Change double to single quotes.
- #18597: Resolve conflict in column name between queue.module and poll.module.
- Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
- anchor link fix in distributed auth help
- "my account" link fix in user help
- spelling correction in tracker.module help
- I also changed 'admin/access/perms' to 'admin/access/permissions'.
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
- Patch #14936 by Goba: + The "add new comment" was missing for polls. + Renames $main to $teaser where appropriate to follow latest Drupal conventions.
- Patch #14936 by Junyor: the 'add comment link' was not available for polls.
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes). - Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
- Patch #14731 by chx: made it possible to rewrite node queries.
- Patch #13907 by Neil: less ways to set the page title. * Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
- Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
1. Update theme upgrade instructions in the handbook: node_link() is gone.
2. Remove page_link() just like we removed node_link().
- Patch #11875 by Neil Drumm: block module configuration improvements. The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
Removing dead code from poll.module.
- Patch #8179 by JonBob: reintroduced menu caching.
- Patch #10622 by Adrian: fixes various PostgreSQL related problems. 1) Menu problems with Postgres (this is a highly critical 1 line fix) 2) Archive module fails with Postgres 3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch) 4) Book module fails with Postgres 5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug. 6) Creating accregator_item_table in PostgreSQL 7) Postgres - Polls not displayed on Poll Page 8) Blog module has sql errors with postgres This should not affect MySQL users (hopefully).
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
- Code improvements by Stefan: made all status messages consistent (and easier to translate).
- Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
- Patch #9543 by JonBob: added node-level access control!
- Patch #5347 by JonBob:
Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
Advantages of this refactoring:
- I can use it for book.module to remove the extra viewing path.
- The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
- We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
- The attachment.module people could use it to append their attachments in a list after the node.
- Gabor could use it instead of his filter perversion for his "articles in a series" module.
- A little less code in each view hook.
- The content hook is no longer needed, so that means even less code.
Disadvantages:
- Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
- Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
- Moving the title.module from core to contrib as discussed on the mailing list.
- Patch #9049 by JonBob: fixed a number of tab issues.
Fixed broken poll results: - If you are allowed to vote, results are now shown on a separate node tab "node/id/results". - Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
- Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
- Patch #8681 by stefan: fixed some broken URLs and help texts.
Tabs patch!
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
- Patch #7577 by JonBob: code improvements to the book, forum, page and poll module.
- Added support for 403 handling. Patch by JonBob. As a side benefit, administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
Left-over debug statement. oopsie.
Poll.module / Statistics.module: fixing bug caused by using array_merge and drupal_map_assoc. This causes array keys to be renumbered, leading to bugs. Remember to use $array1 + $array2 instead.
Poll.module / Statistics.module: fixing bug caused by using array_merge and drupal_map_assoc. This causes array keys to be renumbered, leading to bugs. Remember to use $array1 + $array2 instead.
- Patch by Gerhard: move the updates to database/updates.inc so packaging systems can by-pass update.php.
Fixing old poll issue for 4.3.
Poll.module cleanup: * Code cleaning: simpler structures, removed some old leftovers, ... * Clean URLs everywhere (the old mechanism was broken anyway). Had to get rid of 'inline voting' (i.e. voting with the sideblock and ending up on the same page), but that was a bit confusing anyway. * Simplified submission form with form_group and streamlined choice mechanism. * Improved bar rendering in pollresults for themes with avatars, like xtemplate.
- Patch 5592 by Goba: let drupal_map_assoc() rule. :-) - Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
- Patch 5049 by JonBob: allow a module to define multiple node types.
Patch 5287 by Stefan: multiline help texts should become inside a single $output.
- Patch #5021: clean up URLs in _help texts. Patch by UnConeD.
- Patch 4948 by Goba: the poll module uses check_output() on the poll options.
General filtering improvements - Re-added STYLE/ON*= filtering (this got lost a while ago due to reorganisation) - Added form_group's to node.module's filter options - Fixed incorrect filter usage in poll.module
- The introduction of the $page parameter for the node _view() hooks and the theme functions left the poll module's poll_view() function in a state where it does not display the poll results or vote forms on their own pages, since it uses another (proprietary) $block parameter to handle the case when the poll is rendered to be displayed in a block. Patch by Goba.
- Updated the calls to menu() to use MENU_HIDE instead of 1
- Committed phase 4 of JonBob's menu system changes.
- Committed phase 3 of JonBob's menu changes. Adds an API for modules to define titles and breadcrumbs for their pages, and updates the theme system to display them.
- Patch by JonBob: Phase 2 of the menu system integration project. This unifies the interface used by admin and non-admin pages, and deprecates the _page hook in favor of explicit callbacks from menu(). Breadcrumbs, titles, and help text go away as a result of this patch; they will return in the phase 3 patch, printed by the theme.
- Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX.
- Committed stage 1 of the menu callbacks improvements. Patch by Jonathan.
- Usability improvement: replaced many selection boxes by radio buttons. Patch by Stefan.
poll.module: Fixed invalid XHTML (Patch by Gabor Hojtsy)
poll.module: Fixed invalid XHTML (Patch by Gabor Hojtsy)
- Committed part 3 of Michael's help system improvements: removed the $help parameter from the menu() function.
- Help system improvements: eliminated the _system hook. Patch by Michael. - Bloggerapi module fixes. Patch by Kjartan. - Coding style fixes. Patch by Michael.
- Small poll block improvement (without configuration option). Patch by Gabor.
- Help improvements and translation improvements from Michael. Thanks!
- Associate a callback with the menu links! (This callback is not yet being called but will be as soon the remaining links have been transformed to use the menu system.) - Made sure the menu does not render links with no callback and no children. Like this, the 'create content' link is not being shown when the user has no permission to add any content.
- Committed Goba's translation fixes.
- Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
menu.
2) The user module part of the patch did not apply due to Kjartan's earlier
patch.
- Committed the admin menu integration patch. Thanks Adrian, Stefan and others.
- Updated the poll module to use the _validate hook. Fixes bug #2918 reported by Jonathan.
- Committed Nick's _content improvements.
- Fix for bug #2733: devision by zero. Patch by Jonathan.
- Book module improvements. This commit changes the behavior of the "view" hook. See mailing list for details; search for a mail with the subject: '[IMPORTANT] behavior of "view" hook changed'. Modified patch from Nick.
- Bugfix: made deleting polls work. Patch by Marco.
- Bugfix: made deleting polls work. Patch by Marco.
- Performance improvement: changed a fair amount of "left joins" to "inner joins". Patch by Gerhard.
- Committed a slightly modified version of Slavica's table prefix patch.
- Bugfix: fixed problem with changing themes. Didn't apply Al's patch as the fix was somewhat simpler. Fixes bug #2003. - Bugfix: fixed problem with voting on certain poll pages. Patch #37 by Al. - Improvement: removed stupid descriptions from profile module.
- Bugfix: corrected typo in the poll module. Patch by Al.
- Improvements: XHTML-ifications. Patch by GmbH.
- Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan. - Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values. Patch by Kjartan. - Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes. Example: <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" /> IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion. - Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions. Patch by Matt Westgate. - Improvement: improved the error checking and the error messages in the profile module. Updated the code to match the Drupal coding conventions. Modified patch from Matt Westgate. - Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head(). Patch by Kristjan. - Improvement: don't execute any SQL queries when checking the permissions of user #1. Patch by Kjartan. - Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes. Part of patch #51 by Al. - Improvement: removed some redundant print statements from the comment module. Modified patch from Craig Courtney.
- Bugfix: fixed problem when register globals is turned off. Patch 0037.poll.register_globals.patch by Al. (Can't we make the result URL look nicer?)
- Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please. - Bugfix: made the "moderate" field behave. Patch 0030.queue.module.help.and.settings.form.patch by Al. - Documentation: revised a large part of the help texts / documentation! Al's 0024.* patches. - Documentation: added a glossary to the help module. Patch 0025.help.module.glossary.patch by Al and Michael. - Usability: first step towards unifying the terminology used in the cloud module. Patch by 0028.site.cloud.rationalize.name.patch Al. - Usability + CSS improvements: revamped the node form and removed all tables. Patch 0027.node.form.rewrite.patch by Al. - CSS improvements: patch 0026.admin.css.small.improvement.patch by Al. - Updated the MAINTAINERS file.
- Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco. ==> This fix requires to run update.php! - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register(). This fixes critical bug #1797. Patch by Marco. - Bugfix: sometimes error messages where being discarded when previewing a node. Patch by Craig Courtney. - Bugfix: fixed charset problems. This fixes critical bug #1549. Patch '0023.charset.patch' by Al. - Code improvements: removed some dead code from the comment module. Patch by Marco. - Documentation improvements: polished the node module help texts and form descriptions. Patch '0019.node.module.help.patch' by Al. - CSS improvements all over the map! Patch '0021.more.css.patch' by Al. - GUI improvements: improved the position of Druplicon in the admin menu. Patch '0020.admin.logo.patch' by Al. - GUI improvements: new logos for theme Marvin and theme UnConeD. Logos by Kristjan Jansen. - GUI improvements: small changes to the output emitted by the profile module. Suggestions by Steven Wittens. - GUI improvements: small fixes to Xtemplate. Patch '0022.xtemplate.css.patch' by Al. TODO: - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register(). They should be updated. We should setup a task on Drupal. - There is code emitting '<div align="right">' which doesn't validate. - Does our XML feeds validate with the charset changes? - The forum module's SQL doesn't work properly on PostgreSQL.
- Better CSS for the poll module.
- Al's CSS patches. This commit improves the themability of some core components such as lists, form items, removes an ugly hack from the archive module and should fix the poll problem (although it doesn't Opera/Konqueror).
- Michael Frankowski's excellent help text improvements!
- Updated Drupal to use "on output" filters. Derived from Gerhard's patch.
- Fixed register_globals issue. Patch by Michael.
- Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski. - Fixed a typo in the MSSQL database scheme. Patch by Michael Frankowski. - Removed dependency on "register_globals = on"! Patches by Michael Frankowski. Notes: + Updated the patches to use $foo["bar"] instead of $foo['bar']. + Updated the INSTALL and CHANGELOG files as well. - Tiny improvement to the "./scripts/code-clean.sh" script.
- Applied Michael Caerwyn's "%s -> %d" patch. - Changed all occurences of '%d' to %d as suggested on the mailing list.
- Fixed some PHP "notices".
A batch of changes:
- Renamed '---' to '<!--break-->'.
- Removed hard-coded call to the statistics module from the node module.
Patch by Gerhard.
- Removed tables from poll module. Modified patch by Al. Changes to Al's
patch are:
"polltext" -> "poll-text"
"pollfg" -> "poll-foreground"
"pollbg" -> "poll-background"
- Changed some 'statistics.foo's to 's.foo's. Patch by Gary.
[If this closes any bug reports, please update them on drupal.org.]
- Bugfix by Al.
- Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
* Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
moderation.
- Moved some admin menus around and cleaned up some typos.
- Everything is using theme("function") now instead of $theme->function().
- See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html.
- Moved the filter()s back to the individual node modules as it used to be.
- Applied Ori's format_plural() patch; see mailing list for details. NOTE: some modules in the contributions repository might need to be updated.
- Clean URL patch.
o Permission improvements: + Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc. o Usability improvements to teasers: + Teaser forms are no more. Teasers are extracted automatically but can also be instructed using a delimiter "---". Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore. + Added an option to set the teaser length, or to disable teasers all together. + When previewing a post, both the short (if any) and the full version of a post are shown. This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post. + Forum posts can be teasered now. This is particularly helpful in the context of drupal.org where we promote forum topics. o Bugfix: replaced all PHP short tags (<?) with long tags (<?php). o Bugfix: removed hard-coded dependence on comment module. o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages. o Bugfix: applied modified version of Marco's node_teaser() fix.
- Added missing filter. Patch by Marco.
- Committed Marco's block rewrite:
+ Blocks are not longer called if not rendered: major performance
improvement.
+ Fixed some bugs (preview option was broken, path option was broken).
+ Removed "ascii"-type blocks.
+ Added permission to for "PHP blocks"
+ ...
NOTES:
+ You'll want to run "update.php":
ALTER TABLE blocks DROP remove;
ALTER TABLE blocks DROP name;
+ You'll want to update your custom modules as well as the modules in
the contrib repository. Block function should now read:
function *_block($op = "list", $delta = 0) {
if ($op == "list") {
return array of block infos
}
else {
return subject and content of $delta block
}
}
- Wrapped some hardcoded colors in "theme_invoke()"s; we can still create a drupal_error() later on but I think we better get used to theme_invoke(). - Fixed translation bug. Patch by Moshe. - Fixed PHP warning. Patch by ax.
- Applied Marco's poll.module patch.
- Fixed missing filtering
- Fixed missing filtering
- Another "SELECT... LEFT JOIN... GROUP BY... ORDER BY" by James.
- added missing <ul> tags.
- made poll_page() SQL query valid when running MySQL in ANSI mode.
- Updated the poll documentation. Patch by Scott.
- improved module descriptions. - removed admin options for queue and comment module if the modules are not loaded. - nodes are now auto promoted when queue module isn't enabled. - moderation result block is now visible by the node author.
Poll.module improvements: - Added links to see poll results when you haven't voted yet (and to go back). - Cleaned up code and moved large sections into separate functions for cleaner code - Cleaned up the way of distinguishing between multiple polls on one page (now it just uses the nid)
- adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
* security check isn't in effect if the db hasn't been updated.
* instructions re-organized.
* fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
Poll.module: - Added timestamp (created) sorting to polls page.
Poll.module: Added a page showing a list of older polls.
Fixed unmoderated polls already showing up in the side-block.
- Bugfix: found a bug with the 'create poll' title attribute. It was getting added to the <a> tag as '0="title" 1="Add a new poll."'. Patch by Revar.
- pending user accounts will not be notified to the site_email. - fixed access checks on the register form, do this before you enter the _save function. If registrations are disabled the register link will no longer show (again). - changed » to », using the names of entities are better than the numbers. - fixed user information being set when account is registered (properly this time, really!) - reversed the if(!...) commit. - node_add specifies more defaults. - added link to blog entries from user page.
- node security fixes. - fixing the UI to represent what actually happens when you are an admin.
Poll.module: Node links didn't always show up in the poll side-block, only when having voted. Fixed.
Poll.module: Cosmetical bugfix, "1 vote" instead of "1 votes" (using format_plural)
- updating all nodes to use taxonomy terms. - updated node modules not to cause errors when taxonomy module is disabled. - added %date variable to user mail configuration. - added hyperlinks to admin.php?mod=system (site configuration) for easy access. - usual coding style and xhtml fixes.
Possible bug with filtering: linebreaks inside style's got converted into breaks.
- applied Stevens link patch. - fixed block permissions. - fixed user admin page errors: http://www.drupal.org/node.php?id=173. - cleaned up common.inc a bit: removed format_info, path_img, field_merge.
Code-style fix
Poll.module: - (forgot to mention in the last update) The side-block for the poll now has node-links - Prevented 'read more' links (there's nothing to 'read more' for polls)
Poll.module: - Fixed edit form not defaulting to the correct amount of choices.
- bug fixes:
* fixed mails not being parsed properly.
* tracker now shows user name when you view your own recent
comments.
* link to submission queue now points to the right place.
* fixed jabber module.
* theme is now activated when changed.
- applied Gerhards coding style patch.
- Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.
+ Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.
+ XHTML-ified some HTML.
+ Wrapped a lot of text in the administrative pages in a t()
function.
+ Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().
+ Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
RSS code).
+ Fixed some bugs in the taxonomy module (eg. tree making bug), added
new functionality (eg. new APIs for use by other modules), included
Moshe's taxonomy extensions, and some documentation udpates.
+ ...
Updated poll.module: - Removed obsolete lid column (changed update.php and database.mysql) - Added short help
- book log is now saved and shown when necessary. - fixed poll title not showing up.